7fffe99328
Due to being a compositor, kwin has to conform to some certain interfaces. It means a lot of virtual functions and function tables to integrate with C APIs. Naturally, we not always want to use every argument in such functions. Since we get -Wunused-parameter from -Wall, we have to plumb those unused arguments in order to suppress compiler warnings at the moment. However, I don't think that extra work is worth it. We cannot change or alter prototypes in any way to fix the warning the desired way. Q_UNUSED and similar macros are not good indicators of whether an argument is used too, we tend to overlook putting or removing those macros. I've also noticed that Q_UNUSED are not used to guide us with the removal no longer needed parameters. Therefore, I think it's worth adding -Wno-unused-parameter compiler option to stop the compiler producing warnings about unused parameters. It changes nothing except that we don't need to put Q_UNUSED anymore, which can be really cumbersome sometimes. Note that it doesn't affect unused variables, you'll still get a -Wunused-variable compiler warning if a variable is unused.
57 lines
1.6 KiB
C++
57 lines
1.6 KiB
C++
/*
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
SPDX-FileCopyrightText: 2016 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
SPDX-License-Identifier: GPL-2.0-or-later
|
|
*/
|
|
#include "mock_gl.h"
|
|
#include <epoxy/gl.h>
|
|
|
|
MockGL *s_gl = nullptr;
|
|
|
|
static const GLubyte *mock_glGetString(GLenum name)
|
|
{
|
|
if (!s_gl) {
|
|
return nullptr;
|
|
}
|
|
switch (name) {
|
|
case GL_VENDOR:
|
|
return (const GLubyte *)s_gl->getString.vendor.constData();
|
|
case GL_RENDERER:
|
|
return (const GLubyte *)s_gl->getString.renderer.constData();
|
|
case GL_VERSION:
|
|
return (const GLubyte *)s_gl->getString.version.constData();
|
|
case GL_EXTENSIONS:
|
|
return (const GLubyte *)s_gl->getString.extensionsString.constData();
|
|
case GL_SHADING_LANGUAGE_VERSION:
|
|
return (const GLubyte *)s_gl->getString.shadingLanguageVersion.constData();
|
|
default:
|
|
return nullptr;
|
|
}
|
|
}
|
|
|
|
static const GLubyte *mock_glGetStringi(GLenum name, GLuint index)
|
|
{
|
|
if (!s_gl) {
|
|
return nullptr;
|
|
}
|
|
if (name == GL_EXTENSIONS && index < uint(s_gl->getString.extensions.count())) {
|
|
return (const GLubyte *)s_gl->getString.extensions.at(index).constData();
|
|
}
|
|
return nullptr;
|
|
}
|
|
|
|
static void mock_glGetIntegerv(GLenum pname, GLint *data)
|
|
{
|
|
if (pname == GL_NUM_EXTENSIONS) {
|
|
if (data && s_gl) {
|
|
*data = s_gl->getString.extensions.count();
|
|
}
|
|
}
|
|
}
|
|
|
|
PFNGLGETSTRINGPROC epoxy_glGetString = mock_glGetString;
|
|
PFNGLGETSTRINGIPROC epoxy_glGetStringi = mock_glGetStringi;
|
|
PFNGLGETINTEGERVPROC epoxy_glGetIntegerv = mock_glGetIntegerv;
|