7292af3d04
With fractional scaling integer based logical geometry may not match device pixels. Once we have a floating point base we can fix that. This also is important for our X11 scale override, with a scale of 2 we could get logical sizes with halves. We already have all input being floating point, this doubles down on it for all remaining geometry. - Outputs remain integer to ensure that any screen on the right remains aligned. - Placement also remains integer based for now. - Repainting is untouched as we always expand outwards (QRectF::toAdjustedRect(). - Decoration is untouched for now - Rules are integer in the config, but floating in the adjusting/API This should also be fine. At some point we'll add a method to snap to the device pixel grid. Effectively `round(value * dpr) / dpr` though right now things mostly work. This also gets rid of a lot of hacks for QRect right and bottom which are very confusing. Parts to watch out in the port are: QRectF::contains now includes edges QRectF::right and bottom are now sane so previous hacks have to be removed QRectF(QPoint, QPoint) behaves differently for the same reason QRectF::center too In test results some adjusted values which are the result of QRect.center because using QRectF's center should behave the same to the user.
71 lines
1.5 KiB
C++
71 lines
1.5 KiB
C++
/*
|
|
SPDX-FileCopyrightText: 2021 Vlad Zahorodnii <vlad.zahorodnii@kde.org>
|
|
|
|
SPDX-License-Identifier: GPL-2.0-or-later
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "surfaceitem.h"
|
|
|
|
#include <xcb/damage.h>
|
|
#include <xcb/xfixes.h>
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
/**
|
|
* The SurfaceItemX11 class represents an X11 surface in the scene.
|
|
*/
|
|
class KWIN_EXPORT SurfaceItemX11 : public SurfaceItem
|
|
{
|
|
Q_OBJECT
|
|
|
|
public:
|
|
explicit SurfaceItemX11(Window *window, Item *parent = nullptr);
|
|
~SurfaceItemX11() override;
|
|
|
|
void preprocess() override;
|
|
|
|
void processDamage();
|
|
bool fetchDamage();
|
|
void waitForDamage();
|
|
void destroyDamage();
|
|
|
|
QRegion shape() const override;
|
|
QRegion opaque() const override;
|
|
|
|
private Q_SLOTS:
|
|
void handleBufferGeometryChanged(Window *window, const QRectF &old);
|
|
void handleGeometryShapeChanged();
|
|
|
|
protected:
|
|
std::unique_ptr<SurfacePixmap> createPixmap() override;
|
|
|
|
private:
|
|
xcb_damage_damage_t m_damageHandle = XCB_NONE;
|
|
xcb_xfixes_fetch_region_cookie_t m_damageCookie;
|
|
bool m_isDamaged = false;
|
|
bool m_havePendingDamageRegion = false;
|
|
};
|
|
|
|
class KWIN_EXPORT SurfacePixmapX11 final : public SurfacePixmap
|
|
{
|
|
Q_OBJECT
|
|
|
|
public:
|
|
explicit SurfacePixmapX11(SurfaceItemX11 *item, QObject *parent = nullptr);
|
|
~SurfacePixmapX11() override;
|
|
|
|
xcb_pixmap_t pixmap() const;
|
|
xcb_visualid_t visual() const;
|
|
|
|
void create() override;
|
|
bool isValid() const override;
|
|
|
|
private:
|
|
SurfaceItemX11 *m_item;
|
|
xcb_pixmap_t m_pixmap = XCB_PIXMAP_NONE;
|
|
};
|
|
|
|
} // namespace KWaylandServer
|