84d75cb567
Summary: KDE is known for having a strong view on the client-side decorations vs server-side decorations issue. The main argument raised against CSD is that desktop will look less consistent when clients start drawing window decorations by themselves, which is somewhat true. It all ties to how well each toolkit is integrated with the desktop environment. KDE doesn't control the desktop market on Linux. Another big "player" is GNOME. Both KDE and GNOME have very polarized views on in which direction desktop should move forward. The KDE community is pushing more toward server-side decorations while the GNOME community is pushing more toward client-side decorations. Both communities have developed great applications and it's not rare to see a GNOME application being used in KDE Plasma. The only problem is that these different views are not left behind the curtain and our users pay the price. Resizing GTK clients in Plasma became practically impossible due to resize borders having small hit area. When a client draws its window decoration, it's more likely that it also draws the drop-shadow around the decoration. The compositor must know the extents of the shadow so things like snapping and so on work as expected. And here lies the problem... While the xdg-shell protocol has a way to specify such things, the NetWM spec doesn't have anything like that. There's _GTK_FRAME_EXTENTS in the wild, however the problem with it is that it's a proprietary atom, which is specific only to GTK apps. Due to that, _GTK_FRAME_EXTENTS wasn't implemented because implementing anything like that would require major changes in how we think about geometry. Recent xdg-shell window geometry patches adjusted geometry abstractions in kwin to such a degree that it's very easy to add support for client side decorated clients on X11. We just have to make sure that the X11Client class provides correct buffer geometry and frame geometry when the gtk frame extents are set. Even though the X11 code is feature frozen, I still think it's worth to have _GTK_FRAME_EXTENTS support in kwin because it will fix the resize issues. Also, because KWin/Wayland is unfortunately far from becoming default, it will help us with testing some implementation bits of the window geometry from xdg-shell. BUG: 390550 FIXED-IN: 5.18.0 Test Plan: Things like quick tiling, maximizing, tiling scripts and so on work as expected with GTK clients. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: cblack, trmdi, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D24660
102 lines
4.7 KiB
C++
102 lines
4.7 KiB
C++
/********************************************************************
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
Copyright (C) 1999, 2000 Matthias Ettrich <ettrich@kde.org>
|
|
Copyright (C) 2003 Lubos Lunak <l.lunak@kde.org>
|
|
Copyright (C) 2013 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*********************************************************************/
|
|
|
|
#include "atoms.h"
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
Atoms::Atoms()
|
|
: kwin_running(QByteArrayLiteral("KWIN_RUNNING"))
|
|
, activities(QByteArrayLiteral("_KDE_NET_WM_ACTIVITIES"))
|
|
, wm_protocols(QByteArrayLiteral("WM_PROTOCOLS"))
|
|
, wm_delete_window(QByteArrayLiteral("WM_DELETE_WINDOW"))
|
|
, wm_take_focus(QByteArrayLiteral("WM_TAKE_FOCUS"))
|
|
, wm_change_state(QByteArrayLiteral("WM_CHANGE_STATE"))
|
|
, wm_client_leader(QByteArrayLiteral("WM_CLIENT_LEADER"))
|
|
, wm_window_role(QByteArrayLiteral("WM_WINDOW_ROLE"))
|
|
, wm_state(QByteArrayLiteral("WM_STATE"))
|
|
, sm_client_id(QByteArrayLiteral("SM_CLIENT_ID"))
|
|
, motif_wm_hints(QByteArrayLiteral("_MOTIF_WM_HINTS"))
|
|
, net_wm_context_help(QByteArrayLiteral("_NET_WM_CONTEXT_HELP"))
|
|
, net_wm_ping(QByteArrayLiteral("_NET_WM_PING"))
|
|
, net_wm_user_time(QByteArrayLiteral("_NET_WM_USER_TIME"))
|
|
, kde_net_wm_user_creation_time(QByteArrayLiteral("_KDE_NET_WM_USER_CREATION_TIME"))
|
|
, net_wm_take_activity(QByteArrayLiteral("_NET_WM_TAKE_ACTIVITY"))
|
|
, net_wm_window_opacity(QByteArrayLiteral("_NET_WM_WINDOW_OPACITY"))
|
|
, xdnd_selection(QByteArrayLiteral("XdndSelection"))
|
|
, xdnd_aware(QByteArrayLiteral("XdndAware"))
|
|
, xdnd_enter(QByteArrayLiteral("XdndEnter"))
|
|
, xdnd_type_list(QByteArrayLiteral("XdndTypeList"))
|
|
, xdnd_position(QByteArrayLiteral("XdndPosition"))
|
|
, xdnd_status(QByteArrayLiteral("XdndStatus"))
|
|
, xdnd_action_copy(QByteArrayLiteral("XdndActionCopy"))
|
|
, xdnd_action_move(QByteArrayLiteral("XdndActionMove"))
|
|
, xdnd_action_ask(QByteArrayLiteral("XdndActionAsk"))
|
|
, xdnd_drop(QByteArrayLiteral("XdndDrop"))
|
|
, xdnd_leave(QByteArrayLiteral("XdndLeave"))
|
|
, xdnd_finished(QByteArrayLiteral("XdndFinished"))
|
|
, net_frame_extents(QByteArrayLiteral("_NET_FRAME_EXTENTS"))
|
|
, kde_net_wm_frame_strut(QByteArrayLiteral("_KDE_NET_WM_FRAME_STRUT"))
|
|
, net_wm_sync_request_counter(QByteArrayLiteral("_NET_WM_SYNC_REQUEST_COUNTER"))
|
|
, net_wm_sync_request(QByteArrayLiteral("_NET_WM_SYNC_REQUEST"))
|
|
, kde_net_wm_shadow(QByteArrayLiteral("_KDE_NET_WM_SHADOW"))
|
|
, kde_first_in_window_list(QByteArrayLiteral("_KDE_FIRST_IN_WINDOWLIST"))
|
|
, kde_color_sheme(QByteArrayLiteral("_KDE_NET_WM_COLOR_SCHEME"))
|
|
, kde_skip_close_animation(QByteArrayLiteral("_KDE_NET_WM_SKIP_CLOSE_ANIMATION"))
|
|
, kde_screen_edge_show(QByteArrayLiteral("_KDE_NET_WM_SCREEN_EDGE_SHOW"))
|
|
, kwin_dbus_service(QByteArrayLiteral("_ORG_KDE_KWIN_DBUS_SERVICE"))
|
|
, utf8_string(QByteArrayLiteral("UTF8_STRING"))
|
|
, text(QByteArrayLiteral("TEXT"))
|
|
, uri_list(QByteArrayLiteral("text/uri-list"))
|
|
, netscape_url(QByteArrayLiteral("_NETSCAPE_URL"))
|
|
, moz_url(QByteArrayLiteral("text/x-moz-url"))
|
|
, wl_surface_id(QByteArrayLiteral("WL_SURFACE_ID"))
|
|
, kde_net_wm_appmenu_service_name(QByteArrayLiteral("_KDE_NET_WM_APPMENU_SERVICE_NAME"))
|
|
, kde_net_wm_appmenu_object_path(QByteArrayLiteral("_KDE_NET_WM_APPMENU_OBJECT_PATH"))
|
|
, clipboard(QByteArrayLiteral("CLIPBOARD"))
|
|
, timestamp(QByteArrayLiteral("TIMESTAMP"))
|
|
, targets(QByteArrayLiteral("TARGETS"))
|
|
, delete_atom(QByteArrayLiteral("DELETE"))
|
|
, incr(QByteArrayLiteral("INCR"))
|
|
, wl_selection(QByteArrayLiteral("WL_SELECTION"))
|
|
, m_dtSmWindowInfo(QByteArrayLiteral("_DT_SM_WINDOW_INFO"))
|
|
, m_motifSupport(QByteArrayLiteral("_MOTIF_WM_INFO"))
|
|
, m_helpersRetrieved(false)
|
|
{
|
|
}
|
|
|
|
void Atoms::retrieveHelpers()
|
|
{
|
|
if (m_helpersRetrieved) {
|
|
return;
|
|
}
|
|
// just retrieve the atoms once, all others are retrieved when being accessed
|
|
// Q_UNUSED is used in the hope that the compiler doesn't optimize the operations away
|
|
xcb_atom_t atom = m_dtSmWindowInfo;
|
|
Q_UNUSED(atom)
|
|
atom = m_motifSupport;
|
|
Q_UNUSED(atom)
|
|
m_helpersRetrieved = true;
|
|
}
|
|
|
|
} // namespace
|