abedb464d5
Summary: The test DontCrashUseractionsMenu (Waylandonly) found an issue in our screen handling implementation in the QPA. The code exposed a short time frame between the dummy screen getting destroyed and the first screen being added. This could result in a crash of KWin. There is actually no need to implement Screen on top of Wayland screen. KWin has all the knowledge, so we can also base this on top of the Screens API. Advantages: * no delays due to Wayland roundtrips * handle screen getting removed (was a TODO) * handle resolution changes (was a TODO) The new implementation has a disadvantage that it destroys and readds all screens whenever something around the screen changes. This shouldn't be an issue in practice as it's only for the internal QPA and thus only affects KWin internal windows which is placed in global coordinates anyway. If it turns out to be a problem we need to track better the screen changes - so far those were not tracked at all. Test Plan: Run a few unit tests which change screens Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D8345
54 lines
1.5 KiB
C++
54 lines
1.5 KiB
C++
/********************************************************************
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
Copyright (C) 2015 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*********************************************************************/
|
|
#ifndef KWIN_QPA_SCREEN_H
|
|
#define KWIN_QPA_SCREEN_H
|
|
|
|
#include <qpa/qplatformscreen.h>
|
|
#include <QScopedPointer>
|
|
|
|
namespace KWin
|
|
{
|
|
namespace QPA
|
|
{
|
|
class PlatformCursor;
|
|
|
|
class Screen : public QPlatformScreen
|
|
{
|
|
public:
|
|
explicit Screen(int screen);
|
|
virtual ~Screen();
|
|
|
|
QRect geometry() const override;
|
|
int depth() const override;
|
|
QImage::Format format() const override;
|
|
QSizeF physicalSize() const override;
|
|
QPlatformCursor *cursor() const override;
|
|
QDpi logicalDpi() const override;
|
|
qreal devicePixelRatio() const override;
|
|
|
|
private:
|
|
int m_screen;
|
|
QScopedPointer<PlatformCursor> m_cursor;
|
|
};
|
|
|
|
}
|
|
}
|
|
|
|
#endif
|