7fffe99328
Due to being a compositor, kwin has to conform to some certain interfaces. It means a lot of virtual functions and function tables to integrate with C APIs. Naturally, we not always want to use every argument in such functions. Since we get -Wunused-parameter from -Wall, we have to plumb those unused arguments in order to suppress compiler warnings at the moment. However, I don't think that extra work is worth it. We cannot change or alter prototypes in any way to fix the warning the desired way. Q_UNUSED and similar macros are not good indicators of whether an argument is used too, we tend to overlook putting or removing those macros. I've also noticed that Q_UNUSED are not used to guide us with the removal no longer needed parameters. Therefore, I think it's worth adding -Wno-unused-parameter compiler option to stop the compiler producing warnings about unused parameters. It changes nothing except that we don't need to put Q_UNUSED anymore, which can be really cumbersome sometimes. Note that it doesn't affect unused variables, you'll still get a -Wunused-variable compiler warning if a variable is unused.
109 lines
3 KiB
C++
109 lines
3 KiB
C++
/*
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
SPDX-FileCopyrightText: 2012 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
SPDX-License-Identifier: GPL-2.0-or-later
|
|
*/
|
|
#include "mock_tabboxhandler.h"
|
|
#include "mock_tabboxclient.h"
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
MockTabBoxHandler::MockTabBoxHandler(QObject *parent)
|
|
: TabBoxHandler(parent)
|
|
{
|
|
}
|
|
|
|
MockTabBoxHandler::~MockTabBoxHandler()
|
|
{
|
|
}
|
|
|
|
void MockTabBoxHandler::grabbedKeyEvent(QKeyEvent *event) const
|
|
{
|
|
}
|
|
|
|
QWeakPointer<TabBox::TabBoxClient> MockTabBoxHandler::activeClient() const
|
|
{
|
|
return m_activeClient;
|
|
}
|
|
|
|
void MockTabBoxHandler::setActiveClient(const QWeakPointer<TabBox::TabBoxClient> &client)
|
|
{
|
|
m_activeClient = client;
|
|
}
|
|
|
|
QWeakPointer<TabBox::TabBoxClient> MockTabBoxHandler::clientToAddToList(TabBox::TabBoxClient *client, int desktop) const
|
|
{
|
|
QList<QSharedPointer<TabBox::TabBoxClient>>::const_iterator it = m_windows.constBegin();
|
|
for (; it != m_windows.constEnd(); ++it) {
|
|
if ((*it).get() == client) {
|
|
return QWeakPointer<TabBox::TabBoxClient>(*it);
|
|
}
|
|
}
|
|
return QWeakPointer<TabBox::TabBoxClient>();
|
|
}
|
|
|
|
QWeakPointer<TabBox::TabBoxClient> MockTabBoxHandler::nextClientFocusChain(TabBox::TabBoxClient *client) const
|
|
{
|
|
QList<QSharedPointer<TabBox::TabBoxClient>>::const_iterator it = m_windows.constBegin();
|
|
for (; it != m_windows.constEnd(); ++it) {
|
|
if ((*it).get() == client) {
|
|
++it;
|
|
if (it == m_windows.constEnd()) {
|
|
return QWeakPointer<TabBox::TabBoxClient>(m_windows.first());
|
|
} else {
|
|
return QWeakPointer<TabBox::TabBoxClient>(*it);
|
|
}
|
|
}
|
|
}
|
|
if (!m_windows.isEmpty()) {
|
|
return QWeakPointer<TabBox::TabBoxClient>(m_windows.last());
|
|
}
|
|
return QWeakPointer<TabBox::TabBoxClient>();
|
|
}
|
|
|
|
QWeakPointer<TabBox::TabBoxClient> MockTabBoxHandler::firstClientFocusChain() const
|
|
{
|
|
if (m_windows.isEmpty()) {
|
|
return QWeakPointer<TabBox::TabBoxClient>();
|
|
}
|
|
return m_windows.first();
|
|
}
|
|
|
|
bool MockTabBoxHandler::isInFocusChain(TabBox::TabBoxClient *client) const
|
|
{
|
|
if (!client) {
|
|
return false;
|
|
}
|
|
QList<QSharedPointer<TabBox::TabBoxClient>>::const_iterator it = m_windows.constBegin();
|
|
for (; it != m_windows.constEnd(); ++it) {
|
|
if ((*it).get() == client) {
|
|
return true;
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
QWeakPointer<TabBox::TabBoxClient> MockTabBoxHandler::createMockWindow(const QString &caption)
|
|
{
|
|
QSharedPointer<TabBox::TabBoxClient> client(new MockTabBoxClient(caption));
|
|
m_windows.append(client);
|
|
m_activeClient = client;
|
|
return QWeakPointer<TabBox::TabBoxClient>(client);
|
|
}
|
|
|
|
void MockTabBoxHandler::closeWindow(TabBox::TabBoxClient *client)
|
|
{
|
|
QList<QSharedPointer<TabBox::TabBoxClient>>::iterator it = m_windows.begin();
|
|
for (; it != m_windows.end(); ++it) {
|
|
if ((*it).get() == client) {
|
|
m_windows.erase(it);
|
|
return;
|
|
}
|
|
}
|
|
}
|
|
|
|
} // namespace KWin
|