kwin/autotests/tabbox/mock_tabboxhandler.h
Vlad Zahorodnii 7fffe99328 build: Add -Wno-unused-parameter compiler option
Due to being a compositor, kwin has to conform to some certain
interfaces. It means a lot of virtual functions and function tables to
integrate with C APIs. Naturally, we not always want to use every
argument in such functions.

Since we get -Wunused-parameter from -Wall, we have to plumb those
unused arguments in order to suppress compiler warnings at the moment.

However, I don't think that extra work is worth it. We cannot change or
alter prototypes in any way to fix the warning the desired way. Q_UNUSED
and similar macros are not good indicators of whether an argument is
used too, we tend to overlook putting or removing those macros. I've
also noticed that Q_UNUSED are not used to guide us with the removal no
longer needed parameters.

Therefore, I think it's worth adding -Wno-unused-parameter compiler
option to stop the compiler producing warnings about unused parameters.
It changes nothing except that we don't need to put Q_UNUSED anymore,
which can be really cumbersome sometimes. Note that it doesn't affect
unused variables, you'll still get a -Wunused-variable compiler warning
if a variable is unused.
2022-10-31 15:50:37 +00:00

104 lines
2.8 KiB
C++

/*
KWin - the KDE window manager
This file is part of the KDE project.
SPDX-FileCopyrightText: 2012 Martin Gräßlin <mgraesslin@kde.org>
SPDX-License-Identifier: GPL-2.0-or-later
*/
#ifndef KWIN_MOCK_TABBOX_HANDLER_H
#define KWIN_MOCK_TABBOX_HANDLER_H
#include "tabbox/tabboxhandler.h"
namespace KWin
{
class MockTabBoxHandler : public TabBox::TabBoxHandler
{
Q_OBJECT
public:
MockTabBoxHandler(QObject *parent = nullptr);
~MockTabBoxHandler() override;
void activateAndClose() override
{
}
QWeakPointer<TabBox::TabBoxClient> activeClient() const override;
void setActiveClient(const QWeakPointer<TabBox::TabBoxClient> &client);
int activeScreen() const override
{
return 0;
}
QWeakPointer<TabBox::TabBoxClient> clientToAddToList(TabBox::TabBoxClient *client, int desktop) const override;
int currentDesktop() const override
{
return 1;
}
QWeakPointer<TabBox::TabBoxClient> desktopClient() const override
{
return QWeakPointer<TabBox::TabBoxClient>();
}
QString desktopName(int desktop) const override
{
return "desktop 1";
}
QString desktopName(TabBox::TabBoxClient *client) const override
{
return "desktop";
}
void elevateClient(TabBox::TabBoxClient *c, QWindow *tabbox, bool elevate) const override
{
}
void shadeClient(TabBox::TabBoxClient *c, bool b) const override
{
}
virtual void hideOutline()
{
}
QWeakPointer<TabBox::TabBoxClient> nextClientFocusChain(TabBox::TabBoxClient *client) const override;
QWeakPointer<TabBox::TabBoxClient> firstClientFocusChain() const override;
bool isInFocusChain(TabBox::TabBoxClient *client) const override;
int nextDesktopFocusChain(int desktop) const override
{
return 1;
}
int numberOfDesktops() const override
{
return 1;
}
bool isKWinCompositing() const override
{
return false;
}
void raiseClient(TabBox::TabBoxClient *c) const override
{
}
void restack(TabBox::TabBoxClient *c, TabBox::TabBoxClient *under) override
{
}
virtual void showOutline(const QRect &outline)
{
}
TabBox::TabBoxClientList stackingOrder() const override
{
return TabBox::TabBoxClientList();
}
void grabbedKeyEvent(QKeyEvent *event) const override;
void highlightWindows(TabBox::TabBoxClient *window = nullptr, QWindow *controller = nullptr) override
{
}
bool noModifierGrab() const override
{
return false;
}
// mock methods
QWeakPointer<TabBox::TabBoxClient> createMockWindow(const QString &caption);
void closeWindow(TabBox::TabBoxClient *client);
private:
QList<QSharedPointer<TabBox::TabBoxClient>> m_windows;
QWeakPointer<TabBox::TabBoxClient> m_activeClient;
};
} // namespace KWin
#endif