kwin/kcmkwin
David Edmundson 3709996f8a Fix KWin decoration KCM showing correct index at startup
Summary:
The KCM has a context property of the currently set theme index. This is
set before the decorations model is populated, so it is currently always
-1.

This model is populated after the constructor but before
KCModule::load().

KCModule::load is called from KCModule::showEvent so before
QQuickGridView will start doing anything with delegates.

This fixes the problem simply and also avoid parsing the config file
multiple times.

This bug was introduced in 5.9.4:

Someone made a (tested) change to make sure the view scrolled to the
right place on startup.
I then made a (tested) commit fixing the crash on exit
The author then updated his patch to my changes, but now in a way that
didn't work.

Test Plan:
Opened system settings module with a million decorations.
The correct entry was visible and highlighted.

Reviewers: #plasma, graesslin

Reviewed By: #plasma, graesslin

Subscribers: plasma-devel, kwin, #kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D5401
2017-04-13 11:54:39 +01:00
..
kwincompositing SVN_SILENT made messages (.desktop file) - always resolve ours 2016-12-13 05:42:59 +01:00
kwindecoration Fix KWin decoration KCM showing correct index at startup 2017-04-13 11:54:39 +01:00
kwindesktop SVN_SILENT made messages (.desktop file) - always resolve ours 2016-12-13 05:42:59 +01:00
kwinoptions SVN_SILENT made messages (.desktop file) - always resolve ours 2016-12-13 05:42:59 +01:00
kwinrules SVN_SILENT made messages (.desktop file) - always resolve ours 2016-12-13 05:42:59 +01:00
kwinscreenedges SVN_SILENT made messages (.desktop file) - always resolve ours 2016-12-13 05:42:59 +01:00
kwinscripts pedantic fixes 2016-07-16 13:14:44 -04:00
kwintabbox SVN_SILENT made messages (.desktop file) - always resolve ours 2016-12-13 05:42:59 +01:00
CMakeLists.txt Drop build option KWIN_BUILD_SCREENEDGES 2014-11-24 10:48:49 +01:00