Due to being a compositor, kwin has to conform to some certain interfaces. It means a lot of virtual functions and function tables to integrate with C APIs. Naturally, we not always want to use every argument in such functions. Since we get -Wunused-parameter from -Wall, we have to plumb those unused arguments in order to suppress compiler warnings at the moment. However, I don't think that extra work is worth it. We cannot change or alter prototypes in any way to fix the warning the desired way. Q_UNUSED and similar macros are not good indicators of whether an argument is used too, we tend to overlook putting or removing those macros. I've also noticed that Q_UNUSED are not used to guide us with the removal no longer needed parameters. Therefore, I think it's worth adding -Wno-unused-parameter compiler option to stop the compiler producing warnings about unused parameters. It changes nothing except that we don't need to put Q_UNUSED anymore, which can be really cumbersome sometimes. Note that it doesn't affect unused variables, you'll still get a -Wunused-variable compiler warning if a variable is unused.
93 lines
2.8 KiB
C++
93 lines
2.8 KiB
C++
/*
|
|
SPDX-FileCopyrightText: 2020 David Edmundson <davidedmundson@kde.org>
|
|
|
|
SPDX-License-Identifier: LGPL-2.1-only OR LGPL-3.0-only OR LicenseRef-KDE-Accepted-LGPL
|
|
*/
|
|
#include "primaryselectionsource_v1_interface.h"
|
|
#include "clientconnection.h"
|
|
#include "primaryselectiondevicemanager_v1_interface.h"
|
|
#include "utils.h"
|
|
// Qt
|
|
#include <QStringList>
|
|
// Wayland
|
|
#include <qwayland-server-wp-primary-selection-unstable-v1.h>
|
|
// system
|
|
#include <unistd.h>
|
|
|
|
namespace KWaylandServer
|
|
{
|
|
class PrimarySelectionSourceV1InterfacePrivate : public QtWaylandServer::zwp_primary_selection_source_v1
|
|
{
|
|
public:
|
|
PrimarySelectionSourceV1InterfacePrivate(PrimarySelectionSourceV1Interface *q, ::wl_resource *resource);
|
|
|
|
QStringList mimeTypes;
|
|
PrimarySelectionSourceV1Interface *q;
|
|
|
|
protected:
|
|
void zwp_primary_selection_source_v1_destroy_resource(Resource *resource) override;
|
|
void zwp_primary_selection_source_v1_offer(Resource *resource, const QString &mime_type) override;
|
|
void zwp_primary_selection_source_v1_destroy(Resource *resource) override;
|
|
};
|
|
|
|
PrimarySelectionSourceV1InterfacePrivate::PrimarySelectionSourceV1InterfacePrivate(PrimarySelectionSourceV1Interface *_q, ::wl_resource *resource)
|
|
: QtWaylandServer::zwp_primary_selection_source_v1(resource)
|
|
, q(_q)
|
|
{
|
|
}
|
|
|
|
void PrimarySelectionSourceV1InterfacePrivate::zwp_primary_selection_source_v1_destroy_resource(
|
|
QtWaylandServer::zwp_primary_selection_source_v1::Resource *resource)
|
|
{
|
|
Q_EMIT q->aboutToBeDestroyed();
|
|
delete q;
|
|
}
|
|
|
|
void PrimarySelectionSourceV1InterfacePrivate::zwp_primary_selection_source_v1_offer(Resource *, const QString &mimeType)
|
|
{
|
|
mimeTypes << mimeType;
|
|
Q_EMIT q->mimeTypeOffered(mimeType);
|
|
}
|
|
|
|
void PrimarySelectionSourceV1InterfacePrivate::zwp_primary_selection_source_v1_destroy(QtWaylandServer::zwp_primary_selection_source_v1::Resource *resource)
|
|
{
|
|
wl_resource_destroy(resource->handle);
|
|
}
|
|
|
|
PrimarySelectionSourceV1Interface::PrimarySelectionSourceV1Interface(::wl_resource *resource)
|
|
: d(new PrimarySelectionSourceV1InterfacePrivate(this, resource))
|
|
{
|
|
}
|
|
|
|
PrimarySelectionSourceV1Interface::~PrimarySelectionSourceV1Interface() = default;
|
|
|
|
void PrimarySelectionSourceV1Interface::requestData(const QString &mimeType, qint32 fd)
|
|
{
|
|
d->send_send(mimeType, fd);
|
|
close(fd);
|
|
}
|
|
|
|
void PrimarySelectionSourceV1Interface::cancel()
|
|
{
|
|
d->send_cancelled();
|
|
}
|
|
|
|
QStringList PrimarySelectionSourceV1Interface::mimeTypes() const
|
|
{
|
|
return d->mimeTypes;
|
|
}
|
|
|
|
wl_client *PrimarySelectionSourceV1Interface::client() const
|
|
{
|
|
return d->resource()->client();
|
|
}
|
|
|
|
PrimarySelectionSourceV1Interface *PrimarySelectionSourceV1Interface::get(wl_resource *native)
|
|
{
|
|
if (auto sourcePrivate = resource_cast<PrimarySelectionSourceV1InterfacePrivate *>(native)) {
|
|
return sourcePrivate->q;
|
|
}
|
|
return nullptr;
|
|
}
|
|
|
|
}
|