7fffe99328
Due to being a compositor, kwin has to conform to some certain interfaces. It means a lot of virtual functions and function tables to integrate with C APIs. Naturally, we not always want to use every argument in such functions. Since we get -Wunused-parameter from -Wall, we have to plumb those unused arguments in order to suppress compiler warnings at the moment. However, I don't think that extra work is worth it. We cannot change or alter prototypes in any way to fix the warning the desired way. Q_UNUSED and similar macros are not good indicators of whether an argument is used too, we tend to overlook putting or removing those macros. I've also noticed that Q_UNUSED are not used to guide us with the removal no longer needed parameters. Therefore, I think it's worth adding -Wno-unused-parameter compiler option to stop the compiler producing warnings about unused parameters. It changes nothing except that we don't need to put Q_UNUSED anymore, which can be really cumbersome sometimes. Note that it doesn't affect unused variables, you'll still get a -Wunused-variable compiler warning if a variable is unused.
50 lines
1.3 KiB
C++
50 lines
1.3 KiB
C++
/*
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
SPDX-FileCopyrightText: 2019 Roman Gilg <subdiff@gmail.com>
|
|
|
|
SPDX-License-Identifier: GPL-2.0-or-later
|
|
*/
|
|
#include "linux_dmabuf.h"
|
|
|
|
#include "wayland_server.h"
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
LinuxDmaBufV1ClientBuffer::LinuxDmaBufV1ClientBuffer(DmaBufAttributes &&attrs, quint32 flags)
|
|
: KWaylandServer::LinuxDmaBufV1ClientBuffer(std::move(attrs), flags)
|
|
{
|
|
waylandServer()->addLinuxDmabufBuffer(this);
|
|
}
|
|
|
|
LinuxDmaBufV1ClientBuffer::~LinuxDmaBufV1ClientBuffer()
|
|
{
|
|
if (waylandServer()) {
|
|
waylandServer()->removeLinuxDmabufBuffer(this);
|
|
}
|
|
}
|
|
|
|
LinuxDmaBufV1RendererInterface::LinuxDmaBufV1RendererInterface()
|
|
{
|
|
Q_ASSERT(waylandServer());
|
|
waylandServer()->linuxDmabuf()->setRendererInterface(this);
|
|
}
|
|
|
|
LinuxDmaBufV1RendererInterface::~LinuxDmaBufV1RendererInterface()
|
|
{
|
|
waylandServer()->linuxDmabuf()->setRendererInterface(nullptr);
|
|
}
|
|
|
|
KWaylandServer::LinuxDmaBufV1ClientBuffer *LinuxDmaBufV1RendererInterface::importBuffer(DmaBufAttributes &&attrs, quint32 flags)
|
|
{
|
|
return nullptr;
|
|
}
|
|
|
|
void LinuxDmaBufV1RendererInterface::setSupportedFormatsAndModifiers(const QVector<KWaylandServer::LinuxDmaBufV1Feedback::Tranche> &tranches)
|
|
{
|
|
waylandServer()->linuxDmabuf()->setSupportedFormatsWithModifiers(tranches);
|
|
}
|
|
|
|
}
|