65ddd32d1a
Summary: The functionality regarding triggering modifier only shortcuts is moved out of Xkb - where it doesn't belong to - and is turned into an input event spy listening for the changes it is interested in. Previously the state got queried by asking e.g. for the pressed buttons, now it's tracked directly. The X11 side needs a larger change due to that as now pushing the events into Xkb does not trigger modifier only shortcuts any more. Instead the "normal" way through the platform API needs to be used which triggers the processing of filters and spies. The problem here is that our redirections only process events if they are inited and that only happens on Wayland. We cannot call init on them as that would create all the Wayland filters and spies and processing would probably break. As an intermediate solution the spies are now processed and there we know that it won't matter. A future solution would be to remove the init checks completely and just send through both filters and spies and ensure that on X11 only the supported ones are loaded. Closes T5220 Test Plan: Tested on Wayland and X11 Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Maniphest Tasks: T5220 Differential Revision: https://phabricator.kde.org/D4578
99 lines
3.2 KiB
C++
99 lines
3.2 KiB
C++
/********************************************************************
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
Copyright (C) 2016, 2017 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*********************************************************************/
|
|
#include "modifier_only_shortcuts.h"
|
|
#include "input_event.h"
|
|
#include "options.h"
|
|
#include "screenlockerwatcher.h"
|
|
#include "workspace.h"
|
|
|
|
#include <QDBusConnection>
|
|
#include <QDBusMessage>
|
|
#include <QDBusPendingCall>
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
ModifierOnlyShortcuts::ModifierOnlyShortcuts()
|
|
: QObject()
|
|
, InputEventSpy()
|
|
{
|
|
connect(ScreenLockerWatcher::self(), &ScreenLockerWatcher::locked, this, &ModifierOnlyShortcuts::reset);
|
|
}
|
|
|
|
ModifierOnlyShortcuts::~ModifierOnlyShortcuts() = default;
|
|
|
|
void ModifierOnlyShortcuts::keyEvent(KeyEvent *event)
|
|
{
|
|
if (event->isAutoRepeat()) {
|
|
return;
|
|
}
|
|
if (event->type() == QEvent::KeyPress) {
|
|
m_pressCount++;
|
|
if (m_pressCount == 1 &&
|
|
!ScreenLockerWatcher::self()->isLocked() &&
|
|
m_buttonPressCount == 0 &&
|
|
m_cachedMods == Qt::NoModifier) {
|
|
m_modifier = Qt::KeyboardModifier(int(event->modifiersRelevantForGlobalShortcuts()));
|
|
} else {
|
|
m_modifier = Qt::NoModifier;
|
|
}
|
|
} else {
|
|
m_pressCount--;
|
|
if (m_pressCount == 0 &&
|
|
event->modifiersRelevantForGlobalShortcuts() == Qt::NoModifier &&
|
|
!workspace()->globalShortcutsDisabled()) {
|
|
if (m_modifier != Qt::NoModifier) {
|
|
const auto list = options->modifierOnlyDBusShortcut(m_modifier);
|
|
if (list.size() >= 4) {
|
|
auto call = QDBusMessage::createMethodCall(list.at(0), list.at(1), list.at(2), list.at(3));
|
|
QVariantList args;
|
|
for (int i = 4; i < list.size(); ++i) {
|
|
args << list.at(i);
|
|
}
|
|
call.setArguments(args);
|
|
QDBusConnection::sessionBus().asyncCall(call);
|
|
}
|
|
}
|
|
}
|
|
m_modifier = Qt::NoModifier;
|
|
}
|
|
m_cachedMods = event->modifiersRelevantForGlobalShortcuts();
|
|
}
|
|
|
|
void ModifierOnlyShortcuts::pointerEvent(MouseEvent *event)
|
|
{
|
|
if (event->type() == QEvent::MouseMove) {
|
|
return;
|
|
}
|
|
if (event->type() == QEvent::MouseButtonPress) {
|
|
m_buttonPressCount++;
|
|
} else if (event->type() == QEvent::MouseButtonRelease) {
|
|
m_buttonPressCount--;
|
|
}
|
|
reset();
|
|
}
|
|
|
|
void ModifierOnlyShortcuts::wheelEvent(WheelEvent *event)
|
|
{
|
|
Q_UNUSED(event)
|
|
reset();
|
|
}
|
|
|
|
}
|