My KWIN fork where I work on features like per-output virtual desktops
Find a file
Vlad Zagorodniy 456c65fc19 Verify that there is no scene windows when Scene is about to be destroyed
Summary:
When ~Scene is called, it's not guaranteed that backend is still valid
or that there is current opengl context. So, generally speaking,
deleting scene windows in ~Scene is a bad idea.

It's okay not to delete scene windows in ~Scene because current
implementation of Compositor::finish ensures that they don't last longer
than the scene.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D19540
2019-03-05 15:19:19 +02:00
autotests [autotests] Fix race condition in ShellClient::testUnresponsiveWindow 2019-02-28 02:09:33 +00:00
cmake/modules Follow ECM documentation style 2019-02-12 11:56:21 +01:00
colorcorrection Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
data Move icons to data dir 2019-02-06 01:19:54 +02:00
decorations Resurrect show tooltips option 2019-03-05 00:38:55 +02:00
doc [KCMs] move GHNS buttons to the normal location 2018-10-31 07:29:22 -06:00
effects SVN_SILENT made messages (.desktop file) - always resolve ours 2019-02-23 05:48:12 +01:00
helpers Remove X clipboard sync helper and rename its autotest 2019-02-19 12:30:43 +01:00
kcmkwin Resurrect show tooltips option 2019-03-05 00:38:55 +02:00
kconf_update [kconf_update] Use scripted dim screen effect 2018-11-26 16:18:46 +02:00
libinput Fix minor Doxygen issues 2019-01-12 12:31:32 +02:00
libkwineffects [libkwineffects] Make AnimationEffect::AniMap protected 2019-02-26 11:37:44 +02:00
packageplugins SVN_SILENT made messages (.desktop file) - always resolve ours 2019-01-14 05:39:00 +01:00
platformsupport Reload Shm texture when buffer size changes 2019-02-21 23:45:55 +01:00
plugins Discard Deleted before Scene is destroyed 2019-03-04 23:24:42 +02:00
qml fix virtual keyboard on Plasma Mobile 2018-12-10 16:50:06 +01:00
scripting [scripting] Make DBus invokable run method return result after execution 2019-02-22 14:40:15 +00:00
scripts SVN_SILENT made messages (.desktop file) - always resolve ours 2019-02-17 08:30:42 +01:00
tabbox Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
tests Use locked cursor position hint 2018-07-27 17:19:33 +02:00
xwl [wayland] Keep application startup flow inside main_wayland 2019-02-23 12:18:09 +00:00
.arcconfig
.arclint Add .arclint 2018-10-02 19:44:07 +03:00
abstract_client.cpp Fix DesktopGrid drag on X11 2019-01-17 23:43:11 +00:00
abstract_client.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
abstract_opengl_context_attribute_builder.cpp Request a high-priority EGL contexts 2018-03-29 20:34:22 +09:00
abstract_opengl_context_attribute_builder.h Request a high-priority EGL contexts 2018-03-29 20:34:22 +09:00
abstract_output.cpp Add output orientation size helper 2018-11-14 20:05:39 +01:00
abstract_output.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
activation.cpp Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
activities.cpp
activities.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
appmenu.cpp Don't try to open application menu when client doesn't have one 2018-04-23 15:42:02 +02:00
appmenu.h Fix minor EBN issues 2018-08-29 21:02:16 +03:00
atoms.cpp [xwl] text/x-uri converter for selected X url list format targets 2019-02-19 13:17:08 +01:00
atoms.h [xwl] text/x-uri converter for selected X url list format targets 2019-02-19 13:17:08 +01:00
client.cpp Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
client.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
client_machine.cpp
client_machine.h
CMakeLists.txt Split out a dedicated InternalClient class 2019-02-21 18:51:25 +01:00
composite.cpp Discard Deleted before Scene is destroyed 2019-03-04 23:24:42 +02:00
composite.h [wayland] Send correct current time in the frame callback 2019-02-26 12:03:57 +02:00
config-kwin.h.cmake Require libinput and udev 2018-02-04 15:00:42 +01:00
COPYING
cursor.cpp Drop XFixes include in cursor.cpp 2019-01-09 22:29:45 +02:00
cursor.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
dbusinterface.cpp Fix VirtualDesktopManager::createVirtualDesktop 2019-01-21 20:07:55 +02:00
dbusinterface.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
debug_console.cpp i18n: Fix untranslatable table row "Delta" 2018-09-17 13:43:05 +03:00
debug_console.h Require libinput and udev 2018-02-04 15:00:42 +01:00
debug_console.ui fixuifiles 2018-09-18 07:52:44 +02:00
deleted.cpp Move groupTransient and group from Client to AbstractClient as virtual 2019-01-12 07:35:18 +01:00
deleted.h Make whitespace in Deleted consistent 2019-02-06 19:16:18 +02:00
effectloader.cpp
effectloader.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
effects.cpp Switch ThumbnailItem to internal uuid instead of WId 2019-01-27 09:52:15 +01:00
effects.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
egl_context_attribute_builder.cpp Request a high-priority EGL contexts 2018-03-29 20:34:22 +09:00
egl_context_attribute_builder.h [qpa] Use the new OpenGLContextAttributeBuilder to create Qt's OpenGL context 2017-07-17 16:53:37 +02:00
events.cpp Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
fixqopengl.h Fix the build on armhf/aarch64 2018-03-06 09:25:33 +05:30
focuschain.cpp Use explicit Chain type in the focus chain 2018-07-30 11:23:43 +03:00
focuschain.h Use explicit Chain type in the focus chain 2018-07-30 11:23:43 +03:00
geometry.cpp Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
geometrytip.cpp
geometrytip.h
gestures.cpp Fix build with clang and GCC6 2017-03-29 14:45:44 +02:00
gestures.h Fix minor Doxygen issues 2019-01-12 12:31:32 +02:00
globalshortcuts.cpp Don't try to filter null key combinations 2018-04-24 16:35:23 +02:00
globalshortcuts.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
group.cpp Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
group.h
HACKING.md Introduce a new HACKING.md document to replace the previous HACKING 2018-12-17 18:11:59 +01:00
idle_inhibition.cpp Use appropriate sequence algorithms in IdleInhibition 2019-01-11 15:28:28 +02:00
idle_inhibition.h Use appropriate sequence algorithms in IdleInhibition 2019-01-11 15:28:28 +02:00
input.cpp [xwl] Drag and drop between Xwayland and Wayland native clients 2019-02-19 13:09:18 +01:00
input.h [xwl] Drag and drop between Xwayland and Wayland native clients 2019-02-19 13:09:18 +01:00
input_event.cpp Pass SwitchEvent from LibInput through KWin and add to DebugConsole 2018-01-09 19:32:58 +01:00
input_event.h Pass SwitchEvent from LibInput through KWin and add to DebugConsole 2018-01-09 19:32:58 +01:00
input_event_spy.cpp Pass SwitchEvent from LibInput through KWin and add to DebugConsole 2018-01-09 19:32:58 +01:00
input_event_spy.h Pass SwitchEvent from LibInput through KWin and add to DebugConsole 2018-01-09 19:32:58 +01:00
internal_client.cpp Split out a dedicated InternalClient class 2019-02-21 18:51:25 +01:00
internal_client.h Split out a dedicated InternalClient class 2019-02-21 18:51:25 +01:00
keyboard_input.cpp Remove X clipboard sync helper and rename its autotest 2019-02-19 12:30:43 +01:00
keyboard_input.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
keyboard_layout.cpp Fix warning 2018-04-06 18:43:12 +02:00
keyboard_layout.h Introduce support for keyboard layout switching policies 2017-04-22 08:15:25 +02:00
keyboard_layout_switching.cpp Use end() instead of constEnd() for where we compare to an iterator 2017-04-22 20:28:12 +02:00
keyboard_layout_switching.h Add support for keyboard layout switching policy "winclass" 2017-04-22 08:15:59 +02:00
keyboard_repeat.cpp
keyboard_repeat.h
killwindow.cpp
killwindow.h
kwin.kcfg
kwin.notifyrc SVN_SILENT made messages (.desktop file) - always resolve ours 2019-01-16 09:09:19 +01:00
kwinbindings.cpp Expose more default window management shortcuts 2018-03-16 17:18:55 -06:00
KWinDBusInterfaceConfig.cmake.in
layers.cpp [xwl] Support stack optimizing X drag source clients 2019-02-19 13:24:18 +01:00
logind.cpp remove superfluous code 2019-01-27 12:05:22 +05:30
logind.h logind: Add a function that detects the logind seat. 2018-01-05 22:46:39 +01:00
main.cpp [autotests] Use Xwayland class in WaylandTestApplication 2019-02-19 12:18:33 +01:00
main.h [autotests] Use Xwayland class in WaylandTestApplication 2019-02-19 12:18:33 +01:00
main_wayland.cpp [wayland] Keep application startup flow inside main_wayland 2019-02-23 12:18:09 +00:00
main_wayland.h [wayland] Keep application startup flow inside main_wayland 2019-02-23 12:18:09 +00:00
main_x11.cpp Ensure the Compositor does not start during termination 2019-01-12 07:36:55 +01:00
main_x11.h
Mainpage.dox
manage.cpp Re-evaluate the window rules when the window class of a Client changes 2018-11-07 09:33:39 +01:00
Messages.sh Fix untranslatable strings in debug_console.ui shortcutdialog.ui 2018-09-17 11:39:47 +02:00
modifier_only_shortcuts.cpp
modifier_only_shortcuts.h
moving_client_x11_filter.cpp Move X11 movingClient handling into a dedicated X11EventFilter 2017-09-01 16:57:43 +02:00
moving_client_x11_filter.h Move X11 movingClient handling into a dedicated X11EventFilter 2017-09-01 16:57:43 +02:00
netinfo.cpp Revert "Revert "Add "SkipSwitcher" to API"" 2018-05-23 23:33:39 -05:00
netinfo.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
onscreennotification.cpp Drop invalid .moc file inclusion 2018-03-04 16:10:18 +01:00
onscreennotification.h
options.cpp Try all supported Compositor Types of the current Platform 2017-10-19 18:26:33 +02:00
options.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
org.freedesktop.ScreenSaver.xml
org.kde.kappmenu.xml
org.kde.kwin.ColorCorrect.xml [colorcorrection] Night Color - blue light filter at nighttime 2017-12-11 10:58:40 +01:00
org.kde.kwin.Compositing.xml
org.kde.kwin.Effects.xml
org.kde.kwin.OrientationSensor.xml Add DBus interface to OrientationSensor and a persistent configuration 2017-12-26 22:02:47 +01:00
org.kde.KWin.VirtualDesktopManager.xml [wayland] Use the new plasma virtual desktop protocol 2018-11-01 16:35:29 +01:00
org.kde.KWin.xml Add a dbus method getWindowInfo returning same data as queryWindowInfo 2018-12-17 18:12:17 +01:00
orientation_sensor.cpp Add DBus interface to OrientationSensor and a persistent configuration 2017-12-26 22:02:47 +01:00
orientation_sensor.h Add DBus interface to OrientationSensor and a persistent configuration 2017-12-26 22:02:47 +01:00
osd.cpp
osd.h
outline.cpp Move NonComposited Outline into the X11 standalone platform 2017-09-01 17:07:23 +02:00
outline.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
outputscreens.cpp Move output refresh rate getter into AbstractOutput 2018-11-14 20:04:29 +01:00
outputscreens.h Move output refresh rate getter into AbstractOutput 2018-11-14 20:04:29 +01:00
overlaywindow.cpp Move the X11 specific OverlayWindow into the platform/x11 2017-08-12 11:32:29 +02:00
overlaywindow.h Move the X11 specific OverlayWindow into the platform/x11 2017-08-12 11:32:29 +02:00
placement.cpp [wayland] Handle sizes in ShellClient::transientPlacement 2019-02-22 14:08:47 +00:00
placement.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
platform.cpp Remove unused check 2018-10-25 08:05:13 +02:00
platform.h Restrict available supported compositors based on first initialized one 2019-02-22 16:59:08 +01:00
pointer_input.cpp [wayland] Don't use hardcoded move-resize cursor 2018-12-31 12:35:01 +02:00
pointer_input.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
popup_input_filter.cpp Cancel popup if the user clicked window decoration of parent window 2017-04-11 20:22:32 +02:00
popup_input_filter.h Initial support for popup window handling 2017-04-07 16:14:50 +02:00
README.md Add a new markdown README 2018-12-22 08:42:38 +01:00
rootinfo_filter.cpp Create a dedicated X11EventFilter for the events used by RootInfo 2017-09-30 12:57:21 +02:00
rootinfo_filter.h Create a dedicated X11EventFilter for the events used by RootInfo 2017-09-30 12:57:21 +02:00
rules.cpp Port window specific rules dialog to DBus 2018-12-31 07:58:12 +01:00
rules.h Merge branch 'Plasma/5.12' into Plasma/5.13 2018-05-20 15:41:48 +02:00
scene.cpp Verify that there is no scene windows when Scene is about to be destroyed 2019-03-05 15:19:19 +02:00
scene.h Add addToplevel and removeToplevel to Scene 2019-02-14 14:43:11 +02:00
screenedge.cpp Fix minor EBN issues 2018-08-29 21:02:16 +03:00
screenedge.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
screenlockerwatcher.cpp
screenlockerwatcher.h
screens.cpp Load Kwin's internal cursors for the highest resolution of attached monitors 2018-06-23 23:26:54 +01:00
screens.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
settings.kcfgc
shadow.cpp Avoid deleting ourselves midway through updateShadow 2018-12-06 12:55:12 +00:00
shadow.h Fix minor Doxygen issues 2019-01-12 12:31:32 +02:00
shell_client.cpp [wayland] Implement belongsToDesktop check 2019-03-05 00:54:05 +02:00
shell_client.h [wayland] Implement belongsToDesktop check 2019-03-05 00:54:05 +02:00
shortcutdialog.ui
sm.cpp Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
sm.h
tabgroup.cpp Port TabGroup from Client to AbstractClient 2018-05-20 19:50:29 +02:00
tabgroup.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
tabletmodemanager.cpp Remove remaining HAVE_INPUT ifdef sections 2018-02-10 20:36:43 +01:00
tabletmodemanager.h Expose if the tablet mode switch is available 2018-01-25 12:46:38 +01:00
TESTING.md [platform/virtual] Drop support for vgem and rendernode 2019-01-12 07:37:25 +01:00
thumbnailitem.cpp Switch ThumbnailItem to internal uuid instead of WId 2019-01-27 09:52:15 +01:00
thumbnailitem.h Switch ThumbnailItem to internal uuid instead of WId 2019-01-27 09:52:15 +01:00
toplevel.cpp Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
toplevel.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
touch_hide_cursor_spy.cpp Hide mouse cursor when interacting with touch screen 2018-12-13 18:55:46 +01:00
touch_hide_cursor_spy.h Hide mouse cursor when interacting with touch screen 2018-12-13 18:55:46 +01:00
touch_input.cpp Leave decoration on touch up only once 2018-12-13 11:06:08 +01:00
touch_input.h Unset touch targets on no current touch points 2018-12-13 10:59:07 +01:00
udev.cpp [platform/virtual] Drop support for vgem and rendernode 2019-01-12 07:37:25 +01:00
udev.h [platform/virtual] Drop support for vgem and rendernode 2019-01-12 07:37:25 +01:00
unmanaged.cpp [wayland] Move AbstractClient::desktops from QList to QVector 2018-11-07 16:22:59 +00:00
unmanaged.h [wayland] Move AbstractClient::desktops from QList to QVector 2018-11-07 16:22:59 +00:00
useractions.cpp Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
useractions.h [wayland] Use the new plasma virtual desktop protocol 2018-11-01 16:35:29 +01:00
utils.cpp Make it easier to debug the virtualkeyboard 2018-12-10 16:28:13 +05:30
utils.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
virtual_terminal.cpp
virtual_terminal.h
virtualdesktops.cpp Send done event after the number of rows has been changed 2019-01-25 14:07:07 +02:00
virtualdesktops.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
virtualdesktopsdbustypes.cpp [wayland] Use the new plasma virtual desktop protocol 2018-11-01 16:35:29 +01:00
virtualdesktopsdbustypes.h [wayland] Use the new plasma virtual desktop protocol 2018-11-01 16:35:29 +01:00
virtualkeyboard.cpp Make it easier to debug the virtualkeyboard 2018-12-10 16:28:13 +05:30
virtualkeyboard.h Fix minor EBN issues 2018-08-29 21:02:16 +03:00
virtualkeyboard_dbus.cpp Add DBus protocol to virtual keyboard 2017-10-19 17:59:19 +02:00
virtualkeyboard_dbus.h Add DBus protocol to virtual keyboard 2017-10-19 17:59:19 +02:00
was_user_interaction_x11_filter.cpp Create a dedicated X11EventFilter for recognizing first user interaction 2017-08-19 10:14:53 +02:00
was_user_interaction_x11_filter.h Create a dedicated X11EventFilter for recognizing first user interaction 2017-08-19 10:14:53 +02:00
wayland_cursor_theme.cpp Load Kwin's internal cursors for the highest resolution of attached monitors 2018-06-23 23:26:54 +01:00
wayland_cursor_theme.h Set specific edge cursor shape when resizing 2018-06-11 10:05:07 +01:00
wayland_server.cpp Fix tests 2019-02-22 03:00:44 +02:00
wayland_server.h [xwl] Drag and drop between Xwayland and Wayland native clients 2019-02-19 13:09:18 +01:00
window_property_notify_x11_filter.cpp Clean up includes 2018-08-31 22:58:11 +03:00
window_property_notify_x11_filter.h Add a dedicated X11EventFilter for forwarding property events to the effect system 2017-09-25 20:36:45 +02:00
workspace.cpp Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
workspace.h [xwl] Support stack optimizing X drag source clients 2019-02-19 13:24:18 +01:00
x11eventfilter.cpp
x11eventfilter.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
xcbutils.cpp
xcbutils.h Overhaul doxygen comments 2019-02-12 19:29:33 +02:00
xkb.cpp Support enabling numlock on startup 2018-11-01 17:49:58 +01:00
xkb.h Support enabling numlock on startup 2018-11-01 17:49:58 +01:00
xkb_qt_mapping.h Support mapping QKeyEvent to xkb_keysym_t 2017-09-19 19:09:17 +02:00

KWin

KWin is an easy to use, but flexible, composited Window Manager for Xorg windowing systems (Wayland, X11) on Linux. Its primary usage is in conjunction with a Desktop Shell (e.g. KDE Plasma Desktop). KWin is designed to go out of the way; users should not notice that they use a window manager at all. Nevertheless KWin provides a steep learning curve for advanced features, which are available, if they do not conflict with the primary mission. KWin does not have a dedicated targeted user group, but follows the targeted user group of the Desktop Shell using KWin as it's window manager.

KWin is not...

  • a standalone window manager (c.f. openbox, i3) and does not provide any functionality belonging to a Desktop Shell.
  • a replacement for window managers designed for use with a specific Desktop Shell (e.g. GNOME Shell)
  • a minimalistic window manager
  • designed for use without compositing or for X11 network transparency, though both are possible.

Contacting KWin development team

Support

Application Developer

If you are an application developer having questions regarding windowing systems (either X11 or Wayland) please do not hesitate to contact us. Preferable through our mailing list. Ideally subscribe to the mailing list, so that your mail doesn't get stuck in the moderation queue.

End user

Please contact the support channels of your Linux distribution for user support. The KWin development team does not provide end user support.

Reporting bugs

Please use KDE's bugtracker and report for product KWin.

Developing on KWin

Please refer to hacking documentation for how to build and start KWin. Further information about KWin's test suite can be found in TESTING.md.

Guidelines for new features

A new Feature can only be added to KWin if:

  • it does not violate the primary missions as stated at the start of this document
  • it does not introduce instabilities
  • it is maintained, that is bugs are fixed in a timely manner (second next minor release) if it is not a corner case.
  • it works together with all existing features
  • it supports both single and multi screen (xrandr)
  • it adds a significant advantage
  • it is feature complete, that is supports at least all useful features from competitive implementations
  • it is not a special case for a small user group
  • it does not increase code complexity significantly
  • it does not affect KWin's license (GPLv2+)

All new added features are under probation, that is if any of the non-functional requirements as listed above do not hold true in the next two feature releases, the added feature will be removed again.

The same non functional requirements hold true for any kind of plugins (effects, scripts, etc.). It is suggested to use scripted plugins and distribute them separately.