kwin/src/wayland/dpms_interface.cpp
Vlad Zahorodnii 7fffe99328 build: Add -Wno-unused-parameter compiler option
Due to being a compositor, kwin has to conform to some certain
interfaces. It means a lot of virtual functions and function tables to
integrate with C APIs. Naturally, we not always want to use every
argument in such functions.

Since we get -Wunused-parameter from -Wall, we have to plumb those
unused arguments in order to suppress compiler warnings at the moment.

However, I don't think that extra work is worth it. We cannot change or
alter prototypes in any way to fix the warning the desired way. Q_UNUSED
and similar macros are not good indicators of whether an argument is
used too, we tend to overlook putting or removing those macros. I've
also noticed that Q_UNUSED are not used to guide us with the removal no
longer needed parameters.

Therefore, I think it's worth adding -Wno-unused-parameter compiler
option to stop the compiler producing warnings about unused parameters.
It changes nothing except that we don't need to put Q_UNUSED anymore,
which can be really cumbersome sometimes. Note that it doesn't affect
unused variables, you'll still get a -Wunused-variable compiler warning
if a variable is unused.
2022-10-31 15:50:37 +00:00

169 lines
4.2 KiB
C++

/*
SPDX-FileCopyrightText: 2015 Martin Gräßlin <mgraesslin@kde.org>
SPDX-License-Identifier: LGPL-2.1-only OR LGPL-3.0-only OR LicenseRef-KDE-Accepted-LGPL
*/
#include "dpms_interface.h"
#include "display.h"
#include "output_interface.h"
#include <QPointer>
#include <qwayland-server-dpms.h>
using namespace KWin;
namespace KWaylandServer
{
static const quint32 s_version = 1;
class DpmsManagerInterfacePrivate : public QtWaylandServer::org_kde_kwin_dpms_manager
{
public:
DpmsManagerInterfacePrivate(Display *d);
protected:
void org_kde_kwin_dpms_manager_get(Resource *resource, uint32_t id, wl_resource *output) override;
};
class DpmsInterface : public QObject, QtWaylandServer::org_kde_kwin_dpms
{
Q_OBJECT
public:
explicit DpmsInterface(OutputInterface *output, wl_resource *resource);
void sendSupported();
void sendMode();
void sendDone();
QPointer<OutputInterface> m_output;
protected:
void org_kde_kwin_dpms_destroy_resource(Resource *resource) override;
void org_kde_kwin_dpms_set(Resource *resource, uint32_t mode) override;
void org_kde_kwin_dpms_release(Resource *resource) override;
};
DpmsManagerInterfacePrivate::DpmsManagerInterfacePrivate(Display *display)
: QtWaylandServer::org_kde_kwin_dpms_manager(*display, s_version)
{
}
void DpmsManagerInterfacePrivate::org_kde_kwin_dpms_manager_get(Resource *resource, uint32_t id, wl_resource *output)
{
OutputInterface *o = OutputInterface::get(output);
wl_resource *dpms_resource = wl_resource_create(resource->client(), &org_kde_kwin_dpms_interface, resource->version(), id);
if (!dpms_resource) {
wl_client_post_no_memory(resource->client());
return;
}
new DpmsInterface(o, dpms_resource);
}
DpmsManagerInterface::DpmsManagerInterface(Display *display, QObject *parent)
: QObject(parent)
, d(new DpmsManagerInterfacePrivate(display))
{
}
DpmsManagerInterface::~DpmsManagerInterface() = default;
DpmsInterface::DpmsInterface(OutputInterface *output, wl_resource *resource)
: QObject()
, QtWaylandServer::org_kde_kwin_dpms(resource)
, m_output(output)
{
if (!m_output || m_output->isRemoved()) {
return;
}
sendSupported();
sendMode();
sendDone();
connect(m_output->handle(), &Output::capabilitiesChanged, this, [this]() {
sendSupported();
sendDone();
});
connect(m_output->handle(), &Output::dpmsModeChanged, this, [this]() {
sendMode();
sendDone();
});
}
void DpmsInterface::org_kde_kwin_dpms_release(Resource *resource)
{
wl_resource_destroy(resource->handle);
}
void DpmsInterface::org_kde_kwin_dpms_destroy_resource(Resource *resource)
{
delete this;
}
void DpmsInterface::org_kde_kwin_dpms_set(Resource *resource, uint32_t mode)
{
if (!m_output || m_output->isRemoved()) {
return;
}
Output::DpmsMode dpmsMode;
switch (mode) {
case ORG_KDE_KWIN_DPMS_MODE_ON:
dpmsMode = Output::DpmsMode::On;
break;
case ORG_KDE_KWIN_DPMS_MODE_STANDBY:
dpmsMode = Output::DpmsMode::Standby;
break;
case ORG_KDE_KWIN_DPMS_MODE_SUSPEND:
dpmsMode = Output::DpmsMode::Suspend;
break;
case ORG_KDE_KWIN_DPMS_MODE_OFF:
dpmsMode = Output::DpmsMode::Off;
break;
default:
return;
}
m_output->handle()->setDpmsMode(dpmsMode);
}
void DpmsInterface::sendSupported()
{
send_supported(m_output->handle()->capabilities() & Output::Capability::Dpms ? 1 : 0);
}
void DpmsInterface::sendMode()
{
const auto mode = m_output->handle()->dpmsMode();
org_kde_kwin_dpms_mode wlMode;
switch (mode) {
case KWin::Output::DpmsMode::On:
wlMode = ORG_KDE_KWIN_DPMS_MODE_ON;
break;
case KWin::Output::DpmsMode::Standby:
wlMode = ORG_KDE_KWIN_DPMS_MODE_STANDBY;
break;
case KWin::Output::DpmsMode::Suspend:
wlMode = ORG_KDE_KWIN_DPMS_MODE_SUSPEND;
break;
case KWin::Output::DpmsMode::Off:
wlMode = ORG_KDE_KWIN_DPMS_MODE_OFF;
break;
default:
Q_UNREACHABLE();
}
send_mode(wlMode);
}
void DpmsInterface::sendDone()
{
send_done();
}
}
#include "dpms_interface.moc"