bc0a9cb53a
Instead of passing the macro based Predicate to findClient it now
expects a function which can be passed to std::find_if.
Existing code like:
xcb_window_t window; // our test window
Client *c = findClient(WindowMatchPredicated(window));
becomes:
Client *c = findClient([window](const Client *c) {
return c->window() == window;
});
The advantage is that it is way more flexible and has the logic what
to check for directly with the code and not hidden in the macro
definition.
In addition there is a simplified overload for the very common case of
matching a window id against one of Client's windows. This overloaded
method takes a Predicate and the window id.
Above example becomes:
Client *c = findClient(Predicate::WindowMatch, w);
Existing code is migrated to use the simplified method taking
MatchPredicate and window id. The very few cases where a more complex
condition is tested the lambda function is used. As these are very
local tests only used in one function it's not worthwhile to add further
overloads to the findClient method in Workspace.
With this change all the Predicate macro definitions are removed from
utils.h as they are now completely unused.
REVIEW: 116916
83 lines
2.8 KiB
C++
83 lines
2.8 KiB
C++
/********************************************************************
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
Copyright (c) 2011 Lionel Chauvin <megabigbug@yahoo.fr>
|
|
Copyright (c) 2011,2012 Cédric Bellegarde <gnumdk@gmail.com>
|
|
Copyright (C) 2013 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*********************************************************************/
|
|
#include "appmenu.h"
|
|
#include "client.h"
|
|
#include "workspace.h"
|
|
#include <appmenu_interface.h>
|
|
|
|
namespace KWin {
|
|
|
|
KWIN_SINGLETON_FACTORY(ApplicationMenu)
|
|
|
|
ApplicationMenu::ApplicationMenu(QObject *parent)
|
|
: QObject(parent)
|
|
, m_appmenuInterface(new OrgKdeKappmenuInterface(QStringLiteral("org.kde.kappmenu"), QStringLiteral("/KAppMenu"), QDBusConnection::sessionBus(), this))
|
|
{
|
|
connect(m_appmenuInterface, &OrgKdeKappmenuInterface::showRequest, this, &ApplicationMenu::slotShowRequest);
|
|
connect(m_appmenuInterface, &OrgKdeKappmenuInterface::menuAvailable, this, &ApplicationMenu::slotMenuAvailable);
|
|
connect(m_appmenuInterface, &OrgKdeKappmenuInterface::menuHidden, this, &ApplicationMenu::slotMenuHidden);
|
|
connect(m_appmenuInterface, &OrgKdeKappmenuInterface::clearMenus, this, &ApplicationMenu::slotClearMenus);
|
|
}
|
|
|
|
ApplicationMenu::~ApplicationMenu()
|
|
{
|
|
s_self = NULL;
|
|
}
|
|
|
|
bool ApplicationMenu::hasMenu(xcb_window_t window)
|
|
{
|
|
return m_windowsMenu.removeOne(window);
|
|
}
|
|
|
|
void ApplicationMenu::slotShowRequest(qulonglong wid)
|
|
{
|
|
if (Client *c = Workspace::self()->findClient(Predicate::WindowMatch, wid))
|
|
c->emitShowRequest();
|
|
}
|
|
|
|
void ApplicationMenu::slotMenuAvailable(qulonglong wid)
|
|
{
|
|
if (Client *c = Workspace::self()->findClient(Predicate::WindowMatch, wid))
|
|
c->setAppMenuAvailable();
|
|
else
|
|
m_windowsMenu.append(wid);
|
|
}
|
|
|
|
void ApplicationMenu::slotMenuHidden(qulonglong wid)
|
|
{
|
|
if (Client *c = Workspace::self()->findClient(Predicate::WindowMatch, wid))
|
|
c->emitMenuHidden();
|
|
}
|
|
|
|
void ApplicationMenu::slotClearMenus()
|
|
{
|
|
foreach (Client *c, Workspace::self()->clientList()) {
|
|
c->setAppMenuUnavailable();
|
|
}
|
|
}
|
|
|
|
void ApplicationMenu::showApplicationMenu(const QPoint &p, const xcb_window_t id)
|
|
{
|
|
m_appmenuInterface->showMenu(p.x(), p.y(), id);
|
|
}
|
|
|
|
} // namespace
|