4e9456a857
Summary: There is a regression in WindowBasedEdge::soStopApproaching. Due to only operate when the edge activates for pointer it is possible that the cursor polling stays active. Explaining the situation: 1. Activate switch desktop when moving window 2. Start moving a window 3. Move mouse into the approach geometry -> doStartApproaching activates as we are moving a window 4. stop moving window -> doStopApproaching early exits as the position does not activate for pointer any more - we are not moving a window -> cursor polling is still connected and whenever mouse enters edge approaching is started The analysis shows that the check whether activates for pointer is wrong in the case of stop approaching. If the edge started to approach, we also need to stop approaching. This change addresses the problem by turning the check into whether the connection for cursor position update is set. This is the third bug fix to the X11 screen edge handling after introducing touch screen edges. This needs more manual testing by everybody in the Plasma team who is still using X11. BUG: 381849 FIXED-IN: 5.10.4 Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6467 |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| edge.cpp | ||
| edge.h | ||
| glxbackend.cpp | ||
| glxbackend.h | ||
| logging.cpp | ||
| logging.h | ||
| screens_xrandr.cpp | ||
| screens_xrandr.h | ||
| windowselector.cpp | ||
| windowselector.h | ||
| x11.json | ||
| x11_platform.cpp | ||
| x11_platform.h | ||
| x11cursor.cpp | ||
| x11cursor.h | ||
| xinputintegration.cpp | ||
| xinputintegration.h | ||