548978bfe1
Summary: Building upon the generic X Selection support this patch establishes another selection class representing the XDND selection and provides interfaces to communicate drags originating from Xwayland windows to the Wayland server KWin and drags originating from Wayland native drags to Xwayland. For Wayland native drags KWin will claim the XDND selection as owner and will simply translate all relevant events to the XDND protocol and receive alike messages by X clients. When an X client claims the XDND selection KWin is notified via the X protocol and it decides if it allows the X drag to transcend into the Wayland protocol. If this is the case the mouse position is tracked and on entering a Wayland native window a proxy X Window is mapped to the top of the window stack. This proxy window acts as a drag destination for the drag origin window and again X messages will be translated into respective Wayland protocol calls. If the cursor leaves the Wayland window geometry before a drop is registered, the proxy window is unmapped, what triggers a subsequent drag leave event. In both directions the necessary core integration is minimal. There is a single call to be done in the drag and drop event filter through the Xwayland interface class. From my tests this patch facilitates drags between any Qt/KDE apps. What needs extra care are the browsers, which use target formats, that are not directly compatible with the Wayland protocol's MIME representation. For Chromium an additional integration step must be done in order to provide it with a net window stack containing the proxy window. Test Plan: Manually. Auto tests planned. Reviewers: #kwin Subscribers: zzag, kwin, alexde Tags: #kwin Maniphest Tasks: T4611 Differential Revision: https://phabricator.kde.org/D15627
227 lines
7.4 KiB
C++
227 lines
7.4 KiB
C++
/********************************************************************
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
Copyright 2019 Roman Gilg <subdiff@gmail.com>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*********************************************************************/
|
|
#include "dnd.h"
|
|
|
|
#include "databridge.h"
|
|
#include "selection_source.h"
|
|
#include "drag_wl.h"
|
|
#include "drag_x.h"
|
|
|
|
#include "atoms.h"
|
|
#include "wayland_server.h"
|
|
#include "workspace.h"
|
|
#include "xwayland.h"
|
|
#include "abstract_client.h"
|
|
|
|
#include <KWayland/Client/compositor.h>
|
|
#include <KWayland/Client/surface.h>
|
|
|
|
#include <KWayland/Server/seat_interface.h>
|
|
#include <KWayland/Server/compositor_interface.h>
|
|
|
|
#include <QMouseEvent>
|
|
|
|
#include <xcb/xcb.h>
|
|
|
|
namespace KWin
|
|
{
|
|
namespace Xwl
|
|
{
|
|
|
|
// version of DnD support in X
|
|
const static uint32_t s_version = 5;
|
|
uint32_t Dnd::version()
|
|
{
|
|
return s_version;
|
|
}
|
|
|
|
Dnd::Dnd(xcb_atom_t atom, QObject *parent)
|
|
: Selection(atom, parent)
|
|
{
|
|
auto *xcbConn = kwinApp()->x11Connection();
|
|
|
|
const uint32_t dndValues[] = { XCB_EVENT_MASK_SUBSTRUCTURE_NOTIFY |
|
|
XCB_EVENT_MASK_PROPERTY_CHANGE };
|
|
xcb_create_window(xcbConn,
|
|
XCB_COPY_FROM_PARENT,
|
|
window(),
|
|
kwinApp()->x11RootWindow(),
|
|
0, 0,
|
|
8192, 8192, // TODO: get current screen size and connect to changes
|
|
0,
|
|
XCB_WINDOW_CLASS_INPUT_OUTPUT,
|
|
Xwayland::self()->xcbScreen()->root_visual,
|
|
XCB_CW_EVENT_MASK,
|
|
dndValues);
|
|
registerXfixes();
|
|
|
|
xcb_change_property(xcbConn,
|
|
XCB_PROP_MODE_REPLACE,
|
|
window(),
|
|
atoms->xdnd_aware,
|
|
XCB_ATOM_ATOM,
|
|
32, 1, &s_version);
|
|
xcb_flush(xcbConn);
|
|
|
|
connect(waylandServer()->seat(), &KWayland::Server::SeatInterface::dragStarted, this, &Dnd::startDrag);
|
|
connect(waylandServer()->seat(), &KWayland::Server::SeatInterface::dragEnded, this, &Dnd::endDrag);
|
|
|
|
const auto *comp = waylandServer()->compositor();
|
|
m_surface = waylandServer()->internalCompositor()->createSurface(this);
|
|
m_surface->setInputRegion(nullptr);
|
|
m_surface->commit(KWayland::Client::Surface::CommitFlag::None);
|
|
auto *dc = new QMetaObject::Connection();
|
|
*dc = connect(comp, &KWayland::Server::CompositorInterface::surfaceCreated, this,
|
|
[this, dc](KWayland::Server::SurfaceInterface *si) {
|
|
// TODO: how to make sure that it is the iface of m_surface?
|
|
if (m_surfaceIface || si->client() != waylandServer()->internalConnection()) {
|
|
return;
|
|
}
|
|
QObject::disconnect(*dc);
|
|
delete dc;
|
|
m_surfaceIface = si;
|
|
connect(workspace(), &Workspace::clientActivated, this,
|
|
[this](AbstractClient *ac) {
|
|
if (!ac || !ac->inherits("KWin::Client")) {
|
|
return;
|
|
}
|
|
auto *surface = ac->surface();
|
|
if (surface) {
|
|
surface->setDataProxy(m_surfaceIface);
|
|
} else {
|
|
auto *dc = new QMetaObject::Connection();
|
|
*dc = connect(ac, &AbstractClient::surfaceChanged, this, [this, ac, dc] {
|
|
if (auto *surface = ac->surface()) {
|
|
surface->setDataProxy(m_surfaceIface);
|
|
QObject::disconnect(*dc);
|
|
delete dc;
|
|
}
|
|
}
|
|
);
|
|
}
|
|
});
|
|
}
|
|
);
|
|
waylandServer()->dispatch();
|
|
}
|
|
|
|
void Dnd::doHandleXfixesNotify(xcb_xfixes_selection_notify_event_t *event)
|
|
{
|
|
if (qobject_cast<XToWlDrag*>(m_currentDrag)) {
|
|
// X drag is in progress, rogue X client took over the selection.
|
|
return;
|
|
}
|
|
if (m_currentDrag) {
|
|
// Wl drag is in progress - don't overwrite by rogue X client,
|
|
// get it back instead!
|
|
ownSelection(true);
|
|
return;
|
|
}
|
|
createX11Source(NULL);
|
|
const auto *seat = waylandServer()->seat();
|
|
auto *originSurface = seat->focusedPointerSurface();
|
|
if (!originSurface) {
|
|
return;
|
|
}
|
|
if (originSurface->client() != waylandServer()->xWaylandConnection()) {
|
|
// focused surface client is not Xwayland - do not allow drag to start
|
|
// TODO: can we make this stronger (window id comparision)?
|
|
return;
|
|
}
|
|
if (!seat->isPointerButtonPressed(Qt::LeftButton)) {
|
|
// we only allow drags to be started on (left) pointer button being
|
|
// pressed for now
|
|
return;
|
|
}
|
|
createX11Source(event);
|
|
auto *xSrc = x11Source();
|
|
if (!xSrc) {
|
|
return;
|
|
}
|
|
DataBridge::self()->dataDeviceIface()->updateProxy(originSurface);
|
|
m_currentDrag = new XToWlDrag(xSrc);
|
|
}
|
|
|
|
void Dnd::x11OffersChanged(const QVector<QString> &added, const QVector<QString> &removed)
|
|
{
|
|
Q_UNUSED(added);
|
|
Q_UNUSED(removed);
|
|
// TODO: handled internally
|
|
}
|
|
|
|
bool Dnd::handleClientMessage(xcb_client_message_event_t *event)
|
|
{
|
|
for (auto *drag : m_oldDrags) {
|
|
if (drag->handleClientMessage(event)) {
|
|
return true;
|
|
}
|
|
}
|
|
if (m_currentDrag && m_currentDrag->handleClientMessage(event)) {
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
DragEventReply Dnd::dragMoveFilter(Toplevel *target, QPoint pos)
|
|
{
|
|
// this filter only is used when a drag is in process
|
|
Q_ASSERT(m_currentDrag);
|
|
return m_currentDrag->moveFilter(target, pos);
|
|
}
|
|
|
|
void Dnd::startDrag()
|
|
{
|
|
auto *ddi = waylandServer()->seat()->dragSource();
|
|
if (ddi == DataBridge::self()->dataDeviceIface()) {
|
|
// X to Wl drag, started by us, is in progress
|
|
Q_ASSERT(m_currentDrag);
|
|
return;
|
|
}
|
|
// there can only ever be one Wl native drag at the same time
|
|
Q_ASSERT(!m_currentDrag);
|
|
|
|
// new Wl to X drag, init drag and Wl source
|
|
m_currentDrag = new WlToXDrag();
|
|
auto *wls = new WlSource(this, ddi);
|
|
wls->setDataSourceIface(ddi->dragSource());
|
|
setWlSource(wls);
|
|
ownSelection(true);
|
|
}
|
|
|
|
void Dnd::endDrag()
|
|
{
|
|
Q_ASSERT(m_currentDrag);
|
|
if (m_currentDrag->end()) {
|
|
delete m_currentDrag;
|
|
} else {
|
|
connect(m_currentDrag, &Drag::finish, this, &Dnd::clearOldDrag);
|
|
m_oldDrags << m_currentDrag;
|
|
}
|
|
m_currentDrag = nullptr;
|
|
}
|
|
|
|
void Dnd::clearOldDrag(Drag *drag)
|
|
{
|
|
m_oldDrags.removeOne(drag);
|
|
delete drag;
|
|
}
|
|
|
|
}
|
|
}
|