kwin/src/backends/libinput/context.cpp
Vlad Zahorodnii 7fffe99328 build: Add -Wno-unused-parameter compiler option
Due to being a compositor, kwin has to conform to some certain
interfaces. It means a lot of virtual functions and function tables to
integrate with C APIs. Naturally, we not always want to use every
argument in such functions.

Since we get -Wunused-parameter from -Wall, we have to plumb those
unused arguments in order to suppress compiler warnings at the moment.

However, I don't think that extra work is worth it. We cannot change or
alter prototypes in any way to fix the warning the desired way. Q_UNUSED
and similar macros are not good indicators of whether an argument is
used too, we tend to overlook putting or removing those macros. I've
also noticed that Q_UNUSED are not used to guide us with the removal no
longer needed parameters.

Therefore, I think it's worth adding -Wno-unused-parameter compiler
option to stop the compiler producing warnings about unused parameters.
It changes nothing except that we don't need to put Q_UNUSED anymore,
which can be really cumbersome sometimes. Note that it doesn't affect
unused variables, you'll still get a -Wunused-variable compiler warning
if a variable is unused.
2022-10-31 15:50:37 +00:00

177 lines
3.5 KiB
C++

/*
KWin - the KDE window manager
This file is part of the KDE project.
SPDX-FileCopyrightText: 2014 Martin Gräßlin <mgraesslin@kde.org>
SPDX-License-Identifier: GPL-2.0-or-later
*/
#include "context.h"
#include "events.h"
#include "libinput_logging.h"
#include "core/session.h"
#include "utils/udev.h"
#include <fcntl.h>
#include <unistd.h>
#include <cerrno>
namespace KWin
{
namespace LibInput
{
static void libinputLogHandler(libinput *libinput, libinput_log_priority priority, const char *format, va_list args)
{
char buf[1024];
if (std::vsnprintf(buf, 1023, format, args) <= 0) {
return;
}
switch (priority) {
case LIBINPUT_LOG_PRIORITY_DEBUG:
qCDebug(KWIN_LIBINPUT) << "Libinput:" << buf;
break;
case LIBINPUT_LOG_PRIORITY_INFO:
qCInfo(KWIN_LIBINPUT) << "Libinput:" << buf;
break;
case LIBINPUT_LOG_PRIORITY_ERROR:
default:
qCCritical(KWIN_LIBINPUT) << "Libinput:" << buf;
break;
}
}
Context::Context(Session *session, std::unique_ptr<Udev> &&udev)
: m_session(session)
, m_libinput(libinput_udev_create_context(&Context::s_interface, this, *udev.get()))
, m_suspended(false)
, m_udev(std::move(udev))
{
libinput_log_set_priority(m_libinput, LIBINPUT_LOG_PRIORITY_DEBUG);
libinput_log_set_handler(m_libinput, &libinputLogHandler);
}
Context::~Context()
{
if (m_libinput) {
libinput_unref(m_libinput);
}
}
bool Context::initialize()
{
if (!isValid()) {
return false;
}
return libinput_udev_assign_seat(m_libinput, m_session->seat().toUtf8().constData()) == 0;
}
Session *Context::session() const
{
return m_session;
}
int Context::fileDescriptor()
{
if (!isValid()) {
return -1;
}
return libinput_get_fd(m_libinput);
}
void Context::dispatch()
{
libinput_dispatch(m_libinput);
}
const struct libinput_interface Context::s_interface = {
Context::openRestrictedCallback,
Context::closeRestrictedCallBack,
};
int Context::openRestrictedCallback(const char *path, int flags, void *user_data)
{
return ((Context *)user_data)->openRestricted(path, flags);
}
void Context::closeRestrictedCallBack(int fd, void *user_data)
{
((Context *)user_data)->closeRestricted(fd);
}
int Context::openRestricted(const char *path, int flags)
{
int fd = m_session->openRestricted(path);
if (fd < 0) {
// failed
return fd;
}
// adjust flags - based on Weston (logind-util.c)
int fl = fcntl(fd, F_GETFL);
auto errorHandling = [fd, this]() {
close(fd);
closeRestricted(fd);
};
if (fl < 0) {
errorHandling();
return -1;
}
if (flags & O_NONBLOCK) {
fl |= O_NONBLOCK;
}
if (fcntl(fd, F_SETFL, fl) < 0) {
errorHandling();
return -1;
}
fl = fcntl(fd, F_GETFD);
if (fl < 0) {
errorHandling();
return -1;
}
if (!(flags & O_CLOEXEC)) {
fl &= ~FD_CLOEXEC;
}
if (fcntl(fd, F_SETFD, fl) < 0) {
errorHandling();
return -1;
}
return fd;
}
void Context::closeRestricted(int fd)
{
m_session->closeRestricted(fd);
}
std::unique_ptr<Event> Context::event()
{
return Event::create(libinput_get_event(m_libinput));
}
void Context::suspend()
{
if (m_suspended) {
return;
}
libinput_suspend(m_libinput);
m_suspended = true;
}
void Context::resume()
{
if (!m_suspended) {
return;
}
libinput_resume(m_libinput);
m_suspended = false;
}
}
}