d2bbd2a124
Summary: Any call made to a virtual method in constructor/destructor of a base class won't go to a derived class because the base class may access uninitialized or destroyed resources. For example, let's consider the following two classes class Base { public: Base() { foo()->bar(); } virtual ~Base() { foo()->bar(); } virtual Foo* foo() const { return nullptr; } }; class Derived : public Base { public: Derived() : mFoo(new Foo) {} ~Derived() override { delete mFoo; } Foo* foo() const override { return mFoo; } private: Foo* mFoo; }; When an instance of Derived class is created, constructors will run in the following order: Base() Derived() It's not safe to dispatch foo() method call to Derived class because constructor of Derived hasn't initialized yet mFoo. Same story with destructors, they'll run in the following order: ~Derived() ~Base() It's not safe to dispatch foo() method call in the destructor of Base class to Derived class because mFoo was deleted. So, what does that weird C++ behavior has something to do with KWin? Well, recently Compositor class was split into two classes - WaylandCompositor, and X11Compositor. Some functionality from X11 doesn't make sense on Wayland. Therefore methods that implement that stuff were "purified," i.e. they became pure virtual methods. Unfortunately, when Compositor tears down it may call pure virtual methods on itself. Given that those calls cannot be dispatched to X11Compositor or WaylandCompositor, the only choice that C++ runtime has is to throw an exception. The fix for this very delicate problem is very simple - do not call virtual methods from constructors and the destructor. Avoid doing that if you can! This change moves Compositor::updateClientCompositeBlocking to X11Compositor so it longer has to be a virtual method. Also, it kind of doesn't make sense to keep it in base Compositor class because compositing can be blocked only on X11. BUG: 411049 Test Plan: KWin no longer crashes when running kwin_x11 --replace command. Reviewers: #kwin, romangg Reviewed By: #kwin, romangg Subscribers: anthonyfieroni, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23098
281 lines
7.5 KiB
C++
281 lines
7.5 KiB
C++
/********************************************************************
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
Copyright (C) 2011 Arthur Arlt <a.arlt@stud.uni-heidelberg.de>
|
|
Copyright (C) 2012 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*********************************************************************/
|
|
#pragma once
|
|
|
|
#include <kwinglobals.h>
|
|
|
|
#include <QObject>
|
|
#include <QElapsedTimer>
|
|
#include <QTimer>
|
|
#include <QBasicTimer>
|
|
#include <QRegion>
|
|
|
|
namespace KWin
|
|
{
|
|
class Client;
|
|
class CompositorSelectionOwner;
|
|
class Scene;
|
|
|
|
class KWIN_EXPORT Compositor : public QObject
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
enum class State {
|
|
On = 0,
|
|
Off,
|
|
Starting,
|
|
Stopping
|
|
};
|
|
|
|
~Compositor() override;
|
|
static Compositor *self();
|
|
|
|
// when adding repaints caused by a window, you probably want to use
|
|
// either Toplevel::addRepaint() or Toplevel::addWorkspaceRepaint()
|
|
void addRepaint(const QRect& r);
|
|
void addRepaint(const QRegion& r);
|
|
void addRepaint(int x, int y, int w, int h);
|
|
void addRepaintFull();
|
|
|
|
/**
|
|
* Schedules a new repaint if no repaint is currently scheduled.
|
|
*/
|
|
void scheduleRepaint();
|
|
|
|
/**
|
|
* Notifies the compositor that SwapBuffers() is about to be called.
|
|
* Rendering of the next frame will be deferred until bufferSwapComplete()
|
|
* is called.
|
|
*/
|
|
void aboutToSwapBuffers();
|
|
|
|
/**
|
|
* Notifies the compositor that a pending buffer swap has completed.
|
|
*/
|
|
void bufferSwapComplete();
|
|
|
|
/**
|
|
* Toggles compositing, that is if the Compositor is suspended it will be resumed
|
|
* and if the Compositor is active it will be suspended.
|
|
* Invoked by keybinding (shortcut default: Shift + Alt + F12).
|
|
*/
|
|
virtual void toggleCompositing() = 0;
|
|
|
|
/**
|
|
* Re-initializes the Compositor completely.
|
|
* Connected to the D-Bus signal org.kde.KWin /KWin reinitCompositing
|
|
*/
|
|
virtual void reinitialize();
|
|
|
|
/**
|
|
* Whether the Compositor is active. That is a Scene is present and the Compositor is
|
|
* not shutting down itself.
|
|
*/
|
|
bool isActive();
|
|
virtual int refreshRate() const = 0;
|
|
|
|
bool hasScene() const {
|
|
return m_scene != NULL;
|
|
}
|
|
Scene *scene() const {
|
|
return m_scene;
|
|
}
|
|
|
|
/**
|
|
* Checks whether @p w is the Scene's overlay window.
|
|
*/
|
|
virtual bool checkForOverlayWindow(WId w) const = 0;
|
|
|
|
/**
|
|
* @brief Static check to test whether the Compositor is available and active.
|
|
*
|
|
* @return bool @c true if there is a Compositor and it is active, @c false otherwise
|
|
*/
|
|
static bool compositing() {
|
|
return s_compositor != NULL && s_compositor->isActive();
|
|
}
|
|
|
|
// for delayed supportproperty management of effects
|
|
void keepSupportProperty(xcb_atom_t atom);
|
|
void removeSupportProperty(xcb_atom_t atom);
|
|
|
|
Q_SIGNALS:
|
|
void compositingToggled(bool active);
|
|
void aboutToDestroy();
|
|
void aboutToToggleCompositing();
|
|
void sceneCreated();
|
|
void bufferSwapCompleted();
|
|
|
|
protected:
|
|
explicit Compositor(QObject *parent = nullptr);
|
|
void timerEvent(QTimerEvent *te) override;
|
|
|
|
virtual void start() = 0;
|
|
void stop();
|
|
|
|
/**
|
|
* @brief Prepares start.
|
|
* @return bool @c true if start should be continued and @c if not.
|
|
*/
|
|
bool setupStart();
|
|
/**
|
|
* Continues the startup after Scene And Workspace are created
|
|
*/
|
|
void startupWithWorkspace();
|
|
virtual void performCompositing();
|
|
|
|
virtual void configChanged();
|
|
|
|
void destroyCompositorSelection();
|
|
|
|
static Compositor *s_compositor;
|
|
|
|
private:
|
|
void claimCompositorSelection();
|
|
|
|
void setupX11Support();
|
|
|
|
void setCompositeTimer();
|
|
bool windowRepaintsPending() const;
|
|
|
|
void releaseCompositorSelection();
|
|
void deleteUnusedSupportProperties();
|
|
|
|
State m_state;
|
|
|
|
QBasicTimer compositeTimer;
|
|
CompositorSelectionOwner *m_selectionOwner;
|
|
QTimer m_releaseSelectionTimer;
|
|
QList<xcb_atom_t> m_unusedSupportProperties;
|
|
QTimer m_unusedSupportPropertyTimer;
|
|
qint64 vBlankInterval, fpsInterval;
|
|
QRegion repaints_region;
|
|
|
|
qint64 m_timeSinceLastVBlank;
|
|
|
|
Scene *m_scene;
|
|
|
|
bool m_bufferSwapPending;
|
|
bool m_composeAtSwapCompletion;
|
|
|
|
int m_framesToTestForSafety = 3;
|
|
QElapsedTimer m_monotonicClock;
|
|
};
|
|
|
|
class KWIN_EXPORT WaylandCompositor : public Compositor
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
static WaylandCompositor *create(QObject *parent = nullptr);
|
|
~WaylandCompositor() override = default;
|
|
|
|
int refreshRate() const override;
|
|
|
|
void toggleCompositing() override;
|
|
|
|
bool checkForOverlayWindow(WId w) const override;
|
|
|
|
protected:
|
|
void start() override;
|
|
|
|
private:
|
|
explicit WaylandCompositor(QObject *parent);
|
|
};
|
|
|
|
class KWIN_EXPORT X11Compositor : public Compositor
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
enum SuspendReason {
|
|
NoReasonSuspend = 0,
|
|
UserSuspend = 1 << 0,
|
|
BlockRuleSuspend = 1 << 1,
|
|
ScriptSuspend = 1 << 2,
|
|
AllReasonSuspend = 0xff
|
|
};
|
|
Q_DECLARE_FLAGS(SuspendReasons, SuspendReason)
|
|
|
|
static X11Compositor *create(QObject *parent = nullptr);
|
|
~X11Compositor() override = default;
|
|
|
|
/**
|
|
* @brief Suspends the Compositor if it is currently active.
|
|
*
|
|
* Note: it is possible that the Compositor is not able to suspend. Use isActive to check
|
|
* whether the Compositor has been suspended.
|
|
*
|
|
* @return void
|
|
* @see resume
|
|
* @see isActive
|
|
*/
|
|
Q_INVOKABLE void suspend(SuspendReason reason);
|
|
|
|
/**
|
|
* @brief Resumes the Compositor if it is currently suspended.
|
|
*
|
|
* Note: it is possible that the Compositor cannot be resumed, that is there might be Clients
|
|
* blocking the usage of Compositing or the Scene might be broken. Use isActive to check
|
|
* whether the Compositor has been resumed. Also check isCompositingPossible and
|
|
* isOpenGLBroken.
|
|
*
|
|
* Note: The starting of the Compositor can require some time and is partially done threaded.
|
|
* After this method returns the setup may not have been completed.
|
|
*
|
|
* @return void
|
|
* @see suspend
|
|
* @see isActive
|
|
* @see isCompositingPossible
|
|
* @see isOpenGLBroken
|
|
*/
|
|
Q_INVOKABLE void resume(SuspendReason reason);
|
|
|
|
void toggleCompositing() override;
|
|
void reinitialize() override;
|
|
|
|
void configChanged() override;
|
|
|
|
bool checkForOverlayWindow(WId w) const override;
|
|
/**
|
|
* @returns Whether the Scene's Overlay X Window is visible.
|
|
*/
|
|
bool isOverlayWindowVisible() const;
|
|
|
|
int refreshRate() const override;
|
|
|
|
void updateClientCompositeBlocking(Client *client = nullptr);
|
|
|
|
static X11Compositor *self();
|
|
|
|
protected:
|
|
void start() override;
|
|
void performCompositing() override;
|
|
|
|
private:
|
|
explicit X11Compositor(QObject *parent);
|
|
/**
|
|
* Whether the Compositor is currently suspended, 8 bits encoding the reason
|
|
*/
|
|
SuspendReasons m_suspended;
|
|
|
|
int m_xrrRefreshRate;
|
|
};
|
|
|
|
}
|