kwin/tests/test_client_machine.cpp
Martin Gräßlin 5cd223f051 Improved resolving whether a window is on local machine
Most windows use the hostname in WM_CLIENT_MACHINE, but there are windows
using the FQDN (for example libreoffice). So instead of "foo" it is
"foo.local.net" or similar. The logic so far has been unable to properly
determine whether windows with FQDN are on the local system.

In order to solve this problem the handling is split out into an own
class which stores the information of hostname and whether it is a local
machine. This is to not query multiple times. To determine whether the
Client is on the local system getaddrinfo is used for the own hostname
and the FQDN provided in WM_CLIENT_MACHINE. If one of the queried
names matches, we know that it is on the local machine. The old logic to
compare the hostname is still used and getaddrinfo is only a fallback in
case hostname does not match.

The problem with getaddrinfo is, that it accesses the network and by that
could block. To circumvent this problem the calls are moved into threads
by using QtConcurrent::run.

Obviously this brings disadvantages. When trying to resolve whether a
Client is on the local machine and a FQDN is used, the information is
initially wrong. The new ClientMachine class emits a signal when the
information that the system is local becomes available, but for some
things this is just too late:
* window rules are already gathered
* Session Management has already taken place

In both cases this is an acceptable loss. For window rules it just needs
a proper matching of the machine in case of localhost (remote hosts are
not affected). And the case of session management is very academic as it
is unlikely that a restoring session contains remote windows.

BUG: 308391
FIXED-IN: 4.11
REVIEW: 108235
2013-01-21 16:00:49 +01:00

197 lines
6.1 KiB
C++

/********************************************************************
KWin - the KDE window manager
This file is part of the KDE project.
Copyright (C) 2013 Martin Gräßlin <mgraesslin@kde.org>
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*********************************************************************/
// KWin
#include "../client_machine.h"
#include "../utils.h"
// Qt
#include <QApplication>
#include <QtTest/QtTest>
// xcb
#include <xcb/xcb.h>
// system
#include <unistd.h>
#include <netdb.h>
namespace KWin {
// mock required function from utils
QByteArray getStringProperty(WId w, Atom prop, char separator)
{
Q_UNUSED(separator)
ScopedCPointer<xcb_get_property_reply_t> property(xcb_get_property_reply(connection(),
xcb_get_property_unchecked(connection(), false, w, prop, XCB_ATOM_STRING, 0, 10000),
NULL));
if (property.isNull()) {
return QByteArray();
}
void *data = xcb_get_property_value(property.data());
if (data && property->value_len > 0) {
QByteArray result = QByteArray((const char*) data, property->value_len);
return result;
}
return QByteArray();
}
}
using namespace KWin;
class TestClientMachine : public QObject
{
Q_OBJECT
private slots:
void initTestCase();
void cleanupTestCase();
void init();
void cleanup();
void hostName_data();
void hostName();
void emptyHostName();
private:
xcb_window_t createWindow();
void setClientMachineProperty(xcb_window_t window, const QByteArray &hostname);
xcb_window_t m_testWindow;
QByteArray m_hostName;
QByteArray m_fqdn;
};
xcb_window_t TestClientMachine::createWindow()
{
xcb_window_t w = xcb_generate_id(connection());
const uint32_t values[] = { true };
xcb_create_window(connection(), 0, w, rootWindow(),
0, 0, 10, 10,
0, XCB_WINDOW_CLASS_INPUT_ONLY, XCB_COPY_FROM_PARENT,
XCB_CW_OVERRIDE_REDIRECT, values);
return w;
}
void TestClientMachine::setClientMachineProperty(xcb_window_t window, const QByteArray &hostname)
{
xcb_change_property(connection(), XCB_PROP_MODE_REPLACE, window,
XCB_ATOM_WM_CLIENT_MACHINE, XCB_ATOM_STRING, 8,
hostname.length(), hostname.constData());
}
void TestClientMachine::initTestCase()
{
#ifdef HOST_NAME_MAX
char hostnamebuf[HOST_NAME_MAX];
#else
char hostnamebuf[256];
#endif
if (gethostname(hostnamebuf, sizeof hostnamebuf) >= 0) {
hostnamebuf[sizeof(hostnamebuf)-1] = 0;
m_hostName = hostnamebuf;
}
addrinfo *res;
addrinfo addressHints;
memset(&addressHints, 0, sizeof(addressHints));
addressHints.ai_family = PF_UNSPEC;
addressHints.ai_socktype = SOCK_STREAM;
addressHints.ai_flags |= AI_CANONNAME;
if (getaddrinfo(m_hostName.constData(), NULL, &addressHints, &res) == 0) {
if (res->ai_canonname) {
m_fqdn = QByteArray(res->ai_canonname);
}
}
freeaddrinfo(res);
}
void TestClientMachine::cleanupTestCase()
{
}
void TestClientMachine::init()
{
m_testWindow = XCB_WINDOW_NONE;
}
void TestClientMachine::cleanup()
{
if (m_testWindow != XCB_WINDOW_NONE) {
xcb_destroy_window(connection(), m_testWindow);
}
}
void TestClientMachine::hostName_data()
{
QTest::addColumn<QByteArray>("hostName");
QTest::addColumn<QByteArray>("expectedHost");
QTest::addColumn<bool>("local");
QTest::newRow("empty") << QByteArray() << QByteArray("localhost") << true;
QTest::newRow("localhost") << QByteArray("localhost") << QByteArray("localhost") << true;
QTest::newRow("hostname") << m_hostName << m_hostName << true;
QTest::newRow("HOSTNAME") << m_hostName.toUpper() << m_hostName.toUpper() << true;
QByteArray cutted(m_hostName);
cutted.remove(0, 1);
QTest::newRow("ostname") << cutted << cutted << false;
QByteArray domain("random.name.not.exist.tld");
QTest::newRow("domain") << domain << domain << false;
QTest::newRow("fqdn") << m_fqdn << m_fqdn << true;
QTest::newRow("FQDN") << m_fqdn.toUpper() << m_fqdn.toUpper() << true;
cutted = m_fqdn;
cutted.remove(0, 1);
QTest::newRow("qdn") << cutted << cutted << false;
}
void TestClientMachine::hostName()
{
xcb_window_t window = createWindow();
QFETCH(QByteArray, hostName);
QFETCH(bool, local);
setClientMachineProperty(window, hostName);
ClientMachine clientMachine;
QSignalSpy spy(&clientMachine, SIGNAL(localhostChanged()));
clientMachine.resolve(window, XCB_WINDOW_NONE);
QTEST(clientMachine.hostName(), "expectedHost");
int i=0;
while (clientMachine.isResolving() && i++ < 50) {
// name is being resolved in an external thread, so let's wait a little bit
QTest::qWait(250);
}
QCOMPARE(clientMachine.isLocal(), local);
QCOMPARE(spy.isEmpty(), !local);
}
void TestClientMachine::emptyHostName()
{
xcb_window_t window = createWindow();
ClientMachine clientMachine;
QSignalSpy spy(&clientMachine, SIGNAL(localhostChanged()));
clientMachine.resolve(window, XCB_WINDOW_NONE);
QCOMPARE(clientMachine.hostName(), ClientMachine::localhost());
QVERIFY(clientMachine.isLocal());
// should be local
QCOMPARE(spy.isEmpty(), false);
}
// need to implement main manually as we need a QApplication for X11 interaction
int main(int argc, char *argv[]) {
QApplication app(argc, argv);
TestClientMachine tc;
return QTest::qExec(&tc, argc, argv);
}
#include "test_client_machine.moc"