9f2cb0ae1b
Effects are given the interval between two consecutive frames. The main
flaw of this approach is that if the Compositor transitions from the idle
state to "active" state, i.e. when there is something to repaint,
effects may see a very large interval between the last painted frame and
the current. In order to address this issue, the Scene invalidates the
timer that is used to measure time between consecutive frames before the
Compositor is about to become idle.
While this works perfectly fine with Xinerama-style rendering, with per
screen rendering, determining whether the compositor is about to idle is
rather a tedious task mostly because a single output can't be used for
the test.
Furthermore, since the Compositor schedules pointless repaints just to
ensure that it's idle, it might take several attempts to figure out
whether the scene timer must be invalidated if you use (true) per screen
rendering.
Ideally, all effects should use a timeline helper that is aware of the
underlying render loop and its timings. However, this option is off the
table because it will involve a lot of work to implement it.
Alternative and much simpler option is to pass the expected presentation
time to effects rather than time between consecutive frames. This means
that effects are responsible for determining how much animation timelines
have to be advanced. Typically, an effect would have to store the
presentation timestamp provided in either prePaint{Screen,Window} and
use it in the subsequent prePaint{Screen,Window} call to estimate the
amount of time passed between the next and the last frames.
Unfortunately, this is an API incompatible change. However, it shouldn't
take a lot of work to port third-party binary effects, which don't use the
AnimationEffect class, to the new API. On the bright side, we no longer
need to be concerned about the Compositor getting idle.
We do still try to determine whether the Compositor is about to idle,
primarily, because the OpenGL render backend swaps buffers on present,
but that will change with the ongoing compositing timing rework.
151 lines
3.6 KiB
C++
151 lines
3.6 KiB
C++
/*
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
SPDX-FileCopyrightText: 2007 Philip Falkner <philip.falkner@gmail.com>
|
|
SPDX-FileCopyrightText: 2009 Martin Gräßlin <mgraesslin@kde.org>
|
|
SPDX-FileCopyrightText: 2010 Alexandre Pereira <pereira.alex@gmail.com>
|
|
SPDX-FileCopyrightText: 2018 Vlad Zahorodnii <vlad.zahorodnii@kde.org>
|
|
|
|
SPDX-License-Identifier: GPL-2.0-or-later
|
|
*/
|
|
|
|
#ifndef KWIN_GLIDE_H
|
|
#define KWIN_GLIDE_H
|
|
|
|
// kwineffects
|
|
#include <kwineffects.h>
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
struct GlideAnimation
|
|
{
|
|
TimeLine timeLine;
|
|
std::chrono::milliseconds lastPresentTime = std::chrono::milliseconds::zero();
|
|
};
|
|
|
|
class GlideEffect : public Effect
|
|
{
|
|
Q_OBJECT
|
|
Q_PROPERTY(int duration READ duration)
|
|
Q_PROPERTY(RotationEdge inRotationEdge READ inRotationEdge)
|
|
Q_PROPERTY(qreal inRotationAngle READ inRotationAngle)
|
|
Q_PROPERTY(qreal inDistance READ inDistance)
|
|
Q_PROPERTY(qreal inOpacity READ inOpacity)
|
|
Q_PROPERTY(RotationEdge outRotationEdge READ outRotationEdge)
|
|
Q_PROPERTY(qreal outRotationAngle READ outRotationAngle)
|
|
Q_PROPERTY(qreal outDistance READ outDistance)
|
|
Q_PROPERTY(qreal outOpacity READ outOpacity)
|
|
|
|
public:
|
|
GlideEffect();
|
|
~GlideEffect() override;
|
|
|
|
void reconfigure(ReconfigureFlags flags) override;
|
|
|
|
void prePaintScreen(ScreenPrePaintData &data, std::chrono::milliseconds presentTime) override;
|
|
void prePaintWindow(EffectWindow *w, WindowPrePaintData &data, std::chrono::milliseconds presentTime) override;
|
|
void paintWindow(EffectWindow *w, int mask, QRegion region, WindowPaintData &data) override;
|
|
void postPaintScreen() override;
|
|
|
|
bool isActive() const override;
|
|
int requestedEffectChainPosition() const override;
|
|
|
|
static bool supported();
|
|
|
|
enum RotationEdge {
|
|
Top = 0,
|
|
Right = 1,
|
|
Bottom = 2,
|
|
Left = 3
|
|
};
|
|
Q_ENUM(RotationEdge)
|
|
|
|
int duration() const;
|
|
RotationEdge inRotationEdge() const;
|
|
qreal inRotationAngle() const;
|
|
qreal inDistance() const;
|
|
qreal inOpacity() const;
|
|
RotationEdge outRotationEdge() const;
|
|
qreal outRotationAngle() const;
|
|
qreal outDistance() const;
|
|
qreal outOpacity() const;
|
|
|
|
private Q_SLOTS:
|
|
void windowAdded(EffectWindow *w);
|
|
void windowClosed(EffectWindow *w);
|
|
void windowDeleted(EffectWindow *w);
|
|
void windowDataChanged(EffectWindow *w, int role);
|
|
|
|
private:
|
|
bool isGlideWindow(EffectWindow *w) const;
|
|
|
|
std::chrono::milliseconds m_duration;
|
|
QHash<EffectWindow *, GlideAnimation> m_animations;
|
|
|
|
struct GlideParams {
|
|
RotationEdge edge;
|
|
struct {
|
|
qreal from;
|
|
qreal to;
|
|
} angle, distance, opacity;
|
|
};
|
|
|
|
GlideParams m_inParams;
|
|
GlideParams m_outParams;
|
|
};
|
|
|
|
inline int GlideEffect::requestedEffectChainPosition() const
|
|
{
|
|
return 50;
|
|
}
|
|
|
|
inline int GlideEffect::duration() const
|
|
{
|
|
return m_duration.count();
|
|
}
|
|
|
|
inline GlideEffect::RotationEdge GlideEffect::inRotationEdge() const
|
|
{
|
|
return m_inParams.edge;
|
|
}
|
|
|
|
inline qreal GlideEffect::inRotationAngle() const
|
|
{
|
|
return m_inParams.angle.from;
|
|
}
|
|
|
|
inline qreal GlideEffect::inDistance() const
|
|
{
|
|
return m_inParams.distance.from;
|
|
}
|
|
|
|
inline qreal GlideEffect::inOpacity() const
|
|
{
|
|
return m_inParams.opacity.from;
|
|
}
|
|
|
|
inline GlideEffect::RotationEdge GlideEffect::outRotationEdge() const
|
|
{
|
|
return m_outParams.edge;
|
|
}
|
|
|
|
inline qreal GlideEffect::outRotationAngle() const
|
|
{
|
|
return m_outParams.angle.to;
|
|
}
|
|
|
|
inline qreal GlideEffect::outDistance() const
|
|
{
|
|
return m_outParams.distance.to;
|
|
}
|
|
|
|
inline qreal GlideEffect::outOpacity() const
|
|
{
|
|
return m_outParams.opacity.to;
|
|
}
|
|
|
|
} // namespace KWin
|
|
|
|
#endif
|