kwin/kcmkwin/kwindecoration
David Edmundson 14b827daaa [kcmkwin/kwindecoration] Fix save of theme name
Summary:
If a user saves a decoration that has a plugin but no theme we currently
delete the entry saving just the plugin/library.

This is an issue as on load we call:

    const QString plugin = config.readEntry("library", s_defaultPlugin);
    const QString theme = config.readEntry("theme", s_defaultTheme);

That would give us a non-default library with the default theme name,
which would be invalid.

If compiled with Breeze s_defaultTheme is blank so this ends up being
effectively the same thing. In the normal case it will neither break
nor fix anything.

Test Plan:
None.
Just happened to see it when doing a code review.

Reviewers: #kwin, vpilo

Reviewed By: vpilo

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D18146
2019-01-10 15:30:59 +00:00
..
declarative-plugin [kcmkwin/kwindecoration] Add missing QT include 2018-07-26 10:04:41 -07:00
qml [kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab 2019-01-08 15:15:56 +01:00
CMakeLists.txt
decorationmodel.cpp
decorationmodel.h Fix minor EBN issues 2018-08-29 21:02:16 +03:00
kcm.cpp [kcmkwin/kwindecoration] Fix save of theme name 2019-01-10 15:30:59 +00:00
kcm.h
kcm.ui [KCMs] move GHNS buttons to the normal location 2018-10-31 07:29:22 -06:00
kwindecoration.desktop SVN_SILENT made messages (.desktop file) - always resolve ours 2018-11-22 06:02:11 +01:00
Messages.sh