f0e1e3187e
This is going to be a controversal change. It enforces KWin decorations on all client side decorated windows from GTK+. Unfortunately we are caught between a rock and a hard place. Keeping the status quo means having broken windows and a more or less broken window manager due to GTK+ including the shadow in the windows. This is no solution. Enforcing server side decorations visually breaks the windows. This is also no solution. So why do it? It's our task to provide the best possible user experience and KWin is a window manager which has always done great efforts to fix misbehaving windows. One can think of the focus stealing prevention, the window rules and lately the scripts. The best possible window management experience is our aim. This means we cannot leave the users with the broken windows from GTK. The issues we noticed were reported to GTK+ about 2 months ago and we are working on improving the situation. Unfortunately several issues are not yet addressed and others will only be addressed in the next GTK+ release. We are working on improving the NETWM spec (see [1]) to ensure that the client side decorated windows are not in a broken state. This means the enforcment is a temporary solution and will be re-evaluated with the next GTK release. I would prefer to not have to do such a change, if some of the bugs were fixed or GTK+ would not use client-side-decos on wms not yet supporting those all of this would be a no issue. For a complete list of the problems caused by GTK's decos see bug [2] and the linked bug reports from there. The change is done in a least inversive way in KWin. We just check for the property _GTK_FRAME_EXTENTS and create a Q_PROPERTY in Client for it. If we add support for the frame extents in future we would also need this. So it's not a change just for enforcing the decoration. The actual enforcing is done through a KWin script so users can still disable it. REVIEW: 119062 [1] https://mail.gnome.org/archives/wm-spec-list/2014-June/msg00002.html [2] https://bugzilla.gnome.org/show_bug.cgi?id=729721
87 lines
2.4 KiB
C++
87 lines
2.4 KiB
C++
/********************************************************************
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
Copyright (C) 1999, 2000 Matthias Ettrich <ettrich@kde.org>
|
|
Copyright (C) 2003 Lubos Lunak <l.lunak@kde.org>
|
|
Copyright (C) 2013 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*********************************************************************/
|
|
|
|
#ifndef KWIN_ATOMS_H
|
|
#define KWIN_ATOMS_H
|
|
|
|
#include "xcbutils.h"
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
class Atoms
|
|
{
|
|
public:
|
|
Atoms();
|
|
|
|
Xcb::Atom kwin_running;
|
|
Xcb::Atom activities;
|
|
|
|
Xcb::Atom wm_protocols;
|
|
Xcb::Atom wm_delete_window;
|
|
Xcb::Atom wm_take_focus;
|
|
Xcb::Atom wm_change_state;
|
|
Xcb::Atom wm_client_leader;
|
|
Xcb::Atom wm_window_role;
|
|
Xcb::Atom wm_state;
|
|
Xcb::Atom sm_client_id;
|
|
|
|
Xcb::Atom motif_wm_hints;
|
|
Xcb::Atom net_wm_context_help;
|
|
Xcb::Atom net_wm_ping;
|
|
Xcb::Atom net_wm_user_time;
|
|
Xcb::Atom kde_net_wm_user_creation_time;
|
|
Xcb::Atom net_wm_take_activity;
|
|
Xcb::Atom net_wm_window_opacity;
|
|
Xcb::Atom xdnd_aware;
|
|
Xcb::Atom xdnd_position;
|
|
Xcb::Atom net_frame_extents;
|
|
Xcb::Atom kde_net_wm_frame_strut;
|
|
Xcb::Atom net_wm_sync_request_counter;
|
|
Xcb::Atom net_wm_sync_request;
|
|
Xcb::Atom kde_net_wm_shadow;
|
|
Xcb::Atom net_wm_opaque_region;
|
|
Xcb::Atom kde_net_wm_tab_group;
|
|
Xcb::Atom kde_first_in_window_list;
|
|
Xcb::Atom kde_color_sheme;
|
|
Xcb::Atom kde_skip_close_animation;
|
|
Xcb::Atom kde_screen_edge_show;
|
|
Xcb::Atom gtk_frame_extents;
|
|
|
|
/**
|
|
* @internal
|
|
**/
|
|
void retrieveHelpers();
|
|
|
|
private:
|
|
// helper atoms we need to resolve to "announce" support (see #172028)
|
|
Xcb::Atom m_dtSmWindowInfo;
|
|
Xcb::Atom m_motifSupport;
|
|
bool m_helpersRetrieved;
|
|
};
|
|
|
|
|
|
extern Atoms* atoms;
|
|
|
|
} // namespace
|
|
|
|
#endif
|