7fffe99328
Due to being a compositor, kwin has to conform to some certain interfaces. It means a lot of virtual functions and function tables to integrate with C APIs. Naturally, we not always want to use every argument in such functions. Since we get -Wunused-parameter from -Wall, we have to plumb those unused arguments in order to suppress compiler warnings at the moment. However, I don't think that extra work is worth it. We cannot change or alter prototypes in any way to fix the warning the desired way. Q_UNUSED and similar macros are not good indicators of whether an argument is used too, we tend to overlook putting or removing those macros. I've also noticed that Q_UNUSED are not used to guide us with the removal no longer needed parameters. Therefore, I think it's worth adding -Wno-unused-parameter compiler option to stop the compiler producing warnings about unused parameters. It changes nothing except that we don't need to put Q_UNUSED anymore, which can be really cumbersome sometimes. Note that it doesn't affect unused variables, you'll still get a -Wunused-variable compiler warning if a variable is unused.
142 lines
4.6 KiB
C++
142 lines
4.6 KiB
C++
/*
|
|
SPDX-FileCopyrightText: 2020 Vlad Zahorodnii <vlad.zahorodnii@kde.org>
|
|
|
|
SPDX-License-Identifier: LGPL-2.1-only OR LGPL-3.0-only OR LicenseRef-KDE-Accepted-LGPL
|
|
*/
|
|
|
|
#include "xdgdecoration_v1_interface.h"
|
|
#include "display.h"
|
|
#include "xdgdecoration_v1_interface_p.h"
|
|
#include "xdgshell_interface_p.h"
|
|
|
|
namespace KWaylandServer
|
|
{
|
|
// TODO: We need to wait for an ack_configure either here or in xdgshellclient.cpp.
|
|
|
|
XdgDecorationManagerV1InterfacePrivate::XdgDecorationManagerV1InterfacePrivate(XdgDecorationManagerV1Interface *manager)
|
|
: q(manager)
|
|
{
|
|
}
|
|
|
|
void XdgDecorationManagerV1InterfacePrivate::zxdg_decoration_manager_v1_destroy(Resource *resource)
|
|
{
|
|
wl_resource_destroy(resource->handle);
|
|
}
|
|
|
|
void XdgDecorationManagerV1InterfacePrivate::zxdg_decoration_manager_v1_get_toplevel_decoration(Resource *resource,
|
|
uint32_t id,
|
|
::wl_resource *toplevelResource)
|
|
{
|
|
XdgToplevelInterfacePrivate *toplevelPrivate = XdgToplevelInterfacePrivate::get(toplevelResource);
|
|
if (!toplevelPrivate) {
|
|
wl_resource_post_error(resource->handle, QtWaylandServer::zxdg_toplevel_decoration_v1::error_orphaned, "no xdg-toplevel object");
|
|
return;
|
|
}
|
|
|
|
if (toplevelPrivate->decoration) {
|
|
wl_resource_post_error(resource->handle,
|
|
QtWaylandServer::zxdg_toplevel_decoration_v1::error_already_constructed,
|
|
"decoration has been already constructed");
|
|
return;
|
|
}
|
|
|
|
wl_resource *decorationResource = wl_resource_create(resource->client(), &zxdg_toplevel_decoration_v1_interface, resource->version(), id);
|
|
|
|
auto decoration = new XdgToplevelDecorationV1Interface(toplevelPrivate->q, decorationResource);
|
|
toplevelPrivate->decoration = decoration;
|
|
|
|
Q_EMIT q->decorationCreated(decoration);
|
|
}
|
|
|
|
XdgDecorationManagerV1Interface::XdgDecorationManagerV1Interface(Display *display, QObject *parent)
|
|
: QObject(parent)
|
|
, d(new XdgDecorationManagerV1InterfacePrivate(this))
|
|
{
|
|
d->init(*display, 1);
|
|
}
|
|
|
|
XdgDecorationManagerV1Interface::~XdgDecorationManagerV1Interface()
|
|
{
|
|
}
|
|
|
|
XdgToplevelDecorationV1InterfacePrivate::XdgToplevelDecorationV1InterfacePrivate(XdgToplevelDecorationV1Interface *decoration)
|
|
: q(decoration)
|
|
{
|
|
}
|
|
|
|
void XdgToplevelDecorationV1InterfacePrivate::zxdg_toplevel_decoration_v1_destroy_resource(Resource *resource)
|
|
{
|
|
delete q;
|
|
}
|
|
|
|
void XdgToplevelDecorationV1InterfacePrivate::zxdg_toplevel_decoration_v1_destroy(Resource *resource)
|
|
{
|
|
wl_resource_destroy(resource->handle);
|
|
}
|
|
|
|
void XdgToplevelDecorationV1InterfacePrivate::zxdg_toplevel_decoration_v1_set_mode(Resource *resource, uint32_t mode)
|
|
{
|
|
switch (mode) {
|
|
case mode_client_side:
|
|
preferredMode = XdgToplevelDecorationV1Interface::Mode::Client;
|
|
break;
|
|
case mode_server_side:
|
|
preferredMode = XdgToplevelDecorationV1Interface::Mode::Server;
|
|
break;
|
|
default:
|
|
preferredMode = XdgToplevelDecorationV1Interface::Mode::Undefined;
|
|
break;
|
|
}
|
|
|
|
Q_EMIT q->preferredModeChanged(preferredMode);
|
|
}
|
|
|
|
void XdgToplevelDecorationV1InterfacePrivate::zxdg_toplevel_decoration_v1_unset_mode(Resource *resource)
|
|
{
|
|
preferredMode = XdgToplevelDecorationV1Interface::Mode::Undefined;
|
|
Q_EMIT q->preferredModeChanged(preferredMode);
|
|
}
|
|
|
|
XdgToplevelDecorationV1Interface::XdgToplevelDecorationV1Interface(XdgToplevelInterface *toplevel, ::wl_resource *resource)
|
|
: d(new XdgToplevelDecorationV1InterfacePrivate(this))
|
|
{
|
|
d->toplevel = toplevel;
|
|
d->init(resource);
|
|
}
|
|
|
|
XdgToplevelDecorationV1Interface::~XdgToplevelDecorationV1Interface()
|
|
{
|
|
}
|
|
|
|
XdgToplevelInterface *XdgToplevelDecorationV1Interface::toplevel() const
|
|
{
|
|
return d->toplevel;
|
|
}
|
|
|
|
XdgToplevelDecorationV1Interface::Mode XdgToplevelDecorationV1Interface::preferredMode() const
|
|
{
|
|
return d->preferredMode;
|
|
}
|
|
|
|
void XdgToplevelDecorationV1Interface::sendConfigure(Mode mode)
|
|
{
|
|
switch (mode) {
|
|
case Mode::Client:
|
|
d->send_configure(QtWaylandServer::zxdg_toplevel_decoration_v1::mode_client_side);
|
|
break;
|
|
case Mode::None: // Faked as server_side mode.
|
|
case Mode::Server:
|
|
d->send_configure(QtWaylandServer::zxdg_toplevel_decoration_v1::mode_server_side);
|
|
break;
|
|
case Mode::Undefined:
|
|
break;
|
|
}
|
|
}
|
|
|
|
XdgToplevelDecorationV1Interface *XdgToplevelDecorationV1Interface::get(XdgToplevelInterface *toplevel)
|
|
{
|
|
XdgToplevelInterfacePrivate *toplevelPrivate = XdgToplevelInterfacePrivate::get(toplevel);
|
|
return toplevelPrivate->decoration;
|
|
}
|
|
|
|
} // namespace KWaylandServer
|