7fffe99328
Due to being a compositor, kwin has to conform to some certain interfaces. It means a lot of virtual functions and function tables to integrate with C APIs. Naturally, we not always want to use every argument in such functions. Since we get -Wunused-parameter from -Wall, we have to plumb those unused arguments in order to suppress compiler warnings at the moment. However, I don't think that extra work is worth it. We cannot change or alter prototypes in any way to fix the warning the desired way. Q_UNUSED and similar macros are not good indicators of whether an argument is used too, we tend to overlook putting or removing those macros. I've also noticed that Q_UNUSED are not used to guide us with the removal no longer needed parameters. Therefore, I think it's worth adding -Wno-unused-parameter compiler option to stop the compiler producing warnings about unused parameters. It changes nothing except that we don't need to put Q_UNUSED anymore, which can be really cumbersome sometimes. Note that it doesn't affect unused variables, you'll still get a -Wunused-variable compiler warning if a variable is unused.
110 lines
3.9 KiB
C++
110 lines
3.9 KiB
C++
/*
|
|
SPDX-FileCopyrightText: 2022 David Redondo <kde@david-redondo.de>
|
|
|
|
SPDX-License-Identifier: LGPL-2.1-only OR LGPL-3.0-only OR LicenseRef-KDE-Accepted-LGPL
|
|
*/
|
|
|
|
#include "xwaylandkeyboardgrab_v1_interface.h"
|
|
|
|
#include <qwayland-server-xwayland-keyboard-grab-unstable-v1.h>
|
|
|
|
#include "display.h"
|
|
#include "seat_interface.h"
|
|
#include "surface_interface.h"
|
|
|
|
constexpr int version = 1;
|
|
|
|
namespace KWaylandServer
|
|
{
|
|
|
|
class XWaylandKeyboardGrabManagerV1InterfacePrivate : QtWaylandServer::zwp_xwayland_keyboard_grab_manager_v1
|
|
{
|
|
public:
|
|
XWaylandKeyboardGrabManagerV1InterfacePrivate(Display *display, XWaylandKeyboardGrabManagerV1Interface *q);
|
|
XWaylandKeyboardGrabManagerV1Interface *const q;
|
|
QHash<QPair<const SurfaceInterface *, const SeatInterface *>, XWaylandKeyboardGrabV1Interface *> m_grabs;
|
|
|
|
protected:
|
|
void zwp_xwayland_keyboard_grab_manager_v1_destroy(Resource *resource) override;
|
|
void zwp_xwayland_keyboard_grab_manager_v1_grab_keyboard(Resource *resource, uint32_t id, wl_resource *surface, wl_resource *seat) override;
|
|
};
|
|
|
|
class XWaylandKeyboardGrabV1InterfacePrivate : QtWaylandServer::zwp_xwayland_keyboard_grab_v1
|
|
{
|
|
public:
|
|
XWaylandKeyboardGrabV1InterfacePrivate(XWaylandKeyboardGrabV1Interface *q, wl_resource *resource);
|
|
XWaylandKeyboardGrabV1Interface *const q;
|
|
|
|
protected:
|
|
void zwp_xwayland_keyboard_grab_v1_destroy(Resource *resource) override;
|
|
void zwp_xwayland_keyboard_grab_v1_destroy_resource(Resource *resource) override;
|
|
};
|
|
|
|
XWaylandKeyboardGrabManagerV1InterfacePrivate::XWaylandKeyboardGrabManagerV1InterfacePrivate(Display *display, XWaylandKeyboardGrabManagerV1Interface *q)
|
|
: zwp_xwayland_keyboard_grab_manager_v1(*display, version)
|
|
, q(q)
|
|
{
|
|
}
|
|
|
|
void XWaylandKeyboardGrabManagerV1InterfacePrivate::zwp_xwayland_keyboard_grab_manager_v1_destroy(Resource *resource)
|
|
{
|
|
wl_resource_destroy(resource->handle);
|
|
}
|
|
|
|
void XWaylandKeyboardGrabManagerV1InterfacePrivate::zwp_xwayland_keyboard_grab_manager_v1_grab_keyboard(Resource *resource, uint32_t id, wl_resource *surface, wl_resource *seat)
|
|
{
|
|
wl_resource *keyboardGrab = wl_resource_create(resource->client(), &zwp_xwayland_keyboard_grab_v1_interface, version, id);
|
|
if (!keyboardGrab) {
|
|
wl_client_post_no_memory(resource->client());
|
|
return;
|
|
}
|
|
const auto surfaceInterface = SurfaceInterface::get(surface);
|
|
const auto seatInterface = SeatInterface::get(seat);
|
|
auto grab = new XWaylandKeyboardGrabV1Interface(keyboardGrab);
|
|
QObject::connect(grab, &QObject::destroyed, q, [this, surfaceInterface, seatInterface] {
|
|
m_grabs.remove({surfaceInterface, seatInterface});
|
|
});
|
|
m_grabs.insert({SurfaceInterface::get(surface), SeatInterface::get(seat)}, grab);
|
|
}
|
|
|
|
XWaylandKeyboardGrabManagerV1Interface::XWaylandKeyboardGrabManagerV1Interface(Display *display, QObject *parent)
|
|
: QObject(parent)
|
|
, d(std::make_unique<XWaylandKeyboardGrabManagerV1InterfacePrivate>(display, this))
|
|
{
|
|
}
|
|
|
|
XWaylandKeyboardGrabManagerV1Interface::~XWaylandKeyboardGrabManagerV1Interface()
|
|
{
|
|
}
|
|
|
|
bool XWaylandKeyboardGrabManagerV1Interface::hasGrab(SurfaceInterface *surface, SeatInterface *seat) const
|
|
{
|
|
return d->m_grabs.contains({surface, seat});
|
|
}
|
|
|
|
XWaylandKeyboardGrabV1InterfacePrivate::XWaylandKeyboardGrabV1InterfacePrivate(XWaylandKeyboardGrabV1Interface *q, wl_resource *resource)
|
|
: zwp_xwayland_keyboard_grab_v1(resource)
|
|
, q(q)
|
|
{
|
|
}
|
|
|
|
void XWaylandKeyboardGrabV1InterfacePrivate::zwp_xwayland_keyboard_grab_v1_destroy(Resource *resource)
|
|
{
|
|
wl_resource_destroy(resource->handle);
|
|
}
|
|
|
|
void XWaylandKeyboardGrabV1InterfacePrivate::zwp_xwayland_keyboard_grab_v1_destroy_resource(Resource *resource)
|
|
{
|
|
delete q;
|
|
}
|
|
|
|
XWaylandKeyboardGrabV1Interface::XWaylandKeyboardGrabV1Interface(wl_resource *resource)
|
|
: d(std::make_unique<XWaylandKeyboardGrabV1InterfacePrivate>(this, resource))
|
|
{
|
|
}
|
|
|
|
XWaylandKeyboardGrabV1Interface::~XWaylandKeyboardGrabV1Interface()
|
|
{
|
|
}
|
|
|
|
}
|