af71763be5
Summary: Quite long time ago, window decorations were painted on real X11 windows. The nicest thing about that approach is that we get both contents of the client and the frame window at the same time. However, somewhere around KDE 4.2 - 4.3 times, decoration rendering architecture had been changed to what we have now. I've mentioned the previous decoration rendering design because it didn't have a problem that the new design has, namely the texture bleeding issue. In the name of better performance, opengl scene puts all decoration parts to an atlas. This is totally reasonable, however we must be super cautious about things such as the GL_LINEAR filter. The GL_LINEAR filter may need to sample a couple of neighboring texels in order to produce the final texel value. However, since all decoration parts now live in a single texture, we have to make sure that we don't sample texels that belong to another decoration part. This patch fixes the texture bleeding problem by padding each individual decoration part in the atlas. There is another solution for this problem though. We could render a window into an offscreen texture and then map that texture on the transformed window geometry. This would work well and we definitely need an offscreen rendering path in the opengl scene, however it's not feasible at the moment since we need to break the window quads API. Also, it would be great to have as less as possible stuff going on between invocation of Scene::Window::performPaint() and getting the corresponding pixel data on the screen. There is a good chance that the new padding stuff may make you vomit. If it does so, I'm all ears for the suggestions how to make the code more nicer. BUG: 257566 BUG: 360549 CCBUG: 412573 FIXED-IN: 5.18.0 Reviewers: #kwin Subscribers: fredrik, kwin, fvogt Tags: #kwin Differential Revision: https://phabricator.kde.org/D25611
87 lines
2.1 KiB
C++
87 lines
2.1 KiB
C++
/********************************************************************
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
Copyright (C) 2014 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*********************************************************************/
|
|
#ifndef KWIN_DECORATION_RENDERER_H
|
|
#define KWIN_DECORATION_RENDERER_H
|
|
|
|
#include <QObject>
|
|
#include <QRegion>
|
|
|
|
#include <kwin_export.h>
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
class Deleted;
|
|
|
|
namespace Decoration
|
|
{
|
|
|
|
class DecoratedClientImpl;
|
|
|
|
class KWIN_EXPORT Renderer : public QObject
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
~Renderer() override;
|
|
|
|
void schedule(const QRect &rect);
|
|
|
|
/**
|
|
* Reparents this Renderer to the @p deleted.
|
|
* After this call the Renderer is no longer able to render
|
|
* anything, client() returns a nullptr.
|
|
*/
|
|
virtual void reparent(Deleted *deleted);
|
|
|
|
Q_SIGNALS:
|
|
void renderScheduled(const QRect &geo);
|
|
|
|
protected:
|
|
explicit Renderer(DecoratedClientImpl *client);
|
|
/**
|
|
* @returns the scheduled paint region and resets
|
|
*/
|
|
QRegion getScheduled();
|
|
|
|
virtual void render() = 0;
|
|
|
|
DecoratedClientImpl *client() {
|
|
return m_client;
|
|
}
|
|
|
|
bool areImageSizesDirty() const {
|
|
return m_imageSizesDirty;
|
|
}
|
|
void resetImageSizesDirty() {
|
|
m_imageSizesDirty = false;
|
|
}
|
|
QImage renderToImage(const QRect &geo);
|
|
void renderToPainter(QPainter *painter, const QRect &rect);
|
|
|
|
private:
|
|
DecoratedClientImpl *m_client;
|
|
QRegion m_scheduled;
|
|
bool m_imageSizesDirty;
|
|
};
|
|
|
|
}
|
|
}
|
|
|
|
#endif
|