7fffe99328
Due to being a compositor, kwin has to conform to some certain interfaces. It means a lot of virtual functions and function tables to integrate with C APIs. Naturally, we not always want to use every argument in such functions. Since we get -Wunused-parameter from -Wall, we have to plumb those unused arguments in order to suppress compiler warnings at the moment. However, I don't think that extra work is worth it. We cannot change or alter prototypes in any way to fix the warning the desired way. Q_UNUSED and similar macros are not good indicators of whether an argument is used too, we tend to overlook putting or removing those macros. I've also noticed that Q_UNUSED are not used to guide us with the removal no longer needed parameters. Therefore, I think it's worth adding -Wno-unused-parameter compiler option to stop the compiler producing warnings about unused parameters. It changes nothing except that we don't need to put Q_UNUSED anymore, which can be really cumbersome sometimes. Note that it doesn't affect unused variables, you'll still get a -Wunused-variable compiler warning if a variable is unused.
39 lines
948 B
C++
39 lines
948 B
C++
/*
|
|
SPDX-FileCopyrightText: 2021 Vlad Zahorodnii <vlad.zahorodnii@kde.org>
|
|
|
|
SPDX-License-Identifier: LGPL-2.1-only OR LGPL-3.0-only OR LicenseRef-KDE-Accepted-LGPL
|
|
*/
|
|
|
|
#include "clientbufferintegration.h"
|
|
#include "display.h"
|
|
#include "display_p.h"
|
|
|
|
namespace KWaylandServer
|
|
{
|
|
ClientBufferIntegration::ClientBufferIntegration(Display *display)
|
|
: QObject(display)
|
|
, m_display(display)
|
|
{
|
|
DisplayPrivate *displayPrivate = DisplayPrivate::get(display);
|
|
displayPrivate->bufferIntegrations.append(this);
|
|
}
|
|
|
|
ClientBufferIntegration::~ClientBufferIntegration()
|
|
{
|
|
if (m_display) {
|
|
DisplayPrivate *displayPrivate = DisplayPrivate::get(m_display);
|
|
displayPrivate->bufferIntegrations.removeOne(this);
|
|
}
|
|
}
|
|
|
|
Display *ClientBufferIntegration::display() const
|
|
{
|
|
return m_display;
|
|
}
|
|
|
|
ClientBuffer *ClientBufferIntegration::createBuffer(wl_resource *resource)
|
|
{
|
|
return nullptr;
|
|
}
|
|
|
|
} // namespace KWaylandServer
|