8e88139fd6
Summary:
There are several issues with code of AbstractOutput class:
(a) Some methods are documented, and some are not. In general, we tend
to document all public methods in KWin core. It looks like a very
minor issue, but there are methods that have very ambiguous return
value. One such method is geometry(). It's not obvious whether the
returned geometry is in device independent pixels or not;
(b) There's a mix of methods defined in the cpp file and in the header.
This is not very good because reading such code becomes a bit harder
if you don't use any fancy IDE;
(c) Missing Q_DISABLE_COPY, etc.
This change addresses these issues, so the code is a bit more readable
and easier to work with.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: broulik, cfeck, davidedmundson, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D21874
107 lines
2 KiB
C++
107 lines
2 KiB
C++
/********************************************************************
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
Copyright 2018 Roman Gilg <subdiff@gmail.com>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*********************************************************************/
|
|
|
|
#include "abstract_output.h"
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
GammaRamp::GammaRamp(uint32_t size)
|
|
: m_table(3 * size)
|
|
, m_size(size)
|
|
{
|
|
}
|
|
|
|
uint32_t GammaRamp::size() const
|
|
{
|
|
return m_size;
|
|
}
|
|
|
|
uint16_t *GammaRamp::red()
|
|
{
|
|
return m_table.data();
|
|
}
|
|
|
|
const uint16_t *GammaRamp::red() const
|
|
{
|
|
return m_table.data();
|
|
}
|
|
|
|
uint16_t *GammaRamp::green()
|
|
{
|
|
return m_table.data() + m_size;
|
|
}
|
|
|
|
const uint16_t *GammaRamp::green() const
|
|
{
|
|
return m_table.data() + m_size;
|
|
}
|
|
|
|
uint16_t *GammaRamp::blue()
|
|
{
|
|
return m_table.data() + 2 * m_size;
|
|
}
|
|
|
|
const uint16_t *GammaRamp::blue() const
|
|
{
|
|
return m_table.data() + 2 * m_size;
|
|
}
|
|
|
|
AbstractOutput::AbstractOutput(QObject *parent)
|
|
: QObject(parent)
|
|
{
|
|
}
|
|
|
|
AbstractOutput::~AbstractOutput()
|
|
{
|
|
}
|
|
|
|
bool AbstractOutput::isInternal() const
|
|
{
|
|
return false;
|
|
}
|
|
|
|
qreal AbstractOutput::scale() const
|
|
{
|
|
return 1;
|
|
}
|
|
|
|
QSize AbstractOutput::physicalSize() const
|
|
{
|
|
return QSize();
|
|
}
|
|
|
|
Qt::ScreenOrientation AbstractOutput::orientation() const
|
|
{
|
|
return Qt::PrimaryOrientation;
|
|
}
|
|
|
|
int AbstractOutput::gammaRampSize() const
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
bool AbstractOutput::setGammaRamp(const GammaRamp &gamma)
|
|
{
|
|
Q_UNUSED(gamma);
|
|
return false;
|
|
}
|
|
|
|
} // namespace KWin
|