ad28da84e7
Summary: If you switch virtual desktops while krunner is sliding in, then depending on whether your distro strips assert statements away, KWin can crash. The reason why it crashes is the sliding popups effect tries to unref deleted windows that it hasn't referenced before (if there is an active full screen effect, then popups won't be slided out, which in its turn means that we won't reference deleted windows). So, in the end, the refcount of those windows can be -1. That triggers an assert statement in the destructor of the Deleted class, which checks whether the refcount is equal to 0. Popups are not slided while there is an active full screen effect because we don't know what the full screen effect does. This patch adjusts the sliding popups effect so it stops all active animations when user switches virtual desktops or when a full screen effect kicks in. We need to do that so the effect won't try to unreference windows in postPaintWindow. Visually, it doesn't look quite nice, but for now that's good enough. A proper fix would be more complex: we would need to make sure that full screen effects ignore sliding popups (and also maybe docks) and perform some input redirection. BUG: 400170 FIXED-IN: 5.14.4 Test Plan: I'm not able anymore to reproduce bug 400170. Reviewers: #kwin, graesslin Reviewed By: #kwin, graesslin Subscribers: davidedmundson, graesslin, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D16731
115 lines
3.1 KiB
C++
115 lines
3.1 KiB
C++
/********************************************************************
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
Copyright (C) 2009 Marco Martin notmart@gmail.com
|
|
Copyright (C) 2018 Vlad Zagorodniy <vladzzag@gmail.com>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*********************************************************************/
|
|
|
|
#ifndef KWIN_SLIDINGPOPUPS_H
|
|
#define KWIN_SLIDINGPOPUPS_H
|
|
|
|
// Include with base class for effects.
|
|
#include <kwineffects.h>
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
class SlidingPopupsEffect : public Effect
|
|
{
|
|
Q_OBJECT
|
|
Q_PROPERTY(int slideInDuration READ slideInDuration)
|
|
Q_PROPERTY(int slideOutDuration READ slideOutDuration)
|
|
|
|
public:
|
|
SlidingPopupsEffect();
|
|
~SlidingPopupsEffect() override;
|
|
|
|
void prePaintWindow(EffectWindow *w, WindowPrePaintData &data, int time) override;
|
|
void paintWindow(EffectWindow *w, int mask, QRegion region, WindowPaintData &data) override;
|
|
void postPaintWindow(EffectWindow *w) override;
|
|
void reconfigure(ReconfigureFlags flags) override;
|
|
bool isActive() const override;
|
|
|
|
int requestedEffectChainPosition() const override {
|
|
return 40;
|
|
}
|
|
|
|
static bool supported();
|
|
|
|
int slideInDuration() const;
|
|
int slideOutDuration() const;
|
|
|
|
private Q_SLOTS:
|
|
void slotWindowAdded(EffectWindow *w);
|
|
void slotWindowDeleted(EffectWindow *w);
|
|
void slotPropertyNotify(EffectWindow *w, long atom);
|
|
void slotWaylandSlideOnShowChanged(EffectWindow *w);
|
|
|
|
void slideIn(EffectWindow *w);
|
|
void slideOut(EffectWindow *w);
|
|
void stopAnimations();
|
|
|
|
private:
|
|
void setupAnimData(EffectWindow *w);
|
|
|
|
long m_atom;
|
|
|
|
int m_slideLength;
|
|
std::chrono::milliseconds m_slideInDuration;
|
|
std::chrono::milliseconds m_slideOutDuration;
|
|
|
|
enum class AnimationKind {
|
|
In,
|
|
Out
|
|
};
|
|
|
|
struct Animation {
|
|
AnimationKind kind;
|
|
TimeLine timeLine;
|
|
};
|
|
QHash<EffectWindow *, Animation> m_animations;
|
|
|
|
enum class Location {
|
|
Left,
|
|
Top,
|
|
Right,
|
|
Bottom
|
|
};
|
|
|
|
struct AnimationData {
|
|
int offset;
|
|
Location location;
|
|
std::chrono::milliseconds slideInDuration;
|
|
std::chrono::milliseconds slideOutDuration;
|
|
int slideLength;
|
|
};
|
|
QHash<const EffectWindow*, AnimationData> m_animationsData;
|
|
};
|
|
|
|
inline int SlidingPopupsEffect::slideInDuration() const
|
|
{
|
|
return m_slideInDuration.count();
|
|
}
|
|
|
|
inline int SlidingPopupsEffect::slideOutDuration() const
|
|
{
|
|
return m_slideOutDuration.count();
|
|
}
|
|
|
|
} // namespace
|
|
|
|
#endif
|