7292af3d04
With fractional scaling integer based logical geometry may not match device pixels. Once we have a floating point base we can fix that. This also is important for our X11 scale override, with a scale of 2 we could get logical sizes with halves. We already have all input being floating point, this doubles down on it for all remaining geometry. - Outputs remain integer to ensure that any screen on the right remains aligned. - Placement also remains integer based for now. - Repainting is untouched as we always expand outwards (QRectF::toAdjustedRect(). - Decoration is untouched for now - Rules are integer in the config, but floating in the adjusting/API This should also be fine. At some point we'll add a method to snap to the device pixel grid. Effectively `round(value * dpr) / dpr` though right now things mostly work. This also gets rid of a lot of hacks for QRect right and bottom which are very confusing. Parts to watch out in the port are: QRectF::contains now includes edges QRectF::right and bottom are now sane so previous hacks have to be removed QRectF(QPoint, QPoint) behaves differently for the same reason QRectF::center too In test results some adjusted values which are the result of QRect.center because using QRectF's center should behave the same to the user.
558 lines
26 KiB
C++
558 lines
26 KiB
C++
/*
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
SPDX-FileCopyrightText: 2016 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
SPDX-License-Identifier: GPL-2.0-or-later
|
|
*/
|
|
#include "kwin_wayland_test.h"
|
|
|
|
#include "cursor.h"
|
|
#include "output.h"
|
|
#include "platform.h"
|
|
#include "wayland/seat_interface.h"
|
|
#include "wayland/surface_interface.h"
|
|
#include "wayland_server.h"
|
|
#include "window.h"
|
|
#include "workspace.h"
|
|
#include <kwineffects.h>
|
|
|
|
#include <KWayland/Client/compositor.h>
|
|
#include <KWayland/Client/connection_thread.h>
|
|
#include <KWayland/Client/event_queue.h>
|
|
#include <KWayland/Client/keyboard.h>
|
|
#include <KWayland/Client/plasmashell.h>
|
|
#include <KWayland/Client/pointer.h>
|
|
#include <KWayland/Client/registry.h>
|
|
#include <KWayland/Client/seat.h>
|
|
#include <KWayland/Client/server_decoration.h>
|
|
#include <KWayland/Client/shm_pool.h>
|
|
#include <KWayland/Client/surface.h>
|
|
#include <KWayland/Client/touch.h>
|
|
|
|
struct PopupLayout
|
|
{
|
|
QRect anchorRect;
|
|
QSize size;
|
|
quint32 anchor = 0;
|
|
quint32 gravity = 0;
|
|
quint32 constraint = 0;
|
|
};
|
|
Q_DECLARE_METATYPE(PopupLayout)
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
static const QString s_socketName = QStringLiteral("wayland_test_kwin_transient_placement-0");
|
|
|
|
class TransientPlacementTest : public QObject
|
|
{
|
|
Q_OBJECT
|
|
private Q_SLOTS:
|
|
void initTestCase();
|
|
void init();
|
|
void cleanup();
|
|
void testXdgPopup_data();
|
|
void testXdgPopup();
|
|
void testXdgPopupWithPanel();
|
|
};
|
|
|
|
void TransientPlacementTest::initTestCase()
|
|
{
|
|
qRegisterMetaType<KWin::Window *>();
|
|
QSignalSpy applicationStartedSpy(kwinApp(), &Application::started);
|
|
QVERIFY(applicationStartedSpy.isValid());
|
|
kwinApp()->platform()->setInitialWindowSize(QSize(1280, 1024));
|
|
QVERIFY(waylandServer()->init(s_socketName));
|
|
QMetaObject::invokeMethod(kwinApp()->platform(), "setVirtualOutputs", Qt::DirectConnection, Q_ARG(int, 2));
|
|
|
|
kwinApp()->start();
|
|
QVERIFY(applicationStartedSpy.wait());
|
|
const auto outputs = kwinApp()->platform()->enabledOutputs();
|
|
QCOMPARE(outputs.count(), 2);
|
|
QCOMPARE(outputs[0]->geometry(), QRect(0, 0, 1280, 1024));
|
|
QCOMPARE(outputs[1]->geometry(), QRect(1280, 0, 1280, 1024));
|
|
setenv("QT_QPA_PLATFORM", "wayland", true);
|
|
Test::initWaylandWorkspace();
|
|
}
|
|
|
|
void TransientPlacementTest::init()
|
|
{
|
|
QVERIFY(Test::setupWaylandConnection(Test::AdditionalWaylandInterface::Decoration | Test::AdditionalWaylandInterface::PlasmaShell));
|
|
|
|
workspace()->setActiveOutput(QPoint(640, 512));
|
|
Cursors::self()->mouse()->setPos(QPoint(640, 512));
|
|
}
|
|
|
|
void TransientPlacementTest::cleanup()
|
|
{
|
|
Test::destroyWaylandConnection();
|
|
}
|
|
|
|
void TransientPlacementTest::testXdgPopup_data()
|
|
{
|
|
using namespace KWayland::Client;
|
|
|
|
QTest::addColumn<QSize>("parentSize");
|
|
QTest::addColumn<QPoint>("parentPosition");
|
|
QTest::addColumn<PopupLayout>("layout");
|
|
QTest::addColumn<QRect>("expectedGeometry");
|
|
|
|
// parent window is 500,500, starting at 300,300, anchorRect is therefore between 350->750 in both dirs
|
|
|
|
// ----------------------------------------------------------------
|
|
// window in the middle, plenty of room either side: Changing anchor
|
|
|
|
const PopupLayout layoutAnchorCenter{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_none,
|
|
.gravity = Test::XdgPositioner::gravity_bottom_right,
|
|
};
|
|
QTest::newRow("anchorCentre") << QSize(500, 500) << QPoint(300, 300) << layoutAnchorCenter << QRect(550, 550, 200, 200);
|
|
|
|
const PopupLayout layoutAnchorTopLeft{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_top_left,
|
|
.gravity = Test::XdgPositioner::gravity_bottom_right,
|
|
};
|
|
QTest::newRow("anchorTopLeft") << QSize(500, 500) << QPoint(300, 300) << layoutAnchorTopLeft << QRect(350, 350, 200, 200);
|
|
|
|
const PopupLayout layoutAnchorTop{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_top,
|
|
.gravity = Test::XdgPositioner::gravity_bottom_right,
|
|
};
|
|
QTest::newRow("anchorTop") << QSize(500, 500) << QPoint(300, 300) << layoutAnchorTop << QRect(550, 350, 200, 200);
|
|
|
|
const PopupLayout layoutAnchorTopRight{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_top_right,
|
|
.gravity = Test::XdgPositioner::gravity_bottom_right,
|
|
};
|
|
QTest::newRow("anchorTopRight") << QSize(500, 500) << QPoint(300, 300) << layoutAnchorTopRight << QRect(750, 350, 200, 200);
|
|
|
|
const PopupLayout layoutAnchorRight{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_right,
|
|
.gravity = Test::XdgPositioner::gravity_bottom_right,
|
|
};
|
|
QTest::newRow("anchorRight") << QSize(500, 500) << QPoint(300, 300) << layoutAnchorRight << QRect(750, 550, 200, 200);
|
|
|
|
const PopupLayout layoutAnchorBottomRight{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_bottom_right,
|
|
.gravity = Test::XdgPositioner::gravity_bottom_right,
|
|
};
|
|
QTest::newRow("anchorBottomRight") << QSize(500, 500) << QPoint(300, 300) << layoutAnchorBottomRight << QRect(750, 750, 200, 200);
|
|
|
|
const PopupLayout layoutAnchorBottom{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_bottom,
|
|
.gravity = Test::XdgPositioner::gravity_bottom_right,
|
|
};
|
|
QTest::newRow("anchorBottom") << QSize(500, 500) << QPoint(300, 300) << layoutAnchorBottom << QRect(550, 750, 200, 200);
|
|
|
|
const PopupLayout layoutAnchorBottomLeft{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_bottom_left,
|
|
.gravity = Test::XdgPositioner::gravity_bottom_right,
|
|
};
|
|
QTest::newRow("anchorBottomLeft") << QSize(500, 500) << QPoint(300, 300) << layoutAnchorBottomLeft << QRect(350, 750, 200, 200);
|
|
|
|
const PopupLayout layoutAnchorLeft{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_left,
|
|
.gravity = Test::XdgPositioner::gravity_bottom_right,
|
|
};
|
|
QTest::newRow("anchorLeft") << QSize(500, 500) << QPoint(300, 300) << layoutAnchorLeft << QRect(350, 550, 200, 200);
|
|
|
|
// ----------------------------------------------------------------
|
|
// window in the middle, plenty of room either side: Changing gravity around the bottom right anchor
|
|
|
|
const PopupLayout layoutGravityCenter{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_bottom_right,
|
|
.gravity = Test::XdgPositioner::gravity_none,
|
|
};
|
|
QTest::newRow("gravityCentre") << QSize(500, 500) << QPoint(300, 300) << layoutGravityCenter << QRect(650, 650, 200, 200);
|
|
|
|
const PopupLayout layoutGravityTopLeft{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_bottom_right,
|
|
.gravity = Test::XdgPositioner::gravity_top_left,
|
|
};
|
|
QTest::newRow("gravityTopLeft") << QSize(500, 500) << QPoint(300, 300) << layoutGravityTopLeft << QRect(550, 550, 200, 200);
|
|
|
|
const PopupLayout layoutGravityTop{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_bottom_right,
|
|
.gravity = Test::XdgPositioner::gravity_top,
|
|
};
|
|
QTest::newRow("gravityTop") << QSize(500, 500) << QPoint(300, 300) << layoutGravityTop << QRect(650, 550, 200, 200);
|
|
|
|
const PopupLayout layoutGravityTopRight{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_bottom_right,
|
|
.gravity = Test::XdgPositioner::gravity_top_right,
|
|
};
|
|
QTest::newRow("gravityTopRight") << QSize(500, 500) << QPoint(300, 300) << layoutGravityTopRight << QRect(750, 550, 200, 200);
|
|
|
|
const PopupLayout layoutGravityRight{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_bottom_right,
|
|
.gravity = Test::XdgPositioner::gravity_right,
|
|
};
|
|
QTest::newRow("gravityRight") << QSize(500, 500) << QPoint(300, 300) << layoutGravityRight << QRect(750, 650, 200, 200);
|
|
|
|
const PopupLayout layoutGravityBottomRight{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_bottom_right,
|
|
.gravity = Test::XdgPositioner::gravity_bottom_right,
|
|
};
|
|
QTest::newRow("gravityBottomRight") << QSize(500, 500) << QPoint(300, 300) << layoutGravityBottomRight << QRect(750, 750, 200, 200);
|
|
|
|
const PopupLayout layoutGravityBottom{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_bottom_right,
|
|
.gravity = Test::XdgPositioner::gravity_bottom,
|
|
};
|
|
QTest::newRow("gravityBottom") << QSize(500, 500) << QPoint(300, 300) << layoutGravityBottom << QRect(650, 750, 200, 200);
|
|
|
|
const PopupLayout layoutGravityBottomLeft{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_bottom_right,
|
|
.gravity = Test::XdgPositioner::gravity_bottom_left,
|
|
};
|
|
QTest::newRow("gravityBottomLeft") << QSize(500, 500) << QPoint(300, 300) << layoutGravityBottomLeft << QRect(550, 750, 200, 200);
|
|
|
|
const PopupLayout layoutGravityLeft{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_bottom_right,
|
|
.gravity = Test::XdgPositioner::gravity_left,
|
|
};
|
|
QTest::newRow("gravityLeft") << QSize(500, 500) << QPoint(300, 300) << layoutGravityLeft << QRect(550, 650, 200, 200);
|
|
|
|
// ----------------------------------------------------------------
|
|
// constrain and slide
|
|
// popup is still 200,200. window moved near edge of screen, popup always comes out towards the screen edge
|
|
|
|
const PopupLayout layoutSlideTop{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_top,
|
|
.gravity = Test::XdgPositioner::gravity_top,
|
|
.constraint = Test::XdgPositioner::constraint_adjustment_slide_x | Test::XdgPositioner::constraint_adjustment_slide_y,
|
|
};
|
|
QTest::newRow("constraintSlideTop") << QSize(500, 500) << QPoint(80, 80) << layoutSlideTop << QRect(80 + 250 - 100, 0, 200, 200);
|
|
|
|
const PopupLayout layoutSlideLeft{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_left,
|
|
.gravity = Test::XdgPositioner::gravity_left,
|
|
.constraint = Test::XdgPositioner::constraint_adjustment_slide_x | Test::XdgPositioner::constraint_adjustment_slide_y,
|
|
};
|
|
QTest::newRow("constraintSlideLeft") << QSize(500, 500) << QPoint(80, 80) << layoutSlideLeft << QRect(0, 80 + 250 - 100, 200, 200);
|
|
|
|
const PopupLayout layoutSlideRight{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_right,
|
|
.gravity = Test::XdgPositioner::gravity_right,
|
|
.constraint = Test::XdgPositioner::constraint_adjustment_slide_x | Test::XdgPositioner::constraint_adjustment_slide_y,
|
|
};
|
|
QTest::newRow("constraintSlideRight") << QSize(500, 500) << QPoint(700, 80) << layoutSlideRight << QRect(1280 - 200, 80 + 250 - 100, 200, 200);
|
|
|
|
const PopupLayout layoutSlideBottom{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_bottom,
|
|
.gravity = Test::XdgPositioner::gravity_bottom,
|
|
.constraint = Test::XdgPositioner::constraint_adjustment_slide_x | Test::XdgPositioner::constraint_adjustment_slide_y,
|
|
};
|
|
QTest::newRow("constraintSlideBottom") << QSize(500, 500) << QPoint(80, 500) << layoutSlideBottom << QRect(80 + 250 - 100, 1024 - 200, 200, 200);
|
|
|
|
const PopupLayout layoutSlideBottomRight{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_bottom_right,
|
|
.gravity = Test::XdgPositioner::gravity_bottom_right,
|
|
.constraint = Test::XdgPositioner::constraint_adjustment_slide_x | Test::XdgPositioner::constraint_adjustment_slide_y,
|
|
};
|
|
QTest::newRow("constraintSlideBottomRight") << QSize(500, 500) << QPoint(700, 1000) << layoutSlideBottomRight << QRect(1280 - 200, 1024 - 200, 200, 200);
|
|
|
|
// ----------------------------------------------------------------
|
|
// constrain and flip
|
|
|
|
const PopupLayout layoutFlipTop{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_top,
|
|
.gravity = Test::XdgPositioner::gravity_top,
|
|
.constraint = Test::XdgPositioner::constraint_adjustment_flip_x | Test::XdgPositioner::constraint_adjustment_flip_y,
|
|
};
|
|
QTest::newRow("constraintFlipTop") << QSize(500, 500) << QPoint(80, 80) << layoutFlipTop << QRect(230, 80 + 500 - 50, 200, 200);
|
|
|
|
const PopupLayout layoutFlipLeft{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_left,
|
|
.gravity = Test::XdgPositioner::gravity_left,
|
|
.constraint = Test::XdgPositioner::constraint_adjustment_flip_x | Test::XdgPositioner::constraint_adjustment_flip_y,
|
|
};
|
|
QTest::newRow("constraintFlipLeft") << QSize(500, 500) << QPoint(80, 80) << layoutFlipLeft << QRect(80 + 500 - 50, 230, 200, 200);
|
|
|
|
const PopupLayout layoutFlipRight{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_right,
|
|
.gravity = Test::XdgPositioner::gravity_right,
|
|
.constraint = Test::XdgPositioner::constraint_adjustment_flip_x | Test::XdgPositioner::constraint_adjustment_flip_y,
|
|
};
|
|
QTest::newRow("constraintFlipRight") << QSize(500, 500) << QPoint(700, 80) << layoutFlipRight << QRect(700 + 50 - 200, 230, 200, 200);
|
|
|
|
const PopupLayout layoutFlipBottom{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_bottom,
|
|
.gravity = Test::XdgPositioner::gravity_bottom,
|
|
.constraint = Test::XdgPositioner::constraint_adjustment_flip_x | Test::XdgPositioner::constraint_adjustment_flip_y,
|
|
};
|
|
QTest::newRow("constraintFlipBottom") << QSize(500, 500) << QPoint(80, 500) << layoutFlipBottom << QRect(230, 500 + 50 - 200, 200, 200);
|
|
|
|
const PopupLayout layoutFlipBottomRight{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_bottom_right,
|
|
.gravity = Test::XdgPositioner::gravity_bottom_right,
|
|
.constraint = Test::XdgPositioner::constraint_adjustment_flip_x | Test::XdgPositioner::constraint_adjustment_flip_y,
|
|
};
|
|
QTest::newRow("constraintFlipBottomRight") << QSize(500, 500) << QPoint(700, 500) << layoutFlipBottomRight << QRect(700 + 50 - 200, 500 + 50 - 200, 200, 200);
|
|
|
|
const PopupLayout layoutFlipRightNoAnchor{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
// as popup is positioned in the middle of the parent we need a massive popup to be able to overflow
|
|
.size = QSize(400, 400),
|
|
.anchor = Test::XdgPositioner::anchor_top,
|
|
.gravity = Test::XdgPositioner::gravity_right,
|
|
.constraint = Test::XdgPositioner::constraint_adjustment_flip_x | Test::XdgPositioner::constraint_adjustment_flip_y,
|
|
};
|
|
QTest::newRow("constraintFlipRightNoAnchor") << QSize(500, 500) << QPoint(700, 80) << layoutFlipRightNoAnchor << QRect(700 + 250 - 400, 330, 400, 400);
|
|
|
|
const PopupLayout layoutFlipRightNoGravity{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(300, 200),
|
|
.anchor = Test::XdgPositioner::anchor_right,
|
|
.gravity = Test::XdgPositioner::gravity_top,
|
|
.constraint = Test::XdgPositioner::constraint_adjustment_flip_x | Test::XdgPositioner::constraint_adjustment_flip_y,
|
|
};
|
|
QTest::newRow("constraintFlipRightNoGravity") << QSize(500, 500) << QPoint(700, 80) << layoutFlipRightNoGravity << QRect(700 + 50 - 150, 130, 300, 200);
|
|
|
|
// ----------------------------------------------------------------
|
|
// resize
|
|
|
|
const PopupLayout layoutResizeTop{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_top,
|
|
.gravity = Test::XdgPositioner::gravity_top,
|
|
.constraint = Test::XdgPositioner::constraint_adjustment_resize_x | Test::XdgPositioner::constraint_adjustment_resize_y,
|
|
};
|
|
QTest::newRow("resizeTop") << QSize(500, 500) << QPoint(80, 80) << layoutResizeTop << QRect(80 + 250 - 100, 0, 200, 130);
|
|
|
|
const PopupLayout layoutResizeLeft{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_left,
|
|
.gravity = Test::XdgPositioner::gravity_left,
|
|
.constraint = Test::XdgPositioner::constraint_adjustment_resize_x | Test::XdgPositioner::constraint_adjustment_resize_y,
|
|
};
|
|
QTest::newRow("resizeLeft") << QSize(500, 500) << QPoint(80, 80) << layoutResizeLeft << QRect(0, 80 + 250 - 100, 130, 200);
|
|
|
|
const PopupLayout layoutResizeRight{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_right,
|
|
.gravity = Test::XdgPositioner::gravity_right,
|
|
.constraint = Test::XdgPositioner::constraint_adjustment_resize_x | Test::XdgPositioner::constraint_adjustment_resize_y,
|
|
};
|
|
QTest::newRow("resizeRight") << QSize(500, 500) << QPoint(700, 80) << layoutResizeRight << QRect(700 + 50 + 400, 80 + 250 - 100, 130, 200);
|
|
|
|
const PopupLayout layoutResizeBottom{
|
|
.anchorRect = QRect(50, 50, 400, 400),
|
|
.size = QSize(200, 200),
|
|
.anchor = Test::XdgPositioner::anchor_bottom,
|
|
.gravity = Test::XdgPositioner::gravity_bottom,
|
|
.constraint = Test::XdgPositioner::constraint_adjustment_resize_x | Test::XdgPositioner::constraint_adjustment_resize_y,
|
|
};
|
|
QTest::newRow("resizeBottom") << QSize(500, 500) << QPoint(80, 500) << layoutResizeBottom << QRect(80 + 250 - 100, 500 + 50 + 400, 200, 74);
|
|
}
|
|
|
|
void TransientPlacementTest::testXdgPopup()
|
|
{
|
|
using namespace KWayland::Client;
|
|
|
|
// this test verifies that the position of a transient window is taken from the passed position
|
|
// there are no further constraints like window too large to fit screen, cascading transients, etc
|
|
// some test cases also verify that the transient fits on the screen
|
|
QFETCH(QSize, parentSize);
|
|
QFETCH(QPoint, parentPosition);
|
|
QFETCH(QRect, expectedGeometry);
|
|
const QRect expectedRelativeGeometry = expectedGeometry.translated(-parentPosition);
|
|
|
|
KWayland::Client::Surface *surface = Test::createSurface(Test::waylandCompositor());
|
|
QVERIFY(surface);
|
|
auto parentShellSurface = Test::createXdgToplevelSurface(surface, Test::waylandCompositor());
|
|
QVERIFY(parentShellSurface);
|
|
auto parent = Test::renderAndWaitForShown(surface, parentSize, Qt::blue);
|
|
QVERIFY(parent);
|
|
|
|
QVERIFY(!parent->isDecorated());
|
|
parent->move(parentPosition);
|
|
QCOMPARE(parent->frameGeometry(), QRect(parentPosition, parentSize));
|
|
|
|
// create popup
|
|
QFETCH(PopupLayout, layout);
|
|
|
|
KWayland::Client::Surface *transientSurface = Test::createSurface(Test::waylandCompositor());
|
|
QVERIFY(transientSurface);
|
|
|
|
QScopedPointer<Test::XdgPositioner> positioner(Test::createXdgPositioner());
|
|
positioner->set_anchor_rect(layout.anchorRect.x(), layout.anchorRect.y(), layout.anchorRect.width(), layout.anchorRect.height());
|
|
positioner->set_size(layout.size.width(), layout.size.height());
|
|
positioner->set_anchor(layout.anchor);
|
|
positioner->set_gravity(layout.gravity);
|
|
positioner->set_constraint_adjustment(layout.constraint);
|
|
QScopedPointer<Test::XdgPopup> popup(Test::createXdgPopupSurface(transientSurface, parentShellSurface->xdgSurface(), positioner.data(), Test::CreationSetup::CreateOnly));
|
|
QSignalSpy popupConfigureRequestedSpy(popup.data(), &Test::XdgPopup::configureRequested);
|
|
QSignalSpy surfaceConfigureRequestedSpy(popup->xdgSurface(), &Test::XdgSurface::configureRequested);
|
|
transientSurface->commit(KWayland::Client::Surface::CommitFlag::None);
|
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
|
QCOMPARE(surfaceConfigureRequestedSpy.count(), 1);
|
|
QCOMPARE(popupConfigureRequestedSpy.last()[0].value<QRect>(), expectedRelativeGeometry);
|
|
popup->xdgSurface()->ack_configure(surfaceConfigureRequestedSpy.last()[0].toUInt());
|
|
|
|
auto transient = Test::renderAndWaitForShown(transientSurface, expectedRelativeGeometry.size(), Qt::red);
|
|
QVERIFY(transient);
|
|
|
|
QVERIFY(!transient->isDecorated());
|
|
QVERIFY(transient->hasTransientPlacementHint());
|
|
QCOMPARE(transient->frameGeometry(), expectedGeometry);
|
|
|
|
QCOMPARE(surfaceConfigureRequestedSpy.count(), 1); // check that we did not get reconfigured
|
|
}
|
|
|
|
void TransientPlacementTest::testXdgPopupWithPanel()
|
|
{
|
|
using namespace KWayland::Client;
|
|
|
|
const Output *output = workspace()->activeOutput();
|
|
|
|
QScopedPointer<KWayland::Client::Surface> surface{Test::createSurface()};
|
|
QVERIFY(!surface.isNull());
|
|
QScopedPointer<Test::XdgToplevel> dockShellSurface{Test::createXdgToplevelSurface(surface.data())};
|
|
QVERIFY(!dockShellSurface.isNull());
|
|
QScopedPointer<PlasmaShellSurface> plasmaSurface(Test::waylandPlasmaShell()->createSurface(surface.data()));
|
|
QVERIFY(!plasmaSurface.isNull());
|
|
plasmaSurface->setRole(PlasmaShellSurface::Role::Panel);
|
|
plasmaSurface->setPosition(QPoint(0, output->geometry().height() - 50));
|
|
plasmaSurface->setPanelBehavior(PlasmaShellSurface::PanelBehavior::AlwaysVisible);
|
|
|
|
// now render and map the window
|
|
auto dock = Test::renderAndWaitForShown(surface.data(), QSize(1280, 50), Qt::blue);
|
|
QVERIFY(dock);
|
|
QCOMPARE(dock->windowType(), NET::Dock);
|
|
QVERIFY(dock->isDock());
|
|
QCOMPARE(dock->frameGeometry(), QRect(0, output->geometry().height() - 50, 1280, 50));
|
|
QCOMPARE(dock->hasStrut(), true);
|
|
QCOMPARE(workspace()->clientArea(PlacementArea, dock), QRect(0, 0, 1280, 1024 - 50));
|
|
QCOMPARE(workspace()->clientArea(FullScreenArea, dock), QRect(0, 0, 1280, 1024));
|
|
|
|
// create parent
|
|
QScopedPointer<KWayland::Client::Surface> parentSurface(Test::createSurface());
|
|
QVERIFY(parentSurface);
|
|
auto parentShellSurface = Test::createXdgToplevelSurface(parentSurface.data());
|
|
QVERIFY(parentShellSurface);
|
|
auto parent = Test::renderAndWaitForShown(parentSurface.data(), {800, 600}, Qt::blue);
|
|
QVERIFY(parent);
|
|
|
|
QVERIFY(!parent->isDecorated());
|
|
parent->move(QPointF(0, output->geometry().height() - 600));
|
|
parent->keepInArea(workspace()->clientArea(PlacementArea, parent));
|
|
QCOMPARE(parent->frameGeometry(), QRect(0, output->geometry().height() - 600 - 50, 800, 600));
|
|
|
|
QScopedPointer<KWayland::Client::Surface> transientSurface(Test::createSurface());
|
|
QVERIFY(transientSurface);
|
|
|
|
QScopedPointer<Test::XdgPositioner> positioner(Test::createXdgPositioner());
|
|
positioner->set_size(200, 200);
|
|
positioner->set_anchor_rect(50, 500, 200, 200);
|
|
|
|
QScopedPointer<Test::XdgPopup> transientShellSurface(Test::createXdgPopupSurface(transientSurface.data(), parentShellSurface->xdgSurface(), positioner.data()));
|
|
auto transient = Test::renderAndWaitForShown(transientSurface.data(), QSize(200, 200), Qt::red);
|
|
QVERIFY(transient);
|
|
|
|
QVERIFY(!transient->isDecorated());
|
|
QVERIFY(transient->hasTransientPlacementHint());
|
|
|
|
QCOMPARE(transient->frameGeometry(), QRect(50, output->geometry().height() - 200 - 50, 200, 200));
|
|
|
|
transientShellSurface.reset();
|
|
transientSurface.reset();
|
|
QVERIFY(Test::waitForWindowDestroyed(transient));
|
|
|
|
// now parent to fullscreen - on fullscreen the panel is ignored
|
|
QSignalSpy toplevelConfigureRequestedSpy(parentShellSurface, &Test::XdgToplevel::configureRequested);
|
|
QSignalSpy surfaceConfigureRequestedSpy(parentShellSurface->xdgSurface(), &Test::XdgSurface::configureRequested);
|
|
parent->setFullScreen(true);
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
|
parentShellSurface->xdgSurface()->ack_configure(surfaceConfigureRequestedSpy.last().at(0).value<quint32>());
|
|
QSignalSpy frameGeometryChangedSpy{parent, &Window::frameGeometryChanged};
|
|
QVERIFY(frameGeometryChangedSpy.isValid());
|
|
Test::render(parentSurface.data(), toplevelConfigureRequestedSpy.last().at(0).toSize(), Qt::red);
|
|
QVERIFY(frameGeometryChangedSpy.wait());
|
|
QCOMPARE(parent->frameGeometry(), output->geometry());
|
|
QVERIFY(parent->isFullScreen());
|
|
|
|
// another transient, with same hints as before from bottom of window
|
|
transientSurface.reset(Test::createSurface());
|
|
QVERIFY(transientSurface);
|
|
|
|
const QRect anchorRect2(50, output->geometry().height() - 100, 200, 200);
|
|
QScopedPointer<Test::XdgPositioner> positioner2(Test::createXdgPositioner());
|
|
positioner2->set_size(200, 200);
|
|
positioner2->set_anchor_rect(anchorRect2.x(), anchorRect2.y(), anchorRect2.width(), anchorRect2.height());
|
|
transientShellSurface.reset(Test::createXdgPopupSurface(transientSurface.data(), parentShellSurface->xdgSurface(), positioner2.data()));
|
|
transient = Test::renderAndWaitForShown(transientSurface.data(), QSize(200, 200), Qt::red);
|
|
QVERIFY(transient);
|
|
|
|
QVERIFY(!transient->isDecorated());
|
|
QVERIFY(transient->hasTransientPlacementHint());
|
|
|
|
QCOMPARE(transient->frameGeometry(), QRect(50, output->geometry().height() - 200, 200, 200));
|
|
}
|
|
|
|
}
|
|
|
|
WAYLANDTEST_MAIN(KWin::TransientPlacementTest)
|
|
#include "transient_placement.moc"
|