7fffe99328
Due to being a compositor, kwin has to conform to some certain interfaces. It means a lot of virtual functions and function tables to integrate with C APIs. Naturally, we not always want to use every argument in such functions. Since we get -Wunused-parameter from -Wall, we have to plumb those unused arguments in order to suppress compiler warnings at the moment. However, I don't think that extra work is worth it. We cannot change or alter prototypes in any way to fix the warning the desired way. Q_UNUSED and similar macros are not good indicators of whether an argument is used too, we tend to overlook putting or removing those macros. I've also noticed that Q_UNUSED are not used to guide us with the removal no longer needed parameters. Therefore, I think it's worth adding -Wno-unused-parameter compiler option to stop the compiler producing warnings about unused parameters. It changes nothing except that we don't need to put Q_UNUSED anymore, which can be really cumbersome sometimes. Note that it doesn't affect unused variables, you'll still get a -Wunused-variable compiler warning if a variable is unused.
95 lines
2.9 KiB
C++
95 lines
2.9 KiB
C++
/*
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
SPDX-FileCopyrightText: 2016, 2017 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
SPDX-License-Identifier: GPL-2.0-or-later
|
|
*/
|
|
#include "modifier_only_shortcuts.h"
|
|
|
|
#include <config-kwin.h>
|
|
|
|
#include "input_event.h"
|
|
#include "options.h"
|
|
#if KWIN_BUILD_SCREENLOCKER
|
|
#include "screenlockerwatcher.h"
|
|
#endif
|
|
#include "wayland_server.h"
|
|
#include "workspace.h"
|
|
|
|
#include <QDBusConnection>
|
|
#include <QDBusMessage>
|
|
#include <QDBusPendingCall>
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
ModifierOnlyShortcuts::ModifierOnlyShortcuts()
|
|
: QObject()
|
|
, InputEventSpy()
|
|
{
|
|
#if KWIN_BUILD_SCREENLOCKER
|
|
connect(kwinApp()->screenLockerWatcher(), &ScreenLockerWatcher::locked, this, &ModifierOnlyShortcuts::reset);
|
|
#endif
|
|
}
|
|
|
|
ModifierOnlyShortcuts::~ModifierOnlyShortcuts() = default;
|
|
|
|
void ModifierOnlyShortcuts::keyEvent(KeyEvent *event)
|
|
{
|
|
if (event->isAutoRepeat()) {
|
|
return;
|
|
}
|
|
if (event->type() == QEvent::KeyPress) {
|
|
const bool wasEmpty = m_pressedKeys.isEmpty();
|
|
m_pressedKeys.insert(event->nativeScanCode());
|
|
if (wasEmpty && m_pressedKeys.size() == 1 &&
|
|
#if KWIN_BUILD_SCREENLOCKER
|
|
!kwinApp()->screenLockerWatcher()->isLocked() &&
|
|
#endif
|
|
m_pressedButtons == Qt::NoButton && m_cachedMods == Qt::NoModifier) {
|
|
m_modifier = Qt::KeyboardModifier(int(event->modifiersRelevantForGlobalShortcuts()));
|
|
} else {
|
|
m_modifier = Qt::NoModifier;
|
|
}
|
|
} else if (!m_pressedKeys.isEmpty()) {
|
|
m_pressedKeys.remove(event->nativeScanCode());
|
|
if (m_pressedKeys.isEmpty() && event->modifiersRelevantForGlobalShortcuts() == Qt::NoModifier && workspace() && !workspace()->globalShortcutsDisabled()) {
|
|
if (m_modifier != Qt::NoModifier) {
|
|
const auto list = options->modifierOnlyDBusShortcut(m_modifier);
|
|
if (list.size() >= 4) {
|
|
if (!waylandServer() || !waylandServer()->isKeyboardShortcutsInhibited()) {
|
|
auto call = QDBusMessage::createMethodCall(list.at(0), list.at(1), list.at(2), list.at(3));
|
|
QVariantList args;
|
|
for (int i = 4; i < list.size(); ++i) {
|
|
args << list.at(i);
|
|
}
|
|
call.setArguments(args);
|
|
QDBusConnection::sessionBus().asyncCall(call);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
m_modifier = Qt::NoModifier;
|
|
} else {
|
|
m_modifier = Qt::NoModifier;
|
|
}
|
|
m_cachedMods = event->modifiersRelevantForGlobalShortcuts();
|
|
}
|
|
|
|
void ModifierOnlyShortcuts::pointerEvent(MouseEvent *event)
|
|
{
|
|
if (event->type() == QEvent::MouseMove) {
|
|
return;
|
|
}
|
|
m_pressedButtons = event->buttons();
|
|
reset();
|
|
}
|
|
|
|
void ModifierOnlyShortcuts::wheelEvent(WheelEvent *event)
|
|
{
|
|
reset();
|
|
}
|
|
|
|
}
|