8af2fa73dc
Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371
99 lines
3.2 KiB
C++
99 lines
3.2 KiB
C++
/********************************************************************
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
Copyright (C) 2012 Filip Wieladek <wattos@gmail.com>
|
|
Copyright (C) 2016 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*********************************************************************/
|
|
|
|
#ifndef KWIN_TOUCHPOINTS_H
|
|
#define KWIN_TOUCHPOINTS_H
|
|
|
|
#include <kwineffects.h>
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
class TouchPointsEffect
|
|
: public Effect
|
|
{
|
|
Q_OBJECT
|
|
Q_PROPERTY(qreal lineWidth READ lineWidth)
|
|
Q_PROPERTY(int ringLife READ ringLife)
|
|
Q_PROPERTY(int ringSize READ ringSize)
|
|
Q_PROPERTY(int ringCount READ ringCount)
|
|
public:
|
|
TouchPointsEffect();
|
|
~TouchPointsEffect() override;
|
|
void prePaintScreen(ScreenPrePaintData& data, int time) override;
|
|
void paintScreen(int mask, QRegion region, ScreenPaintData& data) override;
|
|
void postPaintScreen() override;
|
|
bool isActive() const override;
|
|
bool touchDown(quint32 id, const QPointF &pos, quint32 time) override;
|
|
bool touchMotion(quint32 id, const QPointF &pos, quint32 time) override;
|
|
bool touchUp(quint32 id, quint32 time) override;
|
|
|
|
// for properties
|
|
qreal lineWidth() const {
|
|
return m_lineWidth;
|
|
}
|
|
int ringLife() const {
|
|
return m_ringLife;
|
|
}
|
|
int ringSize() const {
|
|
return m_ringMaxSize;
|
|
}
|
|
int ringCount() const {
|
|
return m_ringCount;
|
|
}
|
|
|
|
private:
|
|
inline void drawCircle(const QColor& color, float cx, float cy, float r);
|
|
inline void paintScreenSetup(int mask, QRegion region, ScreenPaintData& data);
|
|
inline void paintScreenFinish(int mask, QRegion region, ScreenPaintData& data);
|
|
|
|
void repaint();
|
|
|
|
float computeAlpha(int time, int ring);
|
|
float computeRadius(int time, bool press, int ring);
|
|
void drawCircleGl(const QColor& color, float cx, float cy, float r);
|
|
void drawCircleXr(const QColor& color, float cx, float cy, float r);
|
|
void drawCircleQPainter(const QColor& color, float cx, float cy, float r);
|
|
void paintScreenSetupGl(int mask, QRegion region, ScreenPaintData& data);
|
|
void paintScreenFinishGl(int mask, QRegion region, ScreenPaintData& data);
|
|
|
|
Qt::GlobalColor colorForId(quint32 id);
|
|
|
|
int m_ringCount = 2;
|
|
float m_lineWidth = 1.0;
|
|
int m_ringLife = 300;
|
|
float m_ringMaxSize = 20.0;
|
|
|
|
struct TouchPoint {
|
|
QPointF pos;
|
|
int time = 0;
|
|
bool press;
|
|
QColor color;
|
|
};
|
|
QVector<TouchPoint> m_points;
|
|
QHash<quint32, QPointF> m_latestPositions;
|
|
QHash<quint32, Qt::GlobalColor> m_colors;
|
|
|
|
};
|
|
|
|
} // namespace
|
|
|
|
#endif
|