kwin/outline.h
Vlad Zagorodniy 8af2fa73dc Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.

The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.

Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.

A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!

The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.

The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.

Test Plan: Compiles.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: davidedmundson, apol, romangg, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 20:03:22 +03:00

194 lines
5.1 KiB
C++

/********************************************************************
KWin - the KDE window manager
This file is part of the KDE project.
Copyright (C) 2011 Arthur Arlt <a.arlt@stud.uni-heidelberg.de>
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*********************************************************************/
#ifndef KWIN_OUTLINE_H
#define KWIN_OUTLINE_H
#include <kwinglobals.h>
#include <QRect>
#include <QObject>
#include <kwin_export.h>
class QQmlContext;
class QQmlComponent;
namespace KWin {
class OutlineVisual;
/**
* @short This class is used to show the outline of a given geometry.
*
* The class renders an outline by using four windows. One for each border of
* the geometry. It is possible to replace the outline with an effect. If an
* effect is available the effect will be used, otherwise the outline will be
* rendered by using the X implementation.
*
* @author Arthur Arlt
* @since 4.7
**/
class Outline : public QObject {
Q_OBJECT
Q_PROPERTY(QRect geometry READ geometry NOTIFY geometryChanged)
Q_PROPERTY(QRect visualParentGeometry READ visualParentGeometry NOTIFY visualParentGeometryChanged)
Q_PROPERTY(QRect unifiedGeometry READ unifiedGeometry NOTIFY unifiedGeometryChanged)
Q_PROPERTY(bool active READ isActive NOTIFY activeChanged)
public:
~Outline() override;
/**
* Set the outline geometry.
* To show the outline use showOutline.
* @param outlineGeometry The geometry of the outline to be shown
* @see showOutline
**/
void setGeometry(const QRect &outlineGeometry);
/**
* Set the visual parent geometry.
* This is the geometry from which the will emerge.
* @param visualParentGeometry The visual geometry of the visual parent
* @see showOutline
**/
void setVisualParentGeometry(const QRect &visualParentGeometry);
/**
* Shows the outline of a window using either an effect or the X implementation.
* To stop the outline process use hideOutline.
* @see hideOutline
**/
void show();
/**
* Shows the outline for the given @p outlineGeometry.
* This is the same as setOutlineGeometry followed by showOutline directly.
* To stop the outline process use hideOutline.
* @param outlineGeometry The geometry of the outline to be shown
* @see hideOutline
**/
void show(const QRect &outlineGeometry);
/**
* Shows the outline for the given @p outlineGeometry animated from @p visualParentGeometry.
* This is the same as setOutlineGeometry followed by setVisualParentGeometry
* and then showOutline.
* To stop the outline process use hideOutline.
* @param outlineGeometry The geometry of the outline to be shown
* @param visualParentGeometry The geometry from where the outline should emerge
* @see hideOutline
* @since 5.10
**/
void show(const QRect &outlineGeometry, const QRect &visualParentGeometry);
/**
* Hides shown outline.
* @see showOutline
**/
void hide();
const QRect &geometry() const;
const QRect &visualParentGeometry() const;
QRect unifiedGeometry() const;
bool isActive() const;
private Q_SLOTS:
void compositingChanged();
Q_SIGNALS:
void activeChanged();
void geometryChanged();
void unifiedGeometryChanged();
void visualParentGeometryChanged();
private:
void createHelper();
QScopedPointer<OutlineVisual> m_visual;
QRect m_outlineGeometry;
QRect m_visualParentGeometry;
bool m_active;
KWIN_SINGLETON(Outline)
};
class KWIN_EXPORT OutlineVisual
{
public:
OutlineVisual(Outline *outline);
virtual ~OutlineVisual();
virtual void show() = 0;
virtual void hide() = 0;
protected:
Outline *outline();
const Outline *outline() const;
private:
Outline *m_outline;
};
class CompositedOutlineVisual : public OutlineVisual
{
public:
CompositedOutlineVisual(Outline *outline);
~CompositedOutlineVisual() override;
void show() override;
void hide() override;
private:
QScopedPointer<QQmlContext> m_qmlContext;
QScopedPointer<QQmlComponent> m_qmlComponent;
QScopedPointer<QObject> m_mainItem;
};
inline
bool Outline::isActive() const
{
return m_active;
}
inline
const QRect &Outline::geometry() const
{
return m_outlineGeometry;
}
inline
const QRect &Outline::visualParentGeometry() const
{
return m_visualParentGeometry;
}
inline
Outline *OutlineVisual::outline()
{
return m_outline;
}
inline
const Outline *OutlineVisual::outline() const
{
return m_outline;
}
inline
Outline *outline()
{
return Outline::self();
}
}
#endif