8af2fa73dc
Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371
118 lines
3.2 KiB
C++
118 lines
3.2 KiB
C++
/********************************************************************
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
Copyright (C) 2013 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*********************************************************************/
|
|
#ifndef KWIN_TABBOX_SWITCHERITEM_H
|
|
#define KWIN_TABBOX_SWITCHERITEM_H
|
|
|
|
#include <QObject>
|
|
#include <QRect>
|
|
|
|
class QAbstractItemModel;
|
|
|
|
namespace KWin
|
|
{
|
|
namespace TabBox
|
|
{
|
|
|
|
class SwitcherItem : public QObject
|
|
{
|
|
Q_OBJECT
|
|
Q_PROPERTY(QAbstractItemModel *model READ model NOTIFY modelChanged)
|
|
Q_PROPERTY(QRect screenGeometry READ screenGeometry NOTIFY screenGeometryChanged)
|
|
Q_PROPERTY(bool visible READ isVisible NOTIFY visibleChanged)
|
|
Q_PROPERTY(bool allDesktops READ isAllDesktops NOTIFY allDesktopsChanged)
|
|
Q_PROPERTY(int currentIndex READ currentIndex WRITE setCurrentIndex NOTIFY currentIndexChanged)
|
|
Q_PROPERTY(bool noModifierGrab READ noModifierGrab NOTIFY noModifierGrabChanged)
|
|
|
|
/**
|
|
* The main QML item that will be displayed in the Dialog
|
|
**/
|
|
Q_PROPERTY(QObject *item READ item WRITE setItem NOTIFY itemChanged)
|
|
|
|
Q_CLASSINFO("DefaultProperty", "item")
|
|
public:
|
|
SwitcherItem(QObject *parent = nullptr);
|
|
~SwitcherItem() override;
|
|
|
|
QAbstractItemModel *model() const;
|
|
QRect screenGeometry() const;
|
|
bool isVisible() const;
|
|
bool isAllDesktops() const;
|
|
int currentIndex() const;
|
|
void setCurrentIndex(int index);
|
|
QObject *item() const;
|
|
void setItem(QObject *item);
|
|
bool noModifierGrab() const {
|
|
return m_noModifierGrab;
|
|
}
|
|
|
|
// for usage from outside
|
|
void setModel(QAbstractItemModel *model);
|
|
void setAllDesktops(bool all);
|
|
void setVisible(bool visible);
|
|
void setNoModifierGrab(bool set);
|
|
|
|
Q_SIGNALS:
|
|
void visibleChanged();
|
|
void currentIndexChanged(int index);
|
|
void modelChanged();
|
|
void allDesktopsChanged();
|
|
void screenGeometryChanged();
|
|
void itemChanged();
|
|
void noModifierGrabChanged();
|
|
|
|
private:
|
|
QAbstractItemModel *m_model;
|
|
QObject *m_item;
|
|
bool m_visible;
|
|
bool m_allDesktops;
|
|
int m_currentIndex;
|
|
QMetaObject::Connection m_selectedIndexConnection;
|
|
bool m_noModifierGrab = false;
|
|
};
|
|
|
|
inline QAbstractItemModel *SwitcherItem::model() const
|
|
{
|
|
return m_model;
|
|
}
|
|
|
|
inline bool SwitcherItem::isVisible() const
|
|
{
|
|
return m_visible;
|
|
}
|
|
|
|
inline bool SwitcherItem::isAllDesktops() const
|
|
{
|
|
return m_allDesktops;
|
|
}
|
|
|
|
inline int SwitcherItem::currentIndex() const
|
|
{
|
|
return m_currentIndex;
|
|
}
|
|
|
|
inline QObject *SwitcherItem::item() const
|
|
{
|
|
return m_item;
|
|
}
|
|
|
|
} // TabBox
|
|
} // KWin
|
|
|
|
#endif // KWIN_TABBOX_SWITCHERITEM_H
|