8b9472e0bf
When the user selects all of the types or none of them, the "types" property must be set to a special value (`NET::AllTypesMask = -1`), different than the sum of all the flags together. This re-implements this behaviour as the old KCM, fixing some heuristics that prevented finding the rule corresponding to the current window. The enum name that handles this property has been changed to `NetTypes` to make it more explicit. BUG: 423214 FIXED-IN: 5.19.3 TEST PLAN: 1. Open the `Application specific settings` on a window via menu 2. Select every "Window Type" (or none of them) 3. Give the rule a different name than the default and save 4. Open it again and check that the same rule is found
128 lines
3.2 KiB
C++
128 lines
3.2 KiB
C++
/*
|
|
* Copyright (c) 2020 Ismael Asensio <isma.af@gmail.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation; either version 2 of
|
|
* the License or (at your option) version 3 or any later version
|
|
* accepted by the membership of KDE e.V. (or its successor approved
|
|
* by the membership of KDE e.V.), which shall act as a proxy
|
|
* defined in Section 14 of version 3 of the license.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef KWIN_RULEITEM_H
|
|
#define KWIN_RULEITEM_H
|
|
|
|
#include "optionsmodel.h"
|
|
|
|
#include <QFlag>
|
|
#include <QIcon>
|
|
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
class RuleItem : public QObject
|
|
{
|
|
Q_OBJECT
|
|
|
|
public:
|
|
enum Type {
|
|
Undefined,
|
|
Boolean,
|
|
String,
|
|
Integer,
|
|
Option,
|
|
NetTypes,
|
|
Percentage,
|
|
Point,
|
|
Size,
|
|
Shortcut
|
|
};
|
|
Q_ENUM(Type)
|
|
|
|
enum Flags {
|
|
NoFlags = 0,
|
|
AlwaysEnabled = 1u << 0,
|
|
StartEnabled = 1u << 1,
|
|
AffectsWarning = 1u << 2,
|
|
AffectsDescription = 1u << 3,
|
|
AllFlags = 0b1111
|
|
};
|
|
|
|
public:
|
|
RuleItem() {};
|
|
RuleItem(const QString &key,
|
|
const RulePolicy::Type policyType,
|
|
const Type type,
|
|
const QString &name,
|
|
const QString §ion,
|
|
const QIcon &icon = QIcon::fromTheme("window"),
|
|
const QString &description = QString("")
|
|
);
|
|
~RuleItem();
|
|
|
|
QString key() const;
|
|
QString name() const;
|
|
QString section() const;
|
|
QIcon icon() const;
|
|
QString iconName() const;
|
|
QString description() const;
|
|
|
|
bool isEnabled() const;
|
|
void setEnabled(bool enabled);
|
|
|
|
bool hasFlag(RuleItem::Flags flag) const;
|
|
void setFlag(RuleItem::Flags flag, bool active=true);
|
|
|
|
Type type() const;
|
|
QVariant value() const;
|
|
void setValue(QVariant value);
|
|
QVariant suggestedValue() const;
|
|
void setSuggestedValue(QVariant value, bool forceValue = false);
|
|
|
|
QVariant options() const;
|
|
void setOptionsData(const QList<OptionsModel::Data> &data);
|
|
|
|
RulePolicy::Type policyType() const;
|
|
int policy() const; // int belongs to anonymous enum in Rules::
|
|
void setPolicy(int policy); // int belongs to anonymous enum in Rules::
|
|
QVariant policyModel() const;
|
|
QString policyKey() const;
|
|
|
|
|
|
|
|
void reset();
|
|
|
|
private:
|
|
static QVariant typedValue(const QVariant &value, const Type type);
|
|
|
|
private:
|
|
QString m_key;
|
|
RuleItem::Type m_type;
|
|
QString m_name;
|
|
QString m_section;
|
|
QIcon m_icon;
|
|
QString m_description;
|
|
QFlags<Flags> m_flags;
|
|
|
|
bool m_enabled;
|
|
|
|
QVariant m_value;
|
|
QVariant m_suggestedValue;
|
|
|
|
RulePolicy *m_policy;
|
|
OptionsModel *m_options;
|
|
};
|
|
|
|
} //namespace
|
|
|
|
#endif //KWIN_RULEITEM_H
|