kwin/src/wayland/compositor_interface.cpp
Martin Gräßlin f4f2725132 [server] Improve the handling when clients disconnect
Summary:
So far the server component performed manual cleanup in some cases
when a client disconnects. But this is not needed: the Wayland library
calls the static unbind methods which do cleanup. If we cleanup ourselves
this can result in double deletes in the worst case, so let's only use
the Wayland functionality.

Adjusted:
* RegionInterface
* SurfaceInterface
* ShellSurfaceInterface (doesn't take a parent anymore)
* DpmsInterface
* QtSurfaceExtensionInterface
* KeyboardInterface
* PointerInterface
* TouchInterface
* DataOfferInterface
* PlasmaShellSurfaceInterface

For each adjusted case a test case is added to verify that the cleanup
works. Exceptions are DpmsInterface as the actual Resource is not exposed
at all in the Server component and DataOfferInterface as that is server
side created.

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D1640
2016-05-19 16:21:27 +02:00

129 lines
4.3 KiB
C++

/********************************************************************
Copyright 2014 Martin Gräßlin <mgraesslin@kde.org>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) version 3, or any
later version accepted by the membership of KDE e.V. (or its
successor approved by the membership of KDE e.V.), which shall
act as a proxy defined in Section 6 of version 3 of the license.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with this library. If not, see <http://www.gnu.org/licenses/>.
*********************************************************************/
#include "compositor_interface.h"
#include "display.h"
#include "global_p.h"
#include "surface_interface.h"
// Wayland
#include <wayland-server.h>
namespace KWayland
{
namespace Server
{
class CompositorInterface::Private : public Global::Private
{
public:
Private(CompositorInterface *q, Display *d);
private:
void bind(wl_client *client, uint32_t version, uint32_t id) override;
void createSurface(wl_client *client, wl_resource *resource, uint32_t id);
void createRegion(wl_client *client, wl_resource *resource, uint32_t id);
static void unbind(wl_resource *resource);
static void createSurfaceCallback(wl_client *client, wl_resource *resource, uint32_t id);
static void createRegionCallback(wl_client *client, wl_resource *resource, uint32_t id);
static Private *cast(wl_resource *r) {
return reinterpret_cast<Private*>(wl_resource_get_user_data(r));
}
CompositorInterface *q;
static const struct wl_compositor_interface s_interface;
static const quint32 s_version;
};
const quint32 CompositorInterface::Private::s_version = 3;
CompositorInterface::Private::Private(CompositorInterface *q, Display *d)
: Global::Private(d, &wl_compositor_interface, s_version)
, q(q)
{
}
#ifndef DOXYGEN_SHOULD_SKIP_THIS
const struct wl_compositor_interface CompositorInterface::Private::s_interface = {
createSurfaceCallback,
createRegionCallback
};
#endif
CompositorInterface::CompositorInterface(Display *display, QObject *parent)
: Global(new Private(this, display), parent)
{
}
CompositorInterface::~CompositorInterface() = default;
void CompositorInterface::Private::bind(wl_client *client, uint32_t version, uint32_t id)
{
auto c = display->getConnection(client);
wl_resource *resource = c->createResource(&wl_compositor_interface, qMin(version, s_version), id);
if (!resource) {
wl_client_post_no_memory(client);
return;
}
wl_resource_set_implementation(resource, &s_interface, this, unbind);
// TODO: should we track?
}
void CompositorInterface::Private::unbind(wl_resource *resource)
{
Q_UNUSED(resource)
// TODO: implement?
}
void CompositorInterface::Private::createSurfaceCallback(wl_client *client, wl_resource *resource, uint32_t id)
{
cast(resource)->createSurface(client, resource, id);
}
void CompositorInterface::Private::createSurface(wl_client *client, wl_resource *resource, uint32_t id)
{
SurfaceInterface *surface = new SurfaceInterface(q, resource);
surface->create(display->getConnection(client), wl_resource_get_version(resource), id);
if (!surface->resource()) {
wl_resource_post_no_memory(resource);
delete surface;
return;
}
emit q->surfaceCreated(surface);
}
void CompositorInterface::Private::createRegionCallback(wl_client *client, wl_resource *resource, uint32_t id)
{
cast(resource)->createRegion(client, resource, id);
}
void CompositorInterface::Private::createRegion(wl_client *client, wl_resource *resource, uint32_t id)
{
RegionInterface *region = new RegionInterface(q, resource);
region->create(display->getConnection(client), wl_resource_get_version(resource), id);
if (!region->resource()) {
wl_resource_post_no_memory(resource);
delete region;
return;
}
emit q->regionCreated(region);
}
}
}