bd7958392d
The method was missing a check whether the weak pointers in the internal list got deleted. This could in very unlikely cases lead to a crash. In order to verify that adding the null pointer check fixes the crash a unit test is added to simulate the situation of a pointer being deleted. This required to add a mock a few classes of TabBox. A MockTabBoxHandler and MockTabBoxClient are added implementing the specific interfaces. The DeclarativeView is completely mocked to make the linker happy. Including the actual implementation is not possible as it pulls in half of KWin core. BUG: 303840 FIXED-IN: 4.9.0 REVIEW: 105645
47 lines
2 KiB
C++
47 lines
2 KiB
C++
/********************************************************************
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
Copyright (C) 2012 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*********************************************************************/
|
|
#include "test_tabbox_clientmodel.h"
|
|
#include "mock_tabboxhandler.h"
|
|
#include "clientmodel.h"
|
|
|
|
#include <QtTest/QtTest>
|
|
using namespace KWin;
|
|
|
|
void TestTabBoxClientModel::testLongestCaptionWithNullClient()
|
|
{
|
|
MockTabBoxHandler tabboxhandler;
|
|
TabBox::ClientModel *clientModel = new TabBox::ClientModel(&tabboxhandler);
|
|
clientModel->createClientList();
|
|
QCOMPARE(clientModel->longestCaption(), QString());
|
|
// add a window to the mock
|
|
tabboxhandler.createMockWindow(QString("test"), 1);
|
|
clientModel->createClientList();
|
|
QCOMPARE(clientModel->longestCaption(), QString("test"));
|
|
// delete the one client in the list
|
|
QModelIndex index = clientModel->index(0, 0);
|
|
QVERIFY(index.isValid());
|
|
TabBox::TabBoxClient *client = static_cast<TabBox::TabBoxClient *>(clientModel->data(index, TabBox::ClientModel::ClientRole).value<void*>());
|
|
client->close();
|
|
// internal model of ClientModel now contains a deleted pointer
|
|
// longestCaption should behave just as if the window were not in the list
|
|
QCOMPARE(clientModel->longestCaption(), QString());
|
|
}
|
|
|
|
QTEST_MAIN(TestTabBoxClientModel)
|