kwin/autotests/tabbox/mock_tabboxclient.h
Martin Flöser 932ccb2ac3 Switch ThumbnailItem to internal uuid instead of WId
Summary:
So far the ThumbnailItem in TabBox mode used the window id for finding
the window it should render a thumbnail on. In the Wayland world this is
not unique. The window id could be either an X11 window or a wayland
window. We don't guarantee that there are no conflicting ids.

With the internal id we have a way to properly identify the windows, so
this element should use them.

To support this the property changed the type to QUuid and the
clientmodel also provides the QUuid. As in TabBox the way to get the
window is through the model this should be compatible for all themes.
It's tested and verified with the Breeze switcher.

For declarative KWin scripts the ThumbnailItem also provides the
AbstractClient as a property, so there should not be any script which
uses wid. If it does, this could break, but well the script should use
the intended API.

Test Plan: ctest passes, manual testing of Breeze alt-tab switcher

Reviewers: #kwin

Differential Revision: https://phabricator.kde.org/D18405
2019-01-27 09:52:15 +01:00

78 lines
2 KiB
C++

/********************************************************************
KWin - the KDE window manager
This file is part of the KDE project.
Copyright (C) 2012 Martin Gräßlin <mgraesslin@kde.org>
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*********************************************************************/
#ifndef KWIN_MOCK_TABBOX_CLIENT_H
#define KWIN_MOCK_TABBOX_CLIENT_H
#include "../../tabbox/tabboxhandler.h"
#include <QIcon>
#include <QUuid>
namespace KWin
{
class MockTabBoxClient : public TabBox::TabBoxClient
{
public:
explicit MockTabBoxClient(QString caption, WId id);
virtual bool isMinimized() const {
return false;
}
virtual QString caption() const {
return m_caption;
}
virtual void close();
virtual int height() const {
return 100;
}
virtual QPixmap icon(const QSize &size = QSize(32, 32)) const {
return QPixmap(size);
}
virtual bool isCloseable() const {
return true;
}
virtual bool isFirstInTabBox() const {
return false;
}
virtual int width() const {
return 100;
}
virtual WId window() const {
return m_wId;
}
virtual int x() const {
return 0;
}
virtual int y() const {
return 0;
}
virtual QIcon icon() const {
return QIcon();
}
QUuid internalId() const override {
return QUuid{};
}
private:
QString m_caption;
WId m_wId;
};
} // namespace KWin
#endif