kwin/effects/desktopgrid
Vlad Zagorodniy 558b86e9f6 [effects/desktopgrid] Don't display the close button from Present Windows
Summary:
If you activate the Present Windows effect and then the Desktop Grid,
you'll be able to see the close button from PW. The reason for that is
PW doesn't destroy the close button and DG doesn't filter it out.

This patch addesses this problem by syncing DesktopGridEffect::isRelevantWithPresentWindows
with PresentWindowsEffect::isSelectableWindow.

On X11, the close button is filtered by the isSpecialWindow check. On
Wayland, the close button is filtered by the acceptsFocus check.

The proposed solution is kinda hack-ish, but on the other hand, we have
to keep those two methods in sync anyway.

In addition to the close button, notifications won't be displayed too.

BUG: 364710
FIXED-IN: 5.14.3

Test Plan:
* Activate the Present Windows effect;
* Activate the Desktop Grid effect;
* (the close button is no longer visible)

Reviewers: #kwin, graesslin

Reviewed By: #kwin, graesslin

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D16513
2018-10-30 22:39:08 +02:00
..
CMakeLists.txt Use SERVICE_TYPES parameter to kcoreaddons_desktop_to_json() 2015-12-09 23:42:45 +00:00
desktopgrid.cpp [effects/desktopgrid] Don't display the close button from Present Windows 2018-10-30 22:39:08 +02:00
desktopgrid.h [effects] Ignore previous state of WindowForceBlurRole 2018-06-19 15:23:41 +03:00
desktopgrid.kcfg [effects] Use arg="true" in the kcfg files 2017-04-15 10:03:34 +02:00
desktopgrid_config.cpp [effects] Use arg="true" in the kcfg files 2017-04-15 10:03:34 +02:00
desktopgrid_config.desktop SVN_SILENT made messages (.desktop file) - always resolve ours 2018-07-23 05:24:40 +02:00
desktopgrid_config.h Use Q_SLOTS and Q_SIGNALS instead of slots and signals 2013-07-24 09:46:54 +02:00
desktopgrid_config.ui desktop grid: add option to hide buttons 2015-10-29 23:36:10 +01:00
desktopgridconfig.kcfgc Use KConfigXT in DesktopGrid effect 2012-09-15 11:24:11 +02:00
main.qml desktop grid: use -/+ text buttons 2015-10-29 23:36:10 +01:00