kwin/src/wayland/subcompositor_interface.cpp
Vlad Zahorodnii 7fffe99328 build: Add -Wno-unused-parameter compiler option
Due to being a compositor, kwin has to conform to some certain
interfaces. It means a lot of virtual functions and function tables to
integrate with C APIs. Naturally, we not always want to use every
argument in such functions.

Since we get -Wunused-parameter from -Wall, we have to plumb those
unused arguments in order to suppress compiler warnings at the moment.

However, I don't think that extra work is worth it. We cannot change or
alter prototypes in any way to fix the warning the desired way. Q_UNUSED
and similar macros are not good indicators of whether an argument is
used too, we tend to overlook putting or removing those macros. I've
also noticed that Q_UNUSED are not used to guide us with the removal no
longer needed parameters.

Therefore, I think it's worth adding -Wno-unused-parameter compiler
option to stop the compiler producing warnings about unused parameters.
It changes nothing except that we don't need to put Q_UNUSED anymore,
which can be really cumbersome sometimes. Note that it doesn't affect
unused variables, you'll still get a -Wunused-variable compiler warning
if a variable is unused.
2022-10-31 15:50:37 +00:00

262 lines
8 KiB
C++

/*
SPDX-FileCopyrightText: 2014 Martin Gräßlin <mgraesslin@kde.org>
SPDX-FileCopyrightText: 2020 Vlad Zahorodnii <vlad.zahorodnii@kde.org>
SPDX-License-Identifier: LGPL-2.1-only OR LGPL-3.0-only OR LicenseRef-KDE-Accepted-LGPL
*/
#include "subcompositor_interface.h"
#include "display.h"
#include "subsurface_interface_p.h"
#include "surface_interface_p.h"
namespace KWaylandServer
{
static const int s_version = 1;
SubCompositorInterfacePrivate::SubCompositorInterfacePrivate(Display *display, SubCompositorInterface *q)
: QtWaylandServer::wl_subcompositor(*display, s_version)
, q(q)
{
}
void SubCompositorInterfacePrivate::subcompositor_destroy(Resource *resource)
{
wl_resource_destroy(resource->handle);
}
void SubCompositorInterfacePrivate::subcompositor_get_subsurface(Resource *resource,
uint32_t id,
::wl_resource *surface_resource,
::wl_resource *parent_resource)
{
SurfaceInterface *surface = SurfaceInterface::get(surface_resource);
SurfaceInterface *parent = SurfaceInterface::get(parent_resource);
if (!surface) {
wl_resource_post_error(resource->handle, error_bad_surface, "no surface");
return;
}
if (!parent) {
wl_resource_post_error(resource->handle, error_bad_surface, "no parent");
return;
}
const SurfaceRole *surfaceRole = SurfaceRole::get(surface);
if (surfaceRole) {
wl_resource_post_error(resource->handle, error_bad_surface, "the surface already has a role assigned %s", surfaceRole->name().constData());
return;
}
if (surface == parent) {
wl_resource_post_error(resource->handle, error_bad_surface, "wl_surface@%d cannot be its own parent", wl_resource_get_id(surface_resource));
return;
}
if (parent->subSurface() && parent->subSurface()->mainSurface() == surface) {
wl_resource_post_error(resource->handle, error_bad_surface, "wl_surface@%d is an ancestor of parent", wl_resource_get_id(surface_resource));
return;
}
wl_resource *subsurfaceResource = wl_resource_create(resource->client(), &wl_subsurface_interface, resource->version(), id);
if (!subsurfaceResource) {
wl_resource_post_no_memory(resource->handle);
return;
}
Q_EMIT q->subSurfaceCreated(new SubSurfaceInterface(surface, parent, subsurfaceResource));
}
SubCompositorInterface::SubCompositorInterface(Display *display, QObject *parent)
: QObject(parent)
, d(new SubCompositorInterfacePrivate(display, this))
{
}
SubCompositorInterface::~SubCompositorInterface()
{
}
SubSurfaceInterfacePrivate *SubSurfaceInterfacePrivate::get(SubSurfaceInterface *subsurface)
{
return subsurface->d.get();
}
SubSurfaceInterfacePrivate::SubSurfaceInterfacePrivate(SubSurfaceInterface *q, SurfaceInterface *surface, SurfaceInterface *parent, ::wl_resource *resource)
: SurfaceRole(surface, QByteArrayLiteral("wl_subsurface"))
, QtWaylandServer::wl_subsurface(resource)
, q(q)
, surface(surface)
, parent(parent)
{
}
void SubSurfaceInterfacePrivate::subsurface_destroy_resource(Resource *resource)
{
delete q;
}
void SubSurfaceInterfacePrivate::subsurface_destroy(Resource *resource)
{
wl_resource_destroy(resource->handle);
}
void SubSurfaceInterfacePrivate::subsurface_set_position(Resource *resource, int32_t x, int32_t y)
{
if (pendingPosition == QPoint(x, y)) {
return;
}
pendingPosition = QPoint(x, y);
hasPendingPosition = true;
}
void SubSurfaceInterfacePrivate::subsurface_place_above(Resource *resource, struct ::wl_resource *sibling_resource)
{
SurfaceInterface *sibling = SurfaceInterface::get(sibling_resource);
if (!sibling) {
wl_resource_post_error(resource->handle, error_bad_surface, "no sibling");
return;
}
if (!parent) {
wl_resource_post_error(resource->handle, error_bad_surface, "no parent");
return;
}
SurfaceInterfacePrivate *parentPrivate = SurfaceInterfacePrivate::get(parent);
if (!parentPrivate->raiseChild(q, sibling)) {
wl_resource_post_error(resource->handle, error_bad_surface, "incorrect sibling");
}
}
void SubSurfaceInterfacePrivate::subsurface_place_below(Resource *resource, struct ::wl_resource *sibling_resource)
{
SurfaceInterface *sibling = SurfaceInterface::get(sibling_resource);
if (!sibling) {
wl_resource_post_error(resource->handle, error_bad_surface, "no sibling");
return;
}
if (!parent) {
wl_resource_post_error(resource->handle, error_bad_surface, "no parent");
return;
}
SurfaceInterfacePrivate *parentPrivate = SurfaceInterfacePrivate::get(parent);
if (!parentPrivate->lowerChild(q, sibling)) {
wl_resource_post_error(resource->handle, error_bad_surface, "incorrect sibling");
}
}
void SubSurfaceInterfacePrivate::subsurface_set_sync(Resource *)
{
if (mode == SubSurfaceInterface::Mode::Synchronized) {
return;
}
mode = SubSurfaceInterface::Mode::Synchronized;
Q_EMIT q->modeChanged(SubSurfaceInterface::Mode::Synchronized);
}
void SubSurfaceInterfacePrivate::subsurface_set_desync(Resource *)
{
if (mode == SubSurfaceInterface::Mode::Desynchronized) {
return;
}
mode = SubSurfaceInterface::Mode::Desynchronized;
if (!q->isSynchronized()) {
auto surfacePrivate = SurfaceInterfacePrivate::get(surface);
surfacePrivate->commitFromCache();
}
Q_EMIT q->modeChanged(SubSurfaceInterface::Mode::Desynchronized);
}
void SubSurfaceInterfacePrivate::commit()
{
}
void SubSurfaceInterfacePrivate::parentCommit()
{
if (hasPendingPosition) {
hasPendingPosition = false;
position = pendingPosition;
Q_EMIT q->positionChanged(position);
}
if (mode == SubSurfaceInterface::Mode::Synchronized) {
auto surfacePrivate = SurfaceInterfacePrivate::get(surface);
surfacePrivate->commitFromCache();
}
}
SubSurfaceInterface::SubSurfaceInterface(SurfaceInterface *surface, SurfaceInterface *parent, wl_resource *resource)
: d(new SubSurfaceInterfacePrivate(this, surface, parent, resource))
{
SurfaceInterfacePrivate *surfacePrivate = SurfaceInterfacePrivate::get(surface);
SurfaceInterfacePrivate *parentPrivate = SurfaceInterfacePrivate::get(parent);
surfacePrivate->subSurface = this;
parentPrivate->addChild(this);
connect(surface, &SurfaceInterface::destroyed, this, [this]() {
delete this;
});
}
SubSurfaceInterface::~SubSurfaceInterface()
{
if (d->parent) {
SurfaceInterfacePrivate *parentPrivate = SurfaceInterfacePrivate::get(d->parent);
parentPrivate->removeChild(this);
}
if (d->surface) {
SurfaceInterfacePrivate *surfacePrivate = SurfaceInterfacePrivate::get(d->surface);
surfacePrivate->subSurface = nullptr;
}
}
QPoint SubSurfaceInterface::position() const
{
return d->position;
}
SurfaceInterface *SubSurfaceInterface::surface() const
{
return d->surface;
}
SurfaceInterface *SubSurfaceInterface::parentSurface() const
{
return d->parent;
}
SubSurfaceInterface::Mode SubSurfaceInterface::mode() const
{
return d->mode;
}
bool SubSurfaceInterface::isSynchronized() const
{
if (d->mode == Mode::Synchronized) {
return true;
}
if (!d->parent) {
// that shouldn't happen, but let's assume false
return false;
}
if (d->parent->subSurface()) {
// follow parent's mode
return d->parent->subSurface()->isSynchronized();
}
// parent is no subsurface, thus parent is in desync mode and this surface is in desync mode
return false;
}
SurfaceInterface *SubSurfaceInterface::mainSurface() const
{
if (!d->parent) {
return nullptr;
}
SurfaceInterfacePrivate *parentPrivate = SurfaceInterfacePrivate::get(d->parent);
if (parentPrivate->subSurface) {
return parentPrivate->subSurface->mainSurface();
}
return d->parent;
}
} // namespace KWaylandServer