My KWIN fork where I work on features like per-output virtual desktops
Find a file
Martin Gräßlin 9f976a4b8d Support multiple event types in X11EventFilter
Summary:
So far the X11EventFilter only supported one event type. But most
usecases for an X11EventFilter require to support multiple event types.
E.g. a filter listens for both key press and key release.

This change extends the internal X11EventFilter to support multiple
types and Workspace::workspaceEvent makes use of that.

Reviewers: #kwin, #plasma

Subscribers: plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D3361
2016-11-16 07:48:19 +01:00
autotests Support multiple event types in X11EventFilter 2016-11-16 07:48:19 +01:00
cmake/modules [plugins/qpa] support use of modularized qtplatformsupport from Qt 5.8 2016-10-28 21:12:48 +09:00
data [plugins/qpa] Add debug output for the KWin internal QPA plugin 2016-07-18 16:34:03 +02:00
decorations Cache the clientSize in DecoratedClientImpl 2016-08-10 14:22:19 +02:00
doc Update windowspecific (Window Rules) docbook 2016-10-04 18:46:51 +02:00
effects [effects] Clean up saving of DesktopGrid config 2016-11-15 07:19:52 +01:00
helpers Merge branch 'Plasma/5.8' 2016-11-07 11:41:30 +01:00
kcmkwin SVN_SILENT made messages (.desktop file) - always resolve ours 2016-11-04 09:48:38 +00:00
libinput [libinput] Load/store device configuration 2016-11-07 13:45:48 +01:00
libkwineffects Move querying glx extensions into the platform plugin 2016-11-16 07:47:36 +01:00
plugins Move querying glx extensions into the platform plugin 2016-11-16 07:47:36 +01:00
qml [qml/outline] Outline shall be a frameless window 2016-08-09 16:38:19 +02:00
scripting Merge branch 'Plasma/5.8' 2016-11-03 08:51:49 +01:00
scripts Add possible border handling in minimize all script 2016-10-07 15:21:56 +01:00
shaders [libkwinglutils] Cleanup Shader API: removal of ShaderType 2016-01-26 09:42:49 +01:00
tabbox [tabbox] Intercept QWheelEvents on QQuickWindow for scrolling 2016-10-17 08:23:39 +02:00
tests Forward pointer gestures to Wayland server 2016-11-07 13:45:08 +01:00
.arcconfig Adding .arcconfig 2016-03-15 13:37:47 +01:00
.reviewboardrc
16-apps-kwin.png
32-apps-kwin.png
48-apps-kwin.png
abstract_client.cpp Add support for desktopFileName provided by NETWinInfo 2016-10-31 13:19:46 +01:00
abstract_client.h Add support for desktopFileName provided by NETWinInfo 2016-10-31 13:19:46 +01:00
abstract_egl_backend.cpp Remove the unredirect fullscreen windows functionality 2016-08-04 14:48:35 +02:00
abstract_egl_backend.h [plugins/qpa] Support SharingPlatformContext on the existing eglSurface and eglconfig 2016-07-20 14:17:11 +02:00
activation.cpp Support docks which take input 2016-10-18 08:18:46 +02:00
activities.cpp Revert "Remove saving and loading (and client matching by) WM_COMMAND." 2016-06-23 21:07:03 +02:00
activities.h [autotests/integration] Add a first test case for activities 2016-08-12 12:52:47 +02:00
atoms.cpp
atoms.h Create screen edge through the Platform 2016-04-19 13:29:55 +02:00
client.cpp Merge branch 'Plasma/5.8' 2016-11-07 11:41:30 +01:00
client.h Implement show on screen edge for Wayland 2016-10-05 07:51:47 +02:00
client_machine.cpp Fix heap-use-after-free use in resolving ClientMachine 2015-10-01 10:09:52 +02:00
client_machine.h
CMakeLists.txt Merge branch 'Plasma/5.8' 2016-11-03 08:51:49 +01:00
COMPLIANCE
composite.cpp [platformx/x11] Add a freeze protection against OpenGL 2016-10-25 09:51:23 +02:00
composite.h [platformx/x11] Add a freeze protection against OpenGL 2016-10-25 09:51:23 +02:00
config-kwin.h.cmake Raise minimum libinput version to 1.2 2016-08-08 09:18:39 +02:00
CONFIGURING
COPYING
COPYING.DOC
cursor.cpp Implement cursor shape tracking on Wayland 2016-10-20 07:52:26 +02:00
cursor.h Implement cursor shape tracking on Wayland 2016-10-20 07:52:26 +02:00
dbusinterface.cpp [kcmkwin/compositing] Hide config options which don't make sense if Compositing is required 2016-09-13 15:47:42 +02:00
dbusinterface.h [kcmkwin/compositing] Hide config options which don't make sense if Compositing is required 2016-09-13 15:47:42 +02:00
debug_console.cpp Move querying glx extensions into the platform plugin 2016-11-16 07:47:36 +01:00
debug_console.h Destroy DebugConsole on hide of QWindow 2016-10-05 07:48:15 +02:00
debug_console.ui Add an OpenGL information tab to Debug Console 2016-08-10 08:27:36 +02:00
deleted.cpp Be sure isCurrentTab returns true 2016-06-01 20:46:35 +03:00
deleted.h Remove the unredirect fullscreen windows functionality 2016-08-04 14:48:35 +02:00
effectloader.cpp Introduce an EffectsHandler::animationsSupported -> bool 2016-08-15 17:38:33 +02:00
effectloader.h Ensure that EffectsHandlerImpl::slotClientShown is only invoked once per Window 2016-08-03 16:16:00 +02:00
effects.cpp [libkwineffects] Delete EffectsHandler::deleteRootProperty 2016-11-16 07:46:27 +01:00
effects.h [libkwineffects] Delete EffectsHandler::deleteRootProperty 2016-11-16 07:46:27 +01:00
events.cpp Support multiple event types in X11EventFilter 2016-11-16 07:48:19 +01:00
ExtraDesktop.sh
focuschain.cpp
focuschain.h
geometry.cpp Don't snap to auto-hidden panels 2016-11-03 08:35:25 +01:00
geometrytip.cpp Port to CMake AUTOMOC 2016-02-01 21:05:36 +01:00
geometrytip.h
globalshortcuts.cpp Pass Qt::Key to GlobalShortcutsManager::processKey 2016-09-15 09:02:38 +02:00
globalshortcuts.h Pass Qt::Key to GlobalShortcutsManager::processKey 2016-09-15 09:02:38 +02:00
group.cpp Reintroduce nullptr check in Client::removeFromMainClients 2015-09-17 14:17:55 +02:00
group.h
HACKING
input.cpp Forward pointer gestures to Wayland server 2016-11-07 13:45:08 +01:00
input.h Better handling for forwarding key events to Wayland Server 2016-09-15 08:47:01 +02:00
input_event.cpp Support for relative pointer motion events 2016-10-12 11:26:46 +02:00
input_event.h Support for relative pointer motion events 2016-10-12 11:26:46 +02:00
keyboard_input.cpp Fix shortcut triggering with shift+letter 2016-10-17 08:13:20 +02:00
keyboard_input.h Fix shortcut triggering with shift+letter 2016-10-17 08:13:20 +02:00
killwindow.cpp Drop dead Xlib code from KillWindow 2016-11-15 08:30:09 +01:00
killwindow.h Drop dead Xlib code from KillWindow 2016-11-15 08:30:09 +01:00
kwin.kcfg Introduce a config option whether applications are allowed to block compositing 2016-09-13 15:47:05 +02:00
kwin.notifyrc SVN_SILENT made messages (.desktop file) - always resolve ours 2016-05-31 11:06:54 +00:00
kwinbindings.cpp
KWinDBusInterfaceConfig.cmake.in Add path to kwin_wayland binary to KWin's installed CMakeConfig 2015-11-19 09:28:16 +01:00
lanczosfilter.cpp Disable lanczos filter with software emulation 2016-08-24 07:49:00 +02:00
lanczosfilter.h Use shader traits API for lanczos filter's shader 2016-01-25 14:11:54 +01:00
layers.cpp Remove non visible internal windows from the x stacking order 2016-09-09 07:41:12 +02:00
logind.cpp Drop not needed include to sys/sysmacros.h from logind.cpp 2016-06-20 11:21:45 +02:00
logind.h Switch virtual teminal through logind seat 2016-04-22 14:18:56 +02:00
main.cpp Move registerMetaType for SurfaceInterface* to main.cpp 2016-08-26 15:27:07 +02:00
main.h Move requiresCompositing from Application to Platform 2016-05-17 13:59:32 +02:00
main_wayland.cpp Unpolish QStyle on QApp prior to destroying internal Wayland connection 2016-11-07 11:28:06 +01:00
main_wayland.h Move everything KCrash related from Application to ApplicationX11 2016-05-09 08:08:49 +02:00
main_x11.cpp Move everything KCrash related from Application to ApplicationX11 2016-05-09 08:08:49 +02:00
main_x11.h Move everything KCrash related from Application to ApplicationX11 2016-05-09 08:08:49 +02:00
Mainpage.dox
manage.cpp Add support for desktopFileName provided by NETWinInfo 2016-10-31 13:19:46 +01:00
Messages.sh killer/ moved to helpers/killer 2016-06-30 11:25:43 +02:00
netinfo.cpp Move skipTaskbar from Client to AbstractClient 2015-06-06 22:11:10 +02:00
netinfo.h
options.cpp Introduce a config option whether applications are allowed to block compositing 2016-09-13 15:47:05 +02:00
options.h Introduce a config option whether applications are allowed to block compositing 2016-09-13 15:47:05 +02:00
org.freedesktop.ScreenSaver.xml
org.kde.kwin.Compositing.xml [kcmkwin/compositing] Hide config options which don't make sense if Compositing is required 2016-09-13 15:47:42 +02:00
org.kde.kwin.Effects.xml
org.kde.KWin.xml Add a debugging console to KWin 2016-03-16 14:30:19 +01:00
outline.cpp Make QmlPath in Outline configurable 2016-01-29 09:50:52 +01:00
outline.h
overlaywindow.cpp
overlaywindow.h Move glxbackend to x11 standalone plugin 2016-04-15 07:46:02 +02:00
placement.cpp Fix typo 2016-03-03 17:01:52 +01:00
placement.h Move implementation of Client::packTo to AbstractClient 2015-10-26 11:30:34 +01:00
platform.cpp Add way to hide/show cursor in Platform 2016-10-31 11:46:50 +01:00
platform.h Add way to hide/show cursor in Platform 2016-10-31 11:46:50 +01:00
pointer_input.cpp Forward pointer gestures to Wayland server 2016-11-07 13:45:08 +01:00
pointer_input.h Merge branch 'Plasma/5.8' 2016-10-31 11:52:43 +01:00
README
resources.qrc [libkwinglutils] Cleanup Shader API: removal of ShaderType 2016-01-26 09:42:49 +01:00
rules.cpp Match window role in Rules in a case insensitive manner 2016-09-13 08:37:26 +02:00
rules.h [autotests/integration] Add test case for rule matching on window role 2016-08-25 13:23:06 +02:00
sc-apps-kwin.svgz
scene.cpp Pass the current output geometry to ScreenPaintData 2016-10-17 09:02:30 +02:00
scene.h Pass the current output geometry to ScreenPaintData 2016-10-17 09:02:30 +02:00
scene_opengl.cpp Merge branch 'Plasma/5.8' 2016-10-28 16:43:04 +02:00
scene_opengl.h Move querying glx extensions into the platform plugin 2016-11-16 07:47:36 +01:00
scene_qpainter.cpp Make WindowPixmap::isValid virtual and override in concrete implementation 2016-09-14 10:23:35 +02:00
scene_qpainter.h Make WindowPixmap::isValid virtual and override in concrete implementation 2016-09-14 10:23:35 +02:00
scene_xrender.cpp SceneXRender::Window uses a static XRenderPicture which it didn't clean up 2016-06-13 15:29:35 +02:00
scene_xrender.h Introduce an EffectsHandler::animationsSupported -> bool 2016-08-15 17:38:33 +02:00
screenedge.cpp Implement show on screen edge for Wayland 2016-10-05 07:51:47 +02:00
screenedge.h Implement show on screen edge for Wayland 2016-10-05 07:51:47 +02:00
screenlockerwatcher.cpp Delay query whether screenlocker is registered till WaylandServer is initialized 2016-08-16 10:17:14 +02:00
screenlockerwatcher.h [autotests/integration] Add ScreenLockerWatcher to the Test::lockScreen and ::unlockScreen 2016-08-16 10:23:37 +02:00
screens.cpp Set initial count of screens before calling Screens::init 2016-08-05 09:59:22 +02:00
screens.h Rename AbstractBackend to Platform 2016-04-07 16:18:12 +02:00
settings.kcfgc
shadow.cpp Ensure to directly delete old Shadow on update 2016-08-18 16:08:42 +02:00
shadow.h [wayland] Shadow gains support for a Wayland protocol 2015-07-15 11:25:16 +02:00
shell_client.cpp Merge branch 'Plasma/5.8' 2016-11-07 11:41:30 +01:00
shell_client.h Support docks which take input 2016-10-18 08:18:46 +02:00
shortcutdialog.ui
sm.cpp Drop warning regarding ksmserver in sm.cpp 2016-06-29 11:06:24 +02:00
sm.h Revert "Remove saving and loading (and client matching by) WM_COMMAND." 2016-06-23 21:07:03 +02:00
tabgroup.cpp
tabgroup.h
thumbnailitem.cpp Make Toplevel::window() no longer virtual and introduce ::windowId() 2016-05-17 14:13:24 +02:00
thumbnailitem.h ThumbnailItem operates on AbstractClient 2015-05-21 13:34:26 +02:00
toplevel.cpp Add support for resize only borders on Wayland 2016-10-05 07:49:23 +02:00
toplevel.h Add support for resize only borders on Wayland 2016-10-05 07:49:23 +02:00
touch_input.cpp Pass LibInput::Device* through the event handlers 2016-05-30 15:26:37 +02:00
touch_input.h Pass LibInput::Device* through the event handlers 2016-05-30 15:26:37 +02:00
udev.cpp [platforms/virtual] Use rendernode or vgem device if available for egl 2016-07-21 09:13:57 +02:00
udev.h [platforms/virtual] Use rendernode or vgem device if available for egl 2016-07-21 09:13:57 +02:00
unmanaged.cpp Implement addDamage in Unmanaged 2016-08-12 11:32:48 +02:00
unmanaged.h Implement addDamage in Unmanaged 2016-08-12 11:32:48 +02:00
useractions.cpp VirtualDesktopGrid operates on VirtualDesktop objects 2016-11-15 07:20:23 +01:00
useractions.h [autotests/integration] Add test case for global shortcuts with Fx 2016-10-05 14:43:38 +02:00
utils.cpp Port to CMake AUTOMOC 2016-02-01 21:05:36 +01:00
utils.h Move X11Cursor into the x11standalone platform plugin 2016-08-19 10:57:09 +02:00
virtual_terminal.cpp Fix build with future glibc (major/minor macros) 2016-04-20 19:03:34 +02:00
virtual_terminal.h [wayland] Don't break if we try to vt-switch to vt we're on 2015-07-20 11:49:41 +02:00
virtualdesktops.cpp VirtualDesktopGrid operates on VirtualDesktop objects 2016-11-15 07:20:23 +01:00
virtualdesktops.h VirtualDesktopGrid operates on VirtualDesktop objects 2016-11-15 07:20:23 +01:00
virtualkeyboard.cpp Translate Qt key events through the unicode text with xkbcommon 2016-08-18 07:55:27 +02:00
virtualkeyboard.h Integrate QtVirtualKeyboard into KWin/Wayland 2016-06-02 11:26:53 +02:00
wayland_cursor_theme.cpp Fix fallback resolution in WaylandCursorTheme 2016-02-25 14:05:20 +01:00
wayland_cursor_theme.h Clear cursor cache on theme changes 2016-02-25 08:14:48 +01:00
wayland_server.cpp Forward pointer gestures to Wayland server 2016-11-07 13:45:08 +01:00
wayland_server.h Move implementation of iconGeometry from ShellClient to AbstractClient 2016-08-24 13:11:32 +02:00
workspace.cpp Remove non visible internal windows from the x stacking order 2016-09-09 07:41:12 +02:00
workspace.h Add a Workspace::findToplevel(QWindow*) method 2016-08-30 15:47:59 +02:00
x11eventfilter.cpp Support multiple event types in X11EventFilter 2016-11-16 07:48:19 +01:00
x11eventfilter.h Support multiple event types in X11EventFilter 2016-11-16 07:48:19 +01:00
xcbutils.cpp Clean debug output 2015-07-20 13:36:27 +02:00
xcbutils.h Fix regression in unit-test introduced with 62b6401175 2015-08-21 11:14:20 +02:00

- A collection of various documents and links related to KWin is at http://techbase.kde.org/Projects/KWin .


- The mailing list for KWin is kwin@kde.org (https://mail.kde.org/mailman/listinfo/kwin).

- If you want to develop KWin, see file HACKING.

- If you want to check KWin's compliance with specifications, see file COMPLIANCE.

- File CONFIGURATION includes some details on configuring KWin.

- Below is some info for application developers about application interaction
  with the window manager, but it'd need some cleanup.








 This README is meant as an explanation of various window manager related
mechanisms that application developers need to be aware of. As some of these
concepts may be difficult to understand for people not having the required
background knowledge (since sometimes it's difficult even for people who
do have the knowledge), the mechanisms are first briefly explained, and
then an example of fixing the various problems is given.

 For comments, questions, suggestions and whatever use the kwin@kde.org
mailing list.


Table of contents:
==================

- Window relations
    - how to make the window manager know which windows belong together
- Focus stealing prevention
    - how to solve cases where focus stealing prevention doesn't work
      properly automatically



Window relations:
=================

(For now, this explanation of window relations is mainly meant for
focus stealing prevention. To be extended later.)

 All windows created by an application should be organized in a tree
with the root being the application's main window. Note that this is about
toplevel windows, not widgets inside the windows. For example, if you
have KWrite running, with a torn-off toolbar (i.e. a standalone toolbar),
a file save dialog open, and the file save dialog showing a dialog
for creating a directory, the window hiearchy should look like this:


             KWrite mainwindow
              /             \
             /               \
      file save dialog      torn-off toolbar
            \
             \
          create directory dialog

 Each subwindow (i.e. all except for the KWrite mainwindow) points to its
main window (which in turn may have another main window, as in the case
of the file save dialog). When the window manager knows these relations,
it can better arrange the windows (keeping subwindows above their
main windows, preventing activation of a main window of a modal dialog,
and similar). Failing to provide this information to the window manager
may have various results, for example having dialogs positioned below
the main window,

The window property used by subwindows to point to their mainwindows is
called WM_TRANSIENT_FOR. It can be seen by running
'xprop | grep WM_TRANSIENT_FOR' and clicking on a window. If the property
is not present, the window does not (claim to) have any mainwindow.
If the property is present, it's value is the window id of its main window;
window id of any window can be found out by running 'xwininfo'. A window
having WM_TRANSIENT_FOR poiting to another window is said to be transient
for that window.

 In some cases, the WM_TRANSIENT_FOR property may not point to any other
existing window, having value of 0, or pointing to the screen number
('xwininfo -root'). These special values mean that the window is transient
for all other windows in its window group. This should be used only
in rare cases, everytime a specific main window is known, WM_TRANSIENT_FOR
should be pointing to it instead of using one of these special values.
(The explanation why is beyond the scope of this document - just accept it
as a fact.)

 With Qt, the WM_TRANSIENT_FOR property is set by Qt automatically, based
on the toplevel widget's parent. If the toplevel widget is of a normal
type (i.e. not a dialog, toolbar, etc.), Qt doesn't set WM_TRANSIENT_FOR
on it. For special widgets, such as dialogs, WM_TRANSIENT_FOR is set
to point to the widget's parent, if it has a specific parent, otherwise
WM_TRANSIENT_FOR points to the root window.

 As already said above, WM_TRANSIENT_FOR poiting to the root window should
be usually avoided, so everytime the widget's main widget is known, the widget
should get it passed as a parent in its constructor.
(TODO KDialog etc. classes should not have a default argument for the parent
argument, and comments like 'just pass 0 as the parent' should go.)



Focus stealing prevention:
==========================

 Since KDE3.2 KWin has a feature called focus stealing prevention. As the name
suggests, it prevents unexpected changes of focus. With older versions of KWin,
if any application opened a new dialog, it became active, and
if the application's main window was on another virtual desktop, also
the virtual desktop was changed. This was annoying, and also sometimes led
to dialogs mistakenly being closed because they received keyboard input that
was meant for the previously active window.

 The basic principle of focus stealing prevention is that the window with most
recent user activity wins. Any window of an application will become active
when being shown only if this application was the most recently used one.
KWin itself, and some of the related kdecore classes should take care
of the common cases, so usually there's no need for any special handling
in applications. Qt/KDE applications, that is. Applications using other
toolkits should in most cases work fine too. If they don't support
the window property _NET_WM_USER_TIME, the window manager may fail to detect
the user timestamp properly, resulting either in other windows becoming active
while the user works with this application, or this application may sometimes
steal focus (this second case should be very rare though).

 There are also cases where KDE applications needs special handling. The two
most common cases are when windows relations are not setup properly to make
KWin realize that they belong to the same application, and when the user
activity is not represented by manipulating with the application windows
themselves.

 Also note that focus stealing prevention implemented in the window manager
can only help with focus stealing between different applications.
If an application itself suddenly pops up a dialog, KWin cannot do anything about
it, and its the application's job to handle this case.


Window relations:
-----------------

 The common case here is when a dialog is shown for an application, but this
dialog is not provided by the application itself, but by some other process.
For example, dialogs with warnings about accepted cookies are provided
by KCookieJar, instead of being shown by Konqueror. In the normal case,
from KWin's point of view the cookie dialog would be an attempt of another
application to show a dialog, and KWin wouldn't allow activation of this
window.

 The solution is to tell the window manager about the relation between
the Konqueror main window and the cookie dialog, by making the dialog
point to the mainwindow. Note that this is not special to focus stealing
prevention, subwindows such as dialogs, toolbars and similar should always
point to their mainwindow. See the section on window relations for full
description.

 The WM_TRANSIENT_FOR property that's set on dialogs to point to their
mainwindow should in the cookie dialog case point to the Konqueror window
for which it has been shown. This is solved in kcookiejar by including
the window id in the DCOP call. When the cookie dialog is shown, its
WM_TRANSIENT_FOR property is manually set using the XSetTransientForHint()
call (see kdelibs/kioslave/http/kcookiejar/kcookiewin.cpp). The arguments
to XSetTransientForHint() call are the X display (i.e. QX11Info::display()),
the window id on which the WM_TRANSIENT_FOR property is to be set
(i.e. use QWidget::winId()), and the window id of the mainwindow.


  Simple short HOWTO:
  
 To put it simply: Let's say you have a daemon application that has
DCOP call "showDialog( QString text )", and when this is called, it shows
a dialog with the given text. This won't work properly with focus stealing
prevention. The DCOP call should be changed to
"showDialog( QString text, long id )". The caller should pass something like
myMainWindow->winId() as the second argument. In the daemon, before
the dialog is shown, a call to XSetTransientHint() should be added:

 XSetTransientForHint( QX11Info::display(), dialog->winId(), id_of_mainwindow );
 
 That's it.

Non-standard user activity:
---------------------------

 The most common case in KDE will be DCOP calls. For example, KDesktop's DCOP
call "KDesktopIface popupExecuteCommand". Executing this DCOP call e.g.
from Konsole as 'dcop kdesktop KDesktopIface popupExecuteCommand" will lead
to showing the minicli, but the last user activity timestamp gained from events
sent by X server will be older than user activity timestamp of Konsole, and
would normally result in minicli not being active. Therefore, before showing
the minicli, kdesktop needs to call KApplication::updateUserTimestamp().

 However, this shouldn't be done with all DCOP calls. If a DCOP call is not
a result of direct user action, calling KApplication::updateUserTimestamp()
would lead to focus stealing. For example, let's assume for a moment
that KMail would use this DCOP call in case it detects the modem is not
connected, allowing to you to start KPPP or whatever tool you use. If KMail
would be configured to check mail every 10 minutes, this would lead to minicli
possibly suddenly showing up at every check. Basically, doing the above change
to kdesktop's minicli means that the popupExecuteCommand() DCOP call is only
for user scripting. (TODO write about focus transferring?)

 Simply said, KApplication::updateUserTimestamp() should be called only
as a result of user action. Unfortunately, I'm not aware of any universal
way how to handle this, so every case will have to be considered separately.