a0571ccf84
To get an image from KWin to the screen in the DRM pipeline we combine a CRTC, an encoder and a connector. These objects are static in the sense, that they represent real hardware on the graphics card, which doesn't change in a session. See here for more details: https://01.org/linuxgraphics/gfx-docs/drm/gpu/drm-kms.html Until now we used DrmOutput as the main representation for such an active rendering pipeline. I.e. it gets created and destroyed on hot plug events of displays. On the other side we had no fixed representation of the static kernel objects throughout the lifetime of KWin. This has several disadvantages: * We always need to query all available static objects on an hot plug event. * We can't manipulate the frame buffer of a CRTC after an output has been disconnected * Adding functionality for driving multiple displays on a single CRTC (i.e. cloning) would be difficult * We can't destroy the last frame buffer on display disconnect because the CRTC still accesses it and have therefore a memory leak on every display disconnect This patch solves these issues by storing representations of all available CRTC and Connector objects in DrmBackend on init via DrmCrtc and DrmConnector instances. On an hotplug event these vectors are looped for a fitting CRTC and Connector combinations. Buffer handling is moved to the respective CRTC instance. All changes in overview: * Query all available CRTCs and Connectors and save for subsequent hotplug events * Fix logic errors in `queryResources()` * Move framebuffers, buffer flip and blank logic in DrmCrtc * Remove `restoreSaved()`. It isn't necessary and is dangerous if the old framebuffer was deleted in the meantime. Also could reveal sensitive user info from old session. Test Plan: Login, logout, VT switching, connect and disconnect external monitor, energy saving mode. Reviewers: #kwin Subscribers: kwin, #kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D5118
107 lines
2.8 KiB
C++
107 lines
2.8 KiB
C++
/********************************************************************
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
Copyright (C) 2016 Roman Gilg <subdiff@gmail.com>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*********************************************************************/
|
|
#include "drm_object_crtc.h"
|
|
#include "drm_backend.h"
|
|
#include "drm_output.h"
|
|
#include "drm_buffer.h"
|
|
#include "logging.h"
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
DrmCrtc::DrmCrtc(uint32_t crtc_id, int fd, int resIndex)
|
|
: DrmObject(crtc_id, fd),
|
|
m_resIndex(resIndex)
|
|
{
|
|
}
|
|
|
|
DrmCrtc::~DrmCrtc()
|
|
{
|
|
}
|
|
|
|
bool DrmCrtc::init()
|
|
{
|
|
qCDebug(KWIN_DRM) << "Atomic init for CRTC:" << resIndex() << "id:" << m_id;
|
|
|
|
if (!initProps()) {
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool DrmCrtc::initProps()
|
|
{
|
|
m_propsNames = {
|
|
QByteArrayLiteral("MODE_ID"),
|
|
QByteArrayLiteral("ACTIVE"),
|
|
};
|
|
|
|
drmModeObjectProperties *properties = drmModeObjectGetProperties(m_fd, m_id, DRM_MODE_OBJECT_CRTC);
|
|
if (!properties) {
|
|
qCWarning(KWIN_DRM) << "Failed to get properties for crtc " << m_id ;
|
|
return false;
|
|
}
|
|
|
|
int propCount = int(PropertyIndex::Count);
|
|
for (int j = 0; j < propCount; ++j) {
|
|
initProp(j, properties);
|
|
}
|
|
drmModeFreeObjectProperties(properties);
|
|
return true;
|
|
}
|
|
|
|
void DrmCrtc::flipBuffer()
|
|
{
|
|
if (m_currentBuffer && m_currentBuffer->deleteAfterPageFlip() && m_currentBuffer != m_nextBuffer) {
|
|
delete m_currentBuffer;
|
|
}
|
|
m_currentBuffer = m_nextBuffer;
|
|
m_nextBuffer = nullptr;
|
|
|
|
delete m_blackBuffer;
|
|
m_blackBuffer = nullptr;
|
|
}
|
|
|
|
bool DrmCrtc::blank()
|
|
{
|
|
if (!m_blackBuffer) {
|
|
DrmBuffer *blackBuffer = m_output->m_backend->createBuffer(m_output->pixelSize());
|
|
if (!blackBuffer->map()) {
|
|
delete blackBuffer;
|
|
return false;
|
|
}
|
|
blackBuffer->image()->fill(Qt::black);
|
|
m_blackBuffer = blackBuffer;
|
|
}
|
|
|
|
// TODO: Do this atomically
|
|
if (m_output->setModeLegacy(m_blackBuffer)) {
|
|
if (m_currentBuffer && m_currentBuffer->deleteAfterPageFlip()) {
|
|
delete m_currentBuffer;
|
|
delete m_nextBuffer;
|
|
}
|
|
m_currentBuffer = nullptr;
|
|
m_nextBuffer = nullptr;
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
}
|