1111 lines
47 KiB
C++
1111 lines
47 KiB
C++
/*
|
||
KWin - the KDE window manager
|
||
This file is part of the KDE project.
|
||
|
||
SPDX-FileCopyrightText: 2016 Martin Gräßlin <mgraesslin@kde.org>
|
||
|
||
SPDX-License-Identifier: GPL-2.0-or-later
|
||
*/
|
||
#include "kwin_wayland_test.h"
|
||
#include "atoms.h"
|
||
#include "x11client.h"
|
||
#include "composite.h"
|
||
#include "effects.h"
|
||
#include "effectloader.h"
|
||
#include "cursor.h"
|
||
#include "deleted.h"
|
||
#include "platform.h"
|
||
#include "screens.h"
|
||
#include "wayland_server.h"
|
||
#include "workspace.h"
|
||
|
||
#include <KWayland/Client/surface.h>
|
||
|
||
#include <netwm.h>
|
||
#include <xcb/xcb_icccm.h>
|
||
|
||
using namespace KWin;
|
||
using namespace KWayland::Client;
|
||
static const QString s_socketName = QStringLiteral("wayland_test_x11_client-0");
|
||
|
||
class X11ClientTest : public QObject
|
||
{
|
||
Q_OBJECT
|
||
private Q_SLOTS:
|
||
void initTestCase();
|
||
void init();
|
||
void cleanup();
|
||
|
||
void testMinimumSize();
|
||
void testMaximumSize();
|
||
void testResizeIncrements();
|
||
void testResizeIncrementsNoBaseSize();
|
||
void testTrimCaption_data();
|
||
void testTrimCaption();
|
||
void testFullscreenLayerWithActiveWaylandWindow();
|
||
void testFocusInWithWaylandLastActiveWindow();
|
||
void testX11WindowId();
|
||
void testCaptionChanges();
|
||
void testCaptionWmName();
|
||
void testCaptionMultipleWindows();
|
||
void testFullscreenWindowGroups();
|
||
void testActivateFocusedWindow();
|
||
void testReentrantSetFrameGeometry();
|
||
};
|
||
|
||
void X11ClientTest::initTestCase()
|
||
{
|
||
qRegisterMetaType<KWin::Deleted*>();
|
||
qRegisterMetaType<KWin::AbstractClient*>();
|
||
QSignalSpy applicationStartedSpy(kwinApp(), &Application::started);
|
||
QVERIFY(applicationStartedSpy.isValid());
|
||
kwinApp()->platform()->setInitialWindowSize(QSize(1280, 1024));
|
||
QVERIFY(waylandServer()->init(s_socketName));
|
||
kwinApp()->setConfig(KSharedConfig::openConfig(QString(), KConfig::SimpleConfig));
|
||
|
||
kwinApp()->start();
|
||
QVERIFY(applicationStartedSpy.wait());
|
||
QVERIFY(KWin::Compositor::self());
|
||
waylandServer()->initWorkspace();
|
||
}
|
||
|
||
void X11ClientTest::init()
|
||
{
|
||
QVERIFY(Test::setupWaylandConnection());
|
||
}
|
||
|
||
void X11ClientTest::cleanup()
|
||
{
|
||
Test::destroyWaylandConnection();
|
||
}
|
||
|
||
struct XcbConnectionDeleter
|
||
{
|
||
static inline void cleanup(xcb_connection_t *pointer)
|
||
{
|
||
xcb_disconnect(pointer);
|
||
}
|
||
};
|
||
|
||
void X11ClientTest::testMinimumSize()
|
||
{
|
||
// This test verifies that the minimum size constraint is correctly applied.
|
||
|
||
// Create an xcb window.
|
||
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
|
||
QVERIFY(!xcb_connection_has_error(c.data()));
|
||
const QRect windowGeometry(0, 0, 100, 200);
|
||
xcb_window_t w = xcb_generate_id(c.data());
|
||
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
|
||
windowGeometry.x(),
|
||
windowGeometry.y(),
|
||
windowGeometry.width(),
|
||
windowGeometry.height(),
|
||
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
|
||
xcb_size_hints_t hints;
|
||
memset(&hints, 0, sizeof(hints));
|
||
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
|
||
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
|
||
xcb_icccm_size_hints_set_min_size(&hints, windowGeometry.width(), windowGeometry.height());
|
||
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
|
||
xcb_map_window(c.data(), w);
|
||
xcb_flush(c.data());
|
||
|
||
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
|
||
QVERIFY(windowCreatedSpy.isValid());
|
||
QVERIFY(windowCreatedSpy.wait());
|
||
X11Client *client = windowCreatedSpy.last().first().value<X11Client *>();
|
||
QVERIFY(client);
|
||
QVERIFY(client->isDecorated());
|
||
|
||
QSignalSpy clientStartMoveResizedSpy(client, &AbstractClient::clientStartUserMovedResized);
|
||
QVERIFY(clientStartMoveResizedSpy.isValid());
|
||
QSignalSpy clientStepUserMovedResizedSpy(client, &AbstractClient::clientStepUserMovedResized);
|
||
QVERIFY(clientStepUserMovedResizedSpy.isValid());
|
||
QSignalSpy clientFinishUserMovedResizedSpy(client, &AbstractClient::clientFinishUserMovedResized);
|
||
QVERIFY(clientFinishUserMovedResizedSpy.isValid());
|
||
|
||
// Begin resize.
|
||
QCOMPARE(workspace()->moveResizeClient(), nullptr);
|
||
QVERIFY(!client->isResize());
|
||
workspace()->slotWindowResize();
|
||
QCOMPARE(workspace()->moveResizeClient(), client);
|
||
QCOMPARE(clientStartMoveResizedSpy.count(), 1);
|
||
QVERIFY(client->isResize());
|
||
|
||
const QPoint cursorPos = KWin::Cursors::self()->mouse()->pos();
|
||
|
||
client->keyPressEvent(Qt::Key_Left);
|
||
client->updateMoveResize(KWin::Cursors::self()->mouse()->pos());
|
||
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(-8, 0));
|
||
QVERIFY(!clientStepUserMovedResizedSpy.wait(1000));
|
||
QCOMPARE(clientStepUserMovedResizedSpy.count(), 0);
|
||
QCOMPARE(client->clientSize().width(), 100);
|
||
|
||
client->keyPressEvent(Qt::Key_Right);
|
||
client->updateMoveResize(KWin::Cursors::self()->mouse()->pos());
|
||
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos);
|
||
QVERIFY(!clientStepUserMovedResizedSpy.wait(1000));
|
||
QCOMPARE(clientStepUserMovedResizedSpy.count(), 0);
|
||
QCOMPARE(client->clientSize().width(), 100);
|
||
|
||
client->keyPressEvent(Qt::Key_Right);
|
||
client->updateMoveResize(KWin::Cursors::self()->mouse()->pos());
|
||
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(8, 0));
|
||
QVERIFY(clientStepUserMovedResizedSpy.wait());
|
||
QCOMPARE(clientStepUserMovedResizedSpy.count(), 1);
|
||
QCOMPARE(client->clientSize().width(), 108);
|
||
|
||
client->keyPressEvent(Qt::Key_Up);
|
||
client->updateMoveResize(KWin::Cursors::self()->mouse()->pos());
|
||
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(8, -8));
|
||
QVERIFY(!clientStepUserMovedResizedSpy.wait(1000));
|
||
QCOMPARE(clientStepUserMovedResizedSpy.count(), 1);
|
||
QCOMPARE(client->clientSize().height(), 200);
|
||
|
||
client->keyPressEvent(Qt::Key_Down);
|
||
client->updateMoveResize(KWin::Cursors::self()->mouse()->pos());
|
||
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(8, 0));
|
||
QVERIFY(!clientStepUserMovedResizedSpy.wait(1000));
|
||
QCOMPARE(clientStepUserMovedResizedSpy.count(), 1);
|
||
QCOMPARE(client->clientSize().height(), 200);
|
||
|
||
client->keyPressEvent(Qt::Key_Down);
|
||
client->updateMoveResize(KWin::Cursors::self()->mouse()->pos());
|
||
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(8, 8));
|
||
QVERIFY(clientStepUserMovedResizedSpy.wait());
|
||
QCOMPARE(clientStepUserMovedResizedSpy.count(), 2);
|
||
QCOMPARE(client->clientSize().height(), 208);
|
||
|
||
// Finish the resize operation.
|
||
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 0);
|
||
client->keyPressEvent(Qt::Key_Enter);
|
||
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 1);
|
||
QCOMPARE(workspace()->moveResizeClient(), nullptr);
|
||
QVERIFY(!client->isResize());
|
||
|
||
// Destroy the window.
|
||
QSignalSpy windowClosedSpy(client, &X11Client::windowClosed);
|
||
QVERIFY(windowClosedSpy.isValid());
|
||
xcb_unmap_window(c.data(), w);
|
||
xcb_destroy_window(c.data(), w);
|
||
xcb_flush(c.data());
|
||
QVERIFY(windowClosedSpy.wait());
|
||
c.reset();
|
||
}
|
||
|
||
void X11ClientTest::testMaximumSize()
|
||
{
|
||
// This test verifies that the maximum size constraint is correctly applied.
|
||
|
||
// Create an xcb window.
|
||
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
|
||
QVERIFY(!xcb_connection_has_error(c.data()));
|
||
const QRect windowGeometry(0, 0, 100, 200);
|
||
xcb_window_t w = xcb_generate_id(c.data());
|
||
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
|
||
windowGeometry.x(),
|
||
windowGeometry.y(),
|
||
windowGeometry.width(),
|
||
windowGeometry.height(),
|
||
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
|
||
xcb_size_hints_t hints;
|
||
memset(&hints, 0, sizeof(hints));
|
||
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
|
||
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
|
||
xcb_icccm_size_hints_set_max_size(&hints, windowGeometry.width(), windowGeometry.height());
|
||
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
|
||
xcb_map_window(c.data(), w);
|
||
xcb_flush(c.data());
|
||
|
||
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
|
||
QVERIFY(windowCreatedSpy.isValid());
|
||
QVERIFY(windowCreatedSpy.wait());
|
||
X11Client *client = windowCreatedSpy.last().first().value<X11Client *>();
|
||
QVERIFY(client);
|
||
QVERIFY(client->isDecorated());
|
||
|
||
QSignalSpy clientStartMoveResizedSpy(client, &AbstractClient::clientStartUserMovedResized);
|
||
QVERIFY(clientStartMoveResizedSpy.isValid());
|
||
QSignalSpy clientStepUserMovedResizedSpy(client, &AbstractClient::clientStepUserMovedResized);
|
||
QVERIFY(clientStepUserMovedResizedSpy.isValid());
|
||
QSignalSpy clientFinishUserMovedResizedSpy(client, &AbstractClient::clientFinishUserMovedResized);
|
||
QVERIFY(clientFinishUserMovedResizedSpy.isValid());
|
||
|
||
// Begin resize.
|
||
QCOMPARE(workspace()->moveResizeClient(), nullptr);
|
||
QVERIFY(!client->isResize());
|
||
workspace()->slotWindowResize();
|
||
QCOMPARE(workspace()->moveResizeClient(), client);
|
||
QCOMPARE(clientStartMoveResizedSpy.count(), 1);
|
||
QVERIFY(client->isResize());
|
||
|
||
const QPoint cursorPos = KWin::Cursors::self()->mouse()->pos();
|
||
|
||
client->keyPressEvent(Qt::Key_Right);
|
||
client->updateMoveResize(KWin::Cursors::self()->mouse()->pos());
|
||
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(8, 0));
|
||
QVERIFY(!clientStepUserMovedResizedSpy.wait(1000));
|
||
QCOMPARE(clientStepUserMovedResizedSpy.count(), 0);
|
||
QCOMPARE(client->clientSize().width(), 100);
|
||
|
||
client->keyPressEvent(Qt::Key_Left);
|
||
client->updateMoveResize(KWin::Cursors::self()->mouse()->pos());
|
||
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos);
|
||
QVERIFY(!clientStepUserMovedResizedSpy.wait(1000));
|
||
QCOMPARE(clientStepUserMovedResizedSpy.count(), 0);
|
||
QCOMPARE(client->clientSize().width(), 100);
|
||
|
||
client->keyPressEvent(Qt::Key_Left);
|
||
client->updateMoveResize(KWin::Cursors::self()->mouse()->pos());
|
||
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(-8, 0));
|
||
QVERIFY(clientStepUserMovedResizedSpy.wait());
|
||
QCOMPARE(clientStepUserMovedResizedSpy.count(), 1);
|
||
QCOMPARE(client->clientSize().width(), 92);
|
||
|
||
client->keyPressEvent(Qt::Key_Down);
|
||
client->updateMoveResize(KWin::Cursors::self()->mouse()->pos());
|
||
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(-8, 8));
|
||
QVERIFY(!clientStepUserMovedResizedSpy.wait(1000));
|
||
QCOMPARE(clientStepUserMovedResizedSpy.count(), 1);
|
||
QCOMPARE(client->clientSize().height(), 200);
|
||
|
||
client->keyPressEvent(Qt::Key_Up);
|
||
client->updateMoveResize(KWin::Cursors::self()->mouse()->pos());
|
||
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(-8, 0));
|
||
QVERIFY(!clientStepUserMovedResizedSpy.wait(1000));
|
||
QCOMPARE(clientStepUserMovedResizedSpy.count(), 1);
|
||
QCOMPARE(client->clientSize().height(), 200);
|
||
|
||
client->keyPressEvent(Qt::Key_Up);
|
||
client->updateMoveResize(KWin::Cursors::self()->mouse()->pos());
|
||
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(-8, -8));
|
||
QVERIFY(clientStepUserMovedResizedSpy.wait());
|
||
QCOMPARE(clientStepUserMovedResizedSpy.count(), 2);
|
||
QCOMPARE(client->clientSize().height(), 192);
|
||
|
||
// Finish the resize operation.
|
||
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 0);
|
||
client->keyPressEvent(Qt::Key_Enter);
|
||
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 1);
|
||
QCOMPARE(workspace()->moveResizeClient(), nullptr);
|
||
QVERIFY(!client->isResize());
|
||
|
||
// Destroy the window.
|
||
QSignalSpy windowClosedSpy(client, &X11Client::windowClosed);
|
||
QVERIFY(windowClosedSpy.isValid());
|
||
xcb_unmap_window(c.data(), w);
|
||
xcb_destroy_window(c.data(), w);
|
||
xcb_flush(c.data());
|
||
QVERIFY(windowClosedSpy.wait());
|
||
c.reset();
|
||
}
|
||
|
||
void X11ClientTest::testResizeIncrements()
|
||
{
|
||
// This test verifies that the resize increments constraint is correctly applied.
|
||
|
||
// Create an xcb window.
|
||
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
|
||
QVERIFY(!xcb_connection_has_error(c.data()));
|
||
const QRect windowGeometry(0, 0, 100, 200);
|
||
xcb_window_t w = xcb_generate_id(c.data());
|
||
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
|
||
windowGeometry.x(),
|
||
windowGeometry.y(),
|
||
windowGeometry.width(),
|
||
windowGeometry.height(),
|
||
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
|
||
xcb_size_hints_t hints;
|
||
memset(&hints, 0, sizeof(hints));
|
||
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
|
||
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
|
||
xcb_icccm_size_hints_set_base_size(&hints, windowGeometry.width(), windowGeometry.height());
|
||
xcb_icccm_size_hints_set_resize_inc(&hints, 3, 5);
|
||
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
|
||
xcb_map_window(c.data(), w);
|
||
xcb_flush(c.data());
|
||
|
||
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
|
||
QVERIFY(windowCreatedSpy.isValid());
|
||
QVERIFY(windowCreatedSpy.wait());
|
||
X11Client *client = windowCreatedSpy.last().first().value<X11Client *>();
|
||
QVERIFY(client);
|
||
QVERIFY(client->isDecorated());
|
||
|
||
QSignalSpy clientStartMoveResizedSpy(client, &AbstractClient::clientStartUserMovedResized);
|
||
QVERIFY(clientStartMoveResizedSpy.isValid());
|
||
QSignalSpy clientStepUserMovedResizedSpy(client, &AbstractClient::clientStepUserMovedResized);
|
||
QVERIFY(clientStepUserMovedResizedSpy.isValid());
|
||
QSignalSpy clientFinishUserMovedResizedSpy(client, &AbstractClient::clientFinishUserMovedResized);
|
||
QVERIFY(clientFinishUserMovedResizedSpy.isValid());
|
||
|
||
// Begin resize.
|
||
QCOMPARE(workspace()->moveResizeClient(), nullptr);
|
||
QVERIFY(!client->isResize());
|
||
workspace()->slotWindowResize();
|
||
QCOMPARE(workspace()->moveResizeClient(), client);
|
||
QCOMPARE(clientStartMoveResizedSpy.count(), 1);
|
||
QVERIFY(client->isResize());
|
||
|
||
const QPoint cursorPos = KWin::Cursors::self()->mouse()->pos();
|
||
|
||
client->keyPressEvent(Qt::Key_Right);
|
||
client->updateMoveResize(KWin::Cursors::self()->mouse()->pos());
|
||
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(8, 0));
|
||
QVERIFY(clientStepUserMovedResizedSpy.wait());
|
||
QCOMPARE(clientStepUserMovedResizedSpy.count(), 1);
|
||
QCOMPARE(client->clientSize(), QSize(106, 200));
|
||
|
||
client->keyPressEvent(Qt::Key_Down);
|
||
client->updateMoveResize(KWin::Cursors::self()->mouse()->pos());
|
||
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(8, 8));
|
||
QVERIFY(clientStepUserMovedResizedSpy.wait());
|
||
QCOMPARE(clientStepUserMovedResizedSpy.count(), 2);
|
||
QCOMPARE(client->clientSize(), QSize(106, 205));
|
||
|
||
// Finish the resize operation.
|
||
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 0);
|
||
client->keyPressEvent(Qt::Key_Enter);
|
||
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 1);
|
||
QCOMPARE(workspace()->moveResizeClient(), nullptr);
|
||
QVERIFY(!client->isResize());
|
||
|
||
// Destroy the window.
|
||
QSignalSpy windowClosedSpy(client, &X11Client::windowClosed);
|
||
QVERIFY(windowClosedSpy.isValid());
|
||
xcb_unmap_window(c.data(), w);
|
||
xcb_destroy_window(c.data(), w);
|
||
xcb_flush(c.data());
|
||
QVERIFY(windowClosedSpy.wait());
|
||
c.reset();
|
||
}
|
||
|
||
void X11ClientTest::testResizeIncrementsNoBaseSize()
|
||
{
|
||
// Create an xcb window.
|
||
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
|
||
QVERIFY(!xcb_connection_has_error(c.data()));
|
||
const QRect windowGeometry(0, 0, 100, 200);
|
||
xcb_window_t w = xcb_generate_id(c.data());
|
||
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
|
||
windowGeometry.x(),
|
||
windowGeometry.y(),
|
||
windowGeometry.width(),
|
||
windowGeometry.height(),
|
||
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
|
||
xcb_size_hints_t hints;
|
||
memset(&hints, 0, sizeof(hints));
|
||
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
|
||
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
|
||
xcb_icccm_size_hints_set_min_size(&hints, windowGeometry.width(), windowGeometry.height());
|
||
xcb_icccm_size_hints_set_resize_inc(&hints, 3, 5);
|
||
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
|
||
xcb_map_window(c.data(), w);
|
||
xcb_flush(c.data());
|
||
|
||
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
|
||
QVERIFY(windowCreatedSpy.isValid());
|
||
QVERIFY(windowCreatedSpy.wait());
|
||
X11Client *client = windowCreatedSpy.last().first().value<X11Client *>();
|
||
QVERIFY(client);
|
||
QVERIFY(client->isDecorated());
|
||
|
||
QSignalSpy clientStartMoveResizedSpy(client, &AbstractClient::clientStartUserMovedResized);
|
||
QVERIFY(clientStartMoveResizedSpy.isValid());
|
||
QSignalSpy clientStepUserMovedResizedSpy(client, &AbstractClient::clientStepUserMovedResized);
|
||
QVERIFY(clientStepUserMovedResizedSpy.isValid());
|
||
QSignalSpy clientFinishUserMovedResizedSpy(client, &AbstractClient::clientFinishUserMovedResized);
|
||
QVERIFY(clientFinishUserMovedResizedSpy.isValid());
|
||
|
||
// Begin resize.
|
||
QCOMPARE(workspace()->moveResizeClient(), nullptr);
|
||
QVERIFY(!client->isResize());
|
||
workspace()->slotWindowResize();
|
||
QCOMPARE(workspace()->moveResizeClient(), client);
|
||
QCOMPARE(clientStartMoveResizedSpy.count(), 1);
|
||
QVERIFY(client->isResize());
|
||
|
||
const QPoint cursorPos = KWin::Cursors::self()->mouse()->pos();
|
||
|
||
client->keyPressEvent(Qt::Key_Right);
|
||
client->updateMoveResize(KWin::Cursors::self()->mouse()->pos());
|
||
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(8, 0));
|
||
QVERIFY(clientStepUserMovedResizedSpy.wait());
|
||
QCOMPARE(clientStepUserMovedResizedSpy.count(), 1);
|
||
QCOMPARE(client->clientSize(), QSize(106, 200));
|
||
|
||
client->keyPressEvent(Qt::Key_Down);
|
||
client->updateMoveResize(KWin::Cursors::self()->mouse()->pos());
|
||
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(8, 8));
|
||
QVERIFY(clientStepUserMovedResizedSpy.wait());
|
||
QCOMPARE(clientStepUserMovedResizedSpy.count(), 2);
|
||
QCOMPARE(client->clientSize(), QSize(106, 205));
|
||
|
||
// Finish the resize operation.
|
||
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 0);
|
||
client->keyPressEvent(Qt::Key_Enter);
|
||
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 1);
|
||
QCOMPARE(workspace()->moveResizeClient(), nullptr);
|
||
QVERIFY(!client->isResize());
|
||
|
||
// Destroy the window.
|
||
QSignalSpy windowClosedSpy(client, &X11Client::windowClosed);
|
||
QVERIFY(windowClosedSpy.isValid());
|
||
xcb_unmap_window(c.data(), w);
|
||
xcb_destroy_window(c.data(), w);
|
||
xcb_flush(c.data());
|
||
QVERIFY(windowClosedSpy.wait());
|
||
c.reset();
|
||
}
|
||
|
||
void X11ClientTest::testTrimCaption_data()
|
||
{
|
||
QTest::addColumn<QByteArray>("originalTitle");
|
||
QTest::addColumn<QByteArray>("expectedTitle");
|
||
|
||
QTest::newRow("simplified")
|
||
<< QByteArrayLiteral("Was tun, wenn Schüler Autismus haben?\342\200\250\342\200\250\342\200\250 – Marlies Hübner - Mozilla Firefox")
|
||
<< QByteArrayLiteral("Was tun, wenn Schüler Autismus haben? – Marlies Hübner - Mozilla Firefox");
|
||
|
||
QTest::newRow("with emojis")
|
||
<< QByteArrayLiteral("\bTesting non\302\255printable:\177, emoij:\360\237\230\203, non-characters:\357\277\276")
|
||
<< QByteArrayLiteral("Testing nonprintable:, emoij:\360\237\230\203, non-characters:");
|
||
}
|
||
|
||
void X11ClientTest::testTrimCaption()
|
||
{
|
||
// this test verifies that caption is properly trimmed
|
||
|
||
// create an xcb window
|
||
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
|
||
QVERIFY(!xcb_connection_has_error(c.data()));
|
||
const QRect windowGeometry(0, 0, 100, 200);
|
||
xcb_window_t w = xcb_generate_id(c.data());
|
||
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
|
||
windowGeometry.x(),
|
||
windowGeometry.y(),
|
||
windowGeometry.width(),
|
||
windowGeometry.height(),
|
||
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
|
||
xcb_size_hints_t hints;
|
||
memset(&hints, 0, sizeof(hints));
|
||
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
|
||
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
|
||
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
|
||
NETWinInfo winInfo(c.data(), w, rootWindow(), NET::Properties(), NET::Properties2());
|
||
QFETCH(QByteArray, originalTitle);
|
||
winInfo.setName(originalTitle);
|
||
xcb_map_window(c.data(), w);
|
||
xcb_flush(c.data());
|
||
|
||
// we should get a client for it
|
||
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
|
||
QVERIFY(windowCreatedSpy.isValid());
|
||
QVERIFY(windowCreatedSpy.wait());
|
||
X11Client *client = windowCreatedSpy.first().first().value<X11Client *>();
|
||
QVERIFY(client);
|
||
QCOMPARE(client->window(), w);
|
||
QFETCH(QByteArray, expectedTitle);
|
||
QCOMPARE(client->caption(), QString::fromUtf8(expectedTitle));
|
||
|
||
// and destroy the window again
|
||
xcb_unmap_window(c.data(), w);
|
||
xcb_flush(c.data());
|
||
|
||
QSignalSpy windowClosedSpy(client, &X11Client::windowClosed);
|
||
QVERIFY(windowClosedSpy.isValid());
|
||
QVERIFY(windowClosedSpy.wait());
|
||
xcb_destroy_window(c.data(), w);
|
||
c.reset();
|
||
}
|
||
|
||
void X11ClientTest::testFullscreenLayerWithActiveWaylandWindow()
|
||
{
|
||
// this test verifies that an X11 fullscreen window does not stay in the active layer
|
||
// when a Wayland window is active, see BUG: 375759
|
||
QCOMPARE(screens()->count(), 1);
|
||
|
||
// first create an X11 window
|
||
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
|
||
QVERIFY(!xcb_connection_has_error(c.data()));
|
||
const QRect windowGeometry(0, 0, 100, 200);
|
||
xcb_window_t w = xcb_generate_id(c.data());
|
||
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
|
||
windowGeometry.x(),
|
||
windowGeometry.y(),
|
||
windowGeometry.width(),
|
||
windowGeometry.height(),
|
||
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
|
||
xcb_size_hints_t hints;
|
||
memset(&hints, 0, sizeof(hints));
|
||
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
|
||
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
|
||
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
|
||
xcb_map_window(c.data(), w);
|
||
xcb_flush(c.data());
|
||
|
||
// we should get a client for it
|
||
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
|
||
QVERIFY(windowCreatedSpy.isValid());
|
||
QVERIFY(windowCreatedSpy.wait());
|
||
X11Client *client = windowCreatedSpy.first().first().value<X11Client *>();
|
||
QVERIFY(client);
|
||
QCOMPARE(client->window(), w);
|
||
QVERIFY(!client->isFullScreen());
|
||
QVERIFY(client->isActive());
|
||
QCOMPARE(client->layer(), NormalLayer);
|
||
|
||
workspace()->slotWindowFullScreen();
|
||
QVERIFY(client->isFullScreen());
|
||
QCOMPARE(client->layer(), ActiveLayer);
|
||
QCOMPARE(workspace()->stackingOrder().last(), client);
|
||
|
||
// now let's open a Wayland window
|
||
QScopedPointer<Surface> surface(Test::createSurface());
|
||
QScopedPointer<XdgShellSurface> shellSurface(Test::createXdgShellStableSurface(surface.data()));
|
||
auto waylandClient = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
||
QVERIFY(waylandClient);
|
||
QVERIFY(waylandClient->isActive());
|
||
QCOMPARE(waylandClient->layer(), NormalLayer);
|
||
QCOMPARE(workspace()->stackingOrder().last(), waylandClient);
|
||
QCOMPARE(workspace()->xStackingOrder().last(), waylandClient);
|
||
QCOMPARE(client->layer(), NormalLayer);
|
||
|
||
// now activate fullscreen again
|
||
workspace()->activateClient(client);
|
||
QTRY_VERIFY(client->isActive());
|
||
QCOMPARE(client->layer(), ActiveLayer);
|
||
QCOMPARE(workspace()->stackingOrder().last(), client);
|
||
QCOMPARE(workspace()->xStackingOrder().last(), client);
|
||
|
||
// activate wayland window again
|
||
workspace()->activateClient(waylandClient);
|
||
QTRY_VERIFY(waylandClient->isActive());
|
||
QCOMPARE(workspace()->stackingOrder().last(), waylandClient);
|
||
QCOMPARE(workspace()->xStackingOrder().last(), waylandClient);
|
||
|
||
// back to x window
|
||
workspace()->activateClient(client);
|
||
QTRY_VERIFY(client->isActive());
|
||
// remove fullscreen
|
||
QVERIFY(client->isFullScreen());
|
||
workspace()->slotWindowFullScreen();
|
||
QVERIFY(!client->isFullScreen());
|
||
// and fullscreen again
|
||
workspace()->slotWindowFullScreen();
|
||
QVERIFY(client->isFullScreen());
|
||
QCOMPARE(workspace()->stackingOrder().last(), client);
|
||
QCOMPARE(workspace()->xStackingOrder().last(), client);
|
||
|
||
// activate wayland window again
|
||
workspace()->activateClient(waylandClient);
|
||
QTRY_VERIFY(waylandClient->isActive());
|
||
QCOMPARE(workspace()->stackingOrder().last(), waylandClient);
|
||
QCOMPARE(workspace()->xStackingOrder().last(), waylandClient);
|
||
|
||
// back to X11 window
|
||
workspace()->activateClient(client);
|
||
QTRY_VERIFY(client->isActive());
|
||
// remove fullscreen
|
||
QVERIFY(client->isFullScreen());
|
||
workspace()->slotWindowFullScreen();
|
||
QVERIFY(!client->isFullScreen());
|
||
// and fullscreen through X API
|
||
NETWinInfo info(c.data(), w, kwinApp()->x11RootWindow(), NET::Properties(), NET::Properties2());
|
||
info.setState(NET::FullScreen, NET::FullScreen);
|
||
NETRootInfo rootInfo(c.data(), NET::Properties());
|
||
rootInfo.setActiveWindow(w, NET::FromApplication, XCB_CURRENT_TIME, XCB_WINDOW_NONE);
|
||
xcb_flush(c.data());
|
||
QTRY_VERIFY(client->isFullScreen());
|
||
QCOMPARE(workspace()->stackingOrder().last(), client);
|
||
QCOMPARE(workspace()->xStackingOrder().last(), client);
|
||
|
||
// activate wayland window again
|
||
workspace()->activateClient(waylandClient);
|
||
QTRY_VERIFY(waylandClient->isActive());
|
||
QCOMPARE(workspace()->stackingOrder().last(), waylandClient);
|
||
QCOMPARE(workspace()->xStackingOrder().last(), waylandClient);
|
||
QCOMPARE(client->layer(), NormalLayer);
|
||
|
||
// close the window
|
||
shellSurface.reset();
|
||
surface.reset();
|
||
QVERIFY(Test::waitForWindowDestroyed(waylandClient));
|
||
QTRY_VERIFY(client->isActive());
|
||
QCOMPARE(client->layer(), ActiveLayer);
|
||
|
||
// and destroy the window again
|
||
xcb_unmap_window(c.data(), w);
|
||
xcb_flush(c.data());
|
||
}
|
||
|
||
void X11ClientTest::testFocusInWithWaylandLastActiveWindow()
|
||
{
|
||
// this test verifies that Workspace::allowClientActivation does not crash if last client was a Wayland client
|
||
|
||
// create an X11 window
|
||
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
|
||
QVERIFY(!xcb_connection_has_error(c.data()));
|
||
const QRect windowGeometry(0, 0, 100, 200);
|
||
xcb_window_t w = xcb_generate_id(c.data());
|
||
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
|
||
windowGeometry.x(),
|
||
windowGeometry.y(),
|
||
windowGeometry.width(),
|
||
windowGeometry.height(),
|
||
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
|
||
xcb_size_hints_t hints;
|
||
memset(&hints, 0, sizeof(hints));
|
||
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
|
||
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
|
||
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
|
||
xcb_map_window(c.data(), w);
|
||
xcb_flush(c.data());
|
||
|
||
// we should get a client for it
|
||
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
|
||
QVERIFY(windowCreatedSpy.isValid());
|
||
QVERIFY(windowCreatedSpy.wait());
|
||
X11Client *client = windowCreatedSpy.first().first().value<X11Client *>();
|
||
QVERIFY(client);
|
||
QCOMPARE(client->window(), w);
|
||
QVERIFY(client->isActive());
|
||
|
||
// create Wayland window
|
||
QScopedPointer<Surface> surface(Test::createSurface());
|
||
QScopedPointer<XdgShellSurface> shellSurface(Test::createXdgShellStableSurface(surface.data()));
|
||
auto waylandClient = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
||
QVERIFY(waylandClient);
|
||
QVERIFY(waylandClient->isActive());
|
||
// activate no window
|
||
workspace()->setActiveClient(nullptr);
|
||
QVERIFY(!waylandClient->isActive());
|
||
QVERIFY(!workspace()->activeClient());
|
||
// and close Wayland window again
|
||
shellSurface.reset();
|
||
surface.reset();
|
||
QVERIFY(Test::waitForWindowDestroyed(waylandClient));
|
||
|
||
// and try to activate the x11 client through X11 api
|
||
const auto cookie = xcb_set_input_focus_checked(c.data(), XCB_INPUT_FOCUS_NONE, w, XCB_CURRENT_TIME);
|
||
auto error = xcb_request_check(c.data(), cookie);
|
||
QVERIFY(!error);
|
||
// this accesses last_active_client on trying to activate
|
||
QTRY_VERIFY(client->isActive());
|
||
|
||
// and destroy the window again
|
||
xcb_unmap_window(c.data(), w);
|
||
xcb_flush(c.data());
|
||
}
|
||
|
||
void X11ClientTest::testX11WindowId()
|
||
{
|
||
// create an X11 window
|
||
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
|
||
QVERIFY(!xcb_connection_has_error(c.data()));
|
||
const QRect windowGeometry(0, 0, 100, 200);
|
||
xcb_window_t w = xcb_generate_id(c.data());
|
||
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
|
||
windowGeometry.x(),
|
||
windowGeometry.y(),
|
||
windowGeometry.width(),
|
||
windowGeometry.height(),
|
||
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
|
||
xcb_size_hints_t hints;
|
||
memset(&hints, 0, sizeof(hints));
|
||
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
|
||
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
|
||
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
|
||
xcb_map_window(c.data(), w);
|
||
xcb_flush(c.data());
|
||
|
||
// we should get a client for it
|
||
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
|
||
QVERIFY(windowCreatedSpy.isValid());
|
||
QVERIFY(windowCreatedSpy.wait());
|
||
X11Client *client = windowCreatedSpy.first().first().value<X11Client *>();
|
||
QVERIFY(client);
|
||
QCOMPARE(client->window(), w);
|
||
QVERIFY(client->isActive());
|
||
QCOMPARE(client->window(), w);
|
||
QCOMPARE(client->internalId().isNull(), false);
|
||
const auto uuid = client->internalId();
|
||
QUuid deletedUuid;
|
||
QCOMPARE(deletedUuid.isNull(), true);
|
||
|
||
connect(client, &X11Client::windowClosed, this, [&deletedUuid] (Toplevel *, Deleted *d) { deletedUuid = d->internalId(); });
|
||
|
||
|
||
NETRootInfo rootInfo(c.data(), NET::WMAllProperties);
|
||
QCOMPARE(rootInfo.activeWindow(), client->window());
|
||
|
||
// activate a wayland window
|
||
QScopedPointer<Surface> surface(Test::createSurface());
|
||
QScopedPointer<XdgShellSurface> shellSurface(Test::createXdgShellStableSurface(surface.data()));
|
||
auto waylandClient = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
||
QVERIFY(waylandClient);
|
||
QVERIFY(waylandClient->isActive());
|
||
xcb_flush(kwinApp()->x11Connection());
|
||
|
||
NETRootInfo rootInfo2(c.data(), NET::WMAllProperties);
|
||
QCOMPARE(rootInfo2.activeWindow(), 0u);
|
||
|
||
// back to X11 client
|
||
shellSurface.reset();
|
||
surface.reset();
|
||
QVERIFY(Test::waitForWindowDestroyed(waylandClient));
|
||
|
||
QTRY_VERIFY(client->isActive());
|
||
NETRootInfo rootInfo3(c.data(), NET::WMAllProperties);
|
||
QCOMPARE(rootInfo3.activeWindow(), client->window());
|
||
|
||
// and destroy the window again
|
||
xcb_unmap_window(c.data(), w);
|
||
xcb_flush(c.data());
|
||
QSignalSpy windowClosedSpy(client, &X11Client::windowClosed);
|
||
QVERIFY(windowClosedSpy.isValid());
|
||
QVERIFY(windowClosedSpy.wait());
|
||
|
||
QCOMPARE(deletedUuid.isNull(), false);
|
||
QCOMPARE(deletedUuid, uuid);
|
||
}
|
||
|
||
void X11ClientTest::testCaptionChanges()
|
||
{
|
||
// verifies that caption is updated correctly when the X11 window updates it
|
||
// BUG: 383444
|
||
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
|
||
QVERIFY(!xcb_connection_has_error(c.data()));
|
||
const QRect windowGeometry(0, 0, 100, 200);
|
||
xcb_window_t w = xcb_generate_id(c.data());
|
||
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
|
||
windowGeometry.x(),
|
||
windowGeometry.y(),
|
||
windowGeometry.width(),
|
||
windowGeometry.height(),
|
||
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
|
||
xcb_size_hints_t hints;
|
||
memset(&hints, 0, sizeof(hints));
|
||
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
|
||
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
|
||
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
|
||
NETWinInfo info(c.data(), w, kwinApp()->x11RootWindow(), NET::Properties(), NET::Properties2());
|
||
info.setName("foo");
|
||
xcb_map_window(c.data(), w);
|
||
xcb_flush(c.data());
|
||
|
||
// we should get a client for it
|
||
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
|
||
QVERIFY(windowCreatedSpy.isValid());
|
||
QVERIFY(windowCreatedSpy.wait());
|
||
X11Client *client = windowCreatedSpy.first().first().value<X11Client *>();
|
||
QVERIFY(client);
|
||
QCOMPARE(client->window(), w);
|
||
QCOMPARE(client->caption(), QStringLiteral("foo"));
|
||
|
||
QSignalSpy captionChangedSpy(client, &X11Client::captionChanged);
|
||
QVERIFY(captionChangedSpy.isValid());
|
||
info.setName("bar");
|
||
xcb_flush(c.data());
|
||
QVERIFY(captionChangedSpy.wait());
|
||
QCOMPARE(client->caption(), QStringLiteral("bar"));
|
||
|
||
// and destroy the window again
|
||
QSignalSpy windowClosedSpy(client, &X11Client::windowClosed);
|
||
QVERIFY(windowClosedSpy.isValid());
|
||
xcb_unmap_window(c.data(), w);
|
||
xcb_flush(c.data());
|
||
QVERIFY(windowClosedSpy.wait());
|
||
xcb_destroy_window(c.data(), w);
|
||
c.reset();
|
||
}
|
||
|
||
void X11ClientTest::testCaptionWmName()
|
||
{
|
||
// this test verifies that a caption set through WM_NAME is read correctly
|
||
|
||
// open glxgears as that one only uses WM_NAME
|
||
QSignalSpy clientAddedSpy(workspace(), &Workspace::clientAdded);
|
||
QVERIFY(clientAddedSpy.isValid());
|
||
|
||
QProcess glxgears;
|
||
glxgears.setProgram(QStringLiteral("glxgears"));
|
||
glxgears.start();
|
||
QVERIFY(glxgears.waitForStarted());
|
||
|
||
QVERIFY(clientAddedSpy.wait());
|
||
QCOMPARE(clientAddedSpy.count(), 1);
|
||
QCOMPARE(workspace()->clientList().count(), 1);
|
||
X11Client *glxgearsClient = workspace()->clientList().first();
|
||
QCOMPARE(glxgearsClient->caption(), QStringLiteral("glxgears"));
|
||
|
||
glxgears.terminate();
|
||
QVERIFY(glxgears.waitForFinished());
|
||
}
|
||
|
||
void X11ClientTest::testCaptionMultipleWindows()
|
||
{
|
||
// BUG 384760
|
||
// create first window
|
||
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
|
||
QVERIFY(!xcb_connection_has_error(c.data()));
|
||
const QRect windowGeometry(0, 0, 100, 200);
|
||
xcb_window_t w = xcb_generate_id(c.data());
|
||
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
|
||
windowGeometry.x(),
|
||
windowGeometry.y(),
|
||
windowGeometry.width(),
|
||
windowGeometry.height(),
|
||
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
|
||
xcb_size_hints_t hints;
|
||
memset(&hints, 0, sizeof(hints));
|
||
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
|
||
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
|
||
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
|
||
NETWinInfo info(c.data(), w, kwinApp()->x11RootWindow(), NET::Properties(), NET::Properties2());
|
||
info.setName("foo");
|
||
xcb_map_window(c.data(), w);
|
||
xcb_flush(c.data());
|
||
|
||
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
|
||
QVERIFY(windowCreatedSpy.isValid());
|
||
QVERIFY(windowCreatedSpy.wait());
|
||
X11Client *client = windowCreatedSpy.first().first().value<X11Client *>();
|
||
QVERIFY(client);
|
||
QCOMPARE(client->window(), w);
|
||
QCOMPARE(client->caption(), QStringLiteral("foo"));
|
||
|
||
// create second window with same caption
|
||
xcb_window_t w2 = xcb_generate_id(c.data());
|
||
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w2, rootWindow(),
|
||
windowGeometry.x(),
|
||
windowGeometry.y(),
|
||
windowGeometry.width(),
|
||
windowGeometry.height(),
|
||
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
|
||
xcb_icccm_set_wm_normal_hints(c.data(), w2, &hints);
|
||
NETWinInfo info2(c.data(), w2, kwinApp()->x11RootWindow(), NET::Properties(), NET::Properties2());
|
||
info2.setName("foo");
|
||
info2.setIconName("foo");
|
||
xcb_map_window(c.data(), w2);
|
||
xcb_flush(c.data());
|
||
|
||
windowCreatedSpy.clear();
|
||
QVERIFY(windowCreatedSpy.wait());
|
||
X11Client *client2 = windowCreatedSpy.first().first().value<X11Client *>();
|
||
QVERIFY(client2);
|
||
QCOMPARE(client2->window(), w2);
|
||
QCOMPARE(client2->caption(), QStringLiteral("foo <2>\u200E"));
|
||
NETWinInfo info3(kwinApp()->x11Connection(), w2, kwinApp()->x11RootWindow(), NET::WMVisibleName | NET::WMVisibleIconName, NET::Properties2());
|
||
QCOMPARE(QByteArray(info3.visibleName()), QByteArrayLiteral("foo <2>\u200E"));
|
||
QCOMPARE(QByteArray(info3.visibleIconName()), QByteArrayLiteral("foo <2>\u200E"));
|
||
|
||
QSignalSpy captionChangedSpy(client2, &X11Client::captionChanged);
|
||
QVERIFY(captionChangedSpy.isValid());
|
||
|
||
NETWinInfo info4(c.data(), w2, kwinApp()->x11RootWindow(), NET::Properties(), NET::Properties2());
|
||
info4.setName("foobar");
|
||
info4.setIconName("foobar");
|
||
xcb_map_window(c.data(), w2);
|
||
xcb_flush(c.data());
|
||
|
||
QVERIFY(captionChangedSpy.wait());
|
||
QCOMPARE(client2->caption(), QStringLiteral("foobar"));
|
||
NETWinInfo info5(kwinApp()->x11Connection(), w2, kwinApp()->x11RootWindow(), NET::WMVisibleName | NET::WMVisibleIconName, NET::Properties2());
|
||
QCOMPARE(QByteArray(info5.visibleName()), QByteArray());
|
||
QTRY_COMPARE(QByteArray(info5.visibleIconName()), QByteArray());
|
||
}
|
||
|
||
|
||
void X11ClientTest::testFullscreenWindowGroups()
|
||
{
|
||
// this test creates an X11 window and puts it to full screen
|
||
// then a second window is created which is in the same window group
|
||
// BUG: 388310
|
||
|
||
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
|
||
QVERIFY(!xcb_connection_has_error(c.data()));
|
||
const QRect windowGeometry(0, 0, 100, 200);
|
||
xcb_window_t w = xcb_generate_id(c.data());
|
||
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
|
||
windowGeometry.x(),
|
||
windowGeometry.y(),
|
||
windowGeometry.width(),
|
||
windowGeometry.height(),
|
||
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
|
||
xcb_size_hints_t hints;
|
||
memset(&hints, 0, sizeof(hints));
|
||
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
|
||
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
|
||
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
|
||
xcb_change_property(c.data(), XCB_PROP_MODE_REPLACE, w, atoms->wm_client_leader, XCB_ATOM_WINDOW, 32, 1, &w);
|
||
xcb_map_window(c.data(), w);
|
||
xcb_flush(c.data());
|
||
|
||
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
|
||
QVERIFY(windowCreatedSpy.isValid());
|
||
QVERIFY(windowCreatedSpy.wait());
|
||
X11Client *client = windowCreatedSpy.first().first().value<X11Client *>();
|
||
QVERIFY(client);
|
||
QCOMPARE(client->window(), w);
|
||
QCOMPARE(client->isActive(), true);
|
||
|
||
QCOMPARE(client->isFullScreen(), false);
|
||
QCOMPARE(client->layer(), NormalLayer);
|
||
workspace()->slotWindowFullScreen();
|
||
QCOMPARE(client->isFullScreen(), true);
|
||
QCOMPARE(client->layer(), ActiveLayer);
|
||
|
||
// now let's create a second window
|
||
windowCreatedSpy.clear();
|
||
xcb_window_t w2 = xcb_generate_id(c.data());
|
||
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w2, rootWindow(),
|
||
windowGeometry.x(),
|
||
windowGeometry.y(),
|
||
windowGeometry.width(),
|
||
windowGeometry.height(),
|
||
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
|
||
xcb_size_hints_t hints2;
|
||
memset(&hints2, 0, sizeof(hints2));
|
||
xcb_icccm_size_hints_set_position(&hints2, 1, windowGeometry.x(), windowGeometry.y());
|
||
xcb_icccm_size_hints_set_size(&hints2, 1, windowGeometry.width(), windowGeometry.height());
|
||
xcb_icccm_set_wm_normal_hints(c.data(), w2, &hints2);
|
||
xcb_change_property(c.data(), XCB_PROP_MODE_REPLACE, w2, atoms->wm_client_leader, XCB_ATOM_WINDOW, 32, 1, &w);
|
||
xcb_map_window(c.data(), w2);
|
||
xcb_flush(c.data());
|
||
|
||
QVERIFY(windowCreatedSpy.wait());
|
||
X11Client *client2 = windowCreatedSpy.first().first().value<X11Client *>();
|
||
QVERIFY(client2);
|
||
QVERIFY(client != client2);
|
||
QCOMPARE(client2->window(), w2);
|
||
QCOMPARE(client2->isActive(), true);
|
||
QCOMPARE(client2->group(), client->group());
|
||
// first client should be moved back to normal layer
|
||
QCOMPARE(client->isActive(), false);
|
||
QCOMPARE(client->isFullScreen(), true);
|
||
QCOMPARE(client->layer(), NormalLayer);
|
||
|
||
// activating the fullscreen window again, should move it to active layer
|
||
workspace()->activateClient(client);
|
||
QTRY_COMPARE(client->layer(), ActiveLayer);
|
||
}
|
||
|
||
void X11ClientTest::testActivateFocusedWindow()
|
||
{
|
||
// The window manager may call XSetInputFocus() on a window that already has focus, in which
|
||
// case no FocusIn event will be generated and the window won't be marked as active. This test
|
||
// verifies that we handle that subtle case properly.
|
||
|
||
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> connection(xcb_connect(nullptr, nullptr));
|
||
QVERIFY(!xcb_connection_has_error(connection.data()));
|
||
|
||
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
|
||
QVERIFY(windowCreatedSpy.isValid());
|
||
|
||
const QRect windowGeometry(0, 0, 100, 200);
|
||
xcb_size_hints_t hints;
|
||
memset(&hints, 0, sizeof(hints));
|
||
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
|
||
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
|
||
|
||
// Create the first test window.
|
||
const xcb_window_t window1 = xcb_generate_id(connection.data());
|
||
xcb_create_window(connection.data(), XCB_COPY_FROM_PARENT, window1, rootWindow(),
|
||
windowGeometry.x(), windowGeometry.y(),
|
||
windowGeometry.width(), windowGeometry.height(),
|
||
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
|
||
xcb_icccm_set_wm_normal_hints(connection.data(), window1, &hints);
|
||
xcb_change_property(connection.data(), XCB_PROP_MODE_REPLACE, window1,
|
||
atoms->wm_client_leader, XCB_ATOM_WINDOW, 32, 1, &window1);
|
||
xcb_map_window(connection.data(), window1);
|
||
xcb_flush(connection.data());
|
||
QVERIFY(windowCreatedSpy.wait());
|
||
X11Client *client1 = windowCreatedSpy.first().first().value<X11Client *>();
|
||
QVERIFY(client1);
|
||
QCOMPARE(client1->window(), window1);
|
||
QCOMPARE(client1->isActive(), true);
|
||
|
||
// Create the second test window.
|
||
const xcb_window_t window2 = xcb_generate_id(connection.data());
|
||
xcb_create_window(connection.data(), XCB_COPY_FROM_PARENT, window2, rootWindow(),
|
||
windowGeometry.x(), windowGeometry.y(),
|
||
windowGeometry.width(), windowGeometry.height(),
|
||
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
|
||
xcb_icccm_set_wm_normal_hints(connection.data(), window2, &hints);
|
||
xcb_change_property(connection.data(), XCB_PROP_MODE_REPLACE, window2,
|
||
atoms->wm_client_leader, XCB_ATOM_WINDOW, 32, 1, &window2);
|
||
xcb_map_window(connection.data(), window2);
|
||
xcb_flush(connection.data());
|
||
QVERIFY(windowCreatedSpy.wait());
|
||
X11Client *client2 = windowCreatedSpy.last().first().value<X11Client *>();
|
||
QVERIFY(client2);
|
||
QCOMPARE(client2->window(), window2);
|
||
QCOMPARE(client2->isActive(), true);
|
||
|
||
// When the second test window is destroyed, the window manager will attempt to activate the
|
||
// next client in the focus chain, which is the first window.
|
||
xcb_set_input_focus(connection.data(), XCB_INPUT_FOCUS_POINTER_ROOT, window1, XCB_CURRENT_TIME);
|
||
xcb_destroy_window(connection.data(), window2);
|
||
xcb_flush(connection.data());
|
||
QVERIFY(Test::waitForWindowDestroyed(client2));
|
||
QVERIFY(client1->isActive());
|
||
|
||
// Destroy the first test window.
|
||
xcb_destroy_window(connection.data(), window1);
|
||
xcb_flush(connection.data());
|
||
QVERIFY(Test::waitForWindowDestroyed(client1));
|
||
}
|
||
|
||
void X11ClientTest::testReentrantSetFrameGeometry()
|
||
{
|
||
// This test verifies that calling setFrameGeometry() from a slot connected directly
|
||
// to the frameGeometryChanged() signal won't cause an infinite recursion.
|
||
|
||
// Create a test window.
|
||
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
|
||
QVERIFY(!xcb_connection_has_error(c.data()));
|
||
const QRect windowGeometry(0, 0, 100, 200);
|
||
xcb_window_t w = xcb_generate_id(c.data());
|
||
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
|
||
windowGeometry.x(),
|
||
windowGeometry.y(),
|
||
windowGeometry.width(),
|
||
windowGeometry.height(),
|
||
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
|
||
xcb_size_hints_t hints;
|
||
memset(&hints, 0, sizeof(hints));
|
||
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
|
||
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
|
||
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
|
||
xcb_change_property(c.data(), XCB_PROP_MODE_REPLACE, w, atoms->wm_client_leader, XCB_ATOM_WINDOW, 32, 1, &w);
|
||
xcb_map_window(c.data(), w);
|
||
xcb_flush(c.data());
|
||
|
||
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
|
||
QVERIFY(windowCreatedSpy.isValid());
|
||
QVERIFY(windowCreatedSpy.wait());
|
||
X11Client *client = windowCreatedSpy.first().first().value<X11Client *>();
|
||
QVERIFY(client);
|
||
QCOMPARE(client->pos(), QPoint(0, 0));
|
||
|
||
// Let's pretend that there is a script that really wants the client to be at (100, 100).
|
||
connect(client, &AbstractClient::frameGeometryChanged, this, [client]() {
|
||
client->setFrameGeometry(QRect(QPoint(100, 100), client->size()));
|
||
});
|
||
|
||
// Trigger the lambda above.
|
||
client->move(QPoint(40, 50));
|
||
|
||
// Eventually, the client will end up at (100, 100).
|
||
QCOMPARE(client->pos(), QPoint(100, 100));
|
||
|
||
// Destroy the test window.
|
||
xcb_destroy_window(c.data(), w);
|
||
xcb_flush(c.data());
|
||
QVERIFY(Test::waitForWindowDestroyed(client));
|
||
}
|
||
|
||
WAYLANDTEST_MAIN(X11ClientTest)
|
||
#include "x11_client_test.moc"
|