My KWIN fork where I work on features like per-output virtual desktops
Find a file
Alex Richardson af3602b48c Fix out-of-bounds copy in xcb_send_event() calls
xcb_send_event always copies 32 bytes, so we have to pad all xcb_*_event_t
to 32 bytes to avoid leaking uninitialized stack memory. I found this
problem while running kwin_x11 on a CHERI-RISC-V system (which has bounded
pointers). The xcb_send_event() implementation has a memcpy() that was
copying 32 bytes but the event passed was a bounded to 28 bytes, so this
resulted in a run-time exception in X11Client::sendClientMessage().
The same problem exists in Selection::sendSelectionNotify(), but this time
we could end up copying up to 8 bytes since xcb_selection_notify_event_t
is only 24 bytes.

This disclosure of uninitialized data could in theory have a security
impact if it leaks a pointer value (e.g. a return address) as part of an
exploit chain that needs to bypass ASLR. However, the selection notify
events go directly to the XServer and you most likely already have a
serious problem if an attacker has full control over the XServer. It is
possible that the configure notify events go directly to an untrusted
client, but even if they do this leak is not directly exploitable.

See also https://gitlab.freedesktop.org/xorg/lib/libxcb/-/issues/18
2021-09-09 15:03:44 +01:00
autotests Fix xwayland copying unit test 2021-09-09 11:13:02 +00:00
cmake/modules Refactor session code 2021-03-23 08:01:19 +00:00
data Remove Xrender backend 2021-06-09 11:21:57 +03:00
doc doc: modernise HACKING -> CONTRIBUTING guidelines and information 2021-08-31 22:10:58 +00:00
kconf_update kwinrules: Use a list of desktop UUIDs to set and store the rules setting 2021-09-02 22:11:46 +02:00
LICENSES
src Fix out-of-bounds copy in xcb_send_event() calls 2021-09-09 15:03:44 +01:00
tests Run clazy with qt-keywords fixit 2021-06-08 10:49:42 +03:00
.gitignore GIT_SILENT Add auto generated files to .gitignore 2021-05-03 14:58:25 +02:00
CMakeLists.txt Set a minimum version check for pipewire 2021-09-04 04:24:07 +02:00
CONTRIBUTING.md doc: modernise HACKING -> CONTRIBUTING guidelines and information 2021-08-31 22:10:58 +00:00
KWinDBusInterfaceConfig.cmake.in inputmethod: Provide DBus API so the shell can integrate with it 2021-03-02 13:55:35 +00:00
logo.png
Mainpage.dox
plasma-kwin_wayland.service.in Update systemd units 2020-09-29 06:10:20 +00:00
plasma-kwin_x11.service.in Update systemd units 2020-09-29 06:10:20 +00:00
README.md doc: modernise HACKING -> CONTRIBUTING guidelines and information 2021-08-31 22:10:58 +00:00

KWin

KWin is an easy to use, but flexible, composited Window Manager for Xorg windowing systems (Wayland, X11) on Linux. Its primary usage is in conjunction with a Desktop Shell (e.g. KDE Plasma Desktop). KWin is designed to go out of the way; users should not notice that they use a window manager at all. Nevertheless KWin provides a steep learning curve for advanced features, which are available, if they do not conflict with the primary mission. KWin does not have a dedicated targeted user group, but follows the targeted user group of the Desktop Shell using KWin as it's window manager.

KWin is not...

  • a standalone window manager (c.f. openbox, i3) and does not provide any functionality belonging to a Desktop Shell.
  • a replacement for window managers designed for use with a specific Desktop Shell (e.g. GNOME Shell)
  • a minimalistic window manager
  • designed for use without compositing or for X11 network transparency, though both are possible.

Contributing to KWin

Please refer to the contributing document for everything you need to know to get started contributing to KWin.

Contacting KWin development team

  • mailing list: kwin@kde.org
  • IRC: #kde-kwin on irc.libera.chat

Support

Application Developer

If you are an application developer having questions regarding windowing systems (either X11 or Wayland) please do not hesitate to contact us. Preferable through our mailing list. Ideally subscribe to the mailing list, so that your mail doesn't get stuck in the moderation queue.

End user

Please contact the support channels of your Linux distribution for user support. The KWin development team does not provide end user support.

Reporting bugs

Please use KDE's bugtracker and report for product KWin.

Guidelines for new features

A new Feature can only be added to KWin if:

  • it does not violate the primary missions as stated at the start of this document
  • it does not introduce instabilities
  • it is maintained, that is bugs are fixed in a timely manner (second next minor release) if it is not a corner case.
  • it works together with all existing features
  • it supports both single and multi screen (xrandr)
  • it adds a significant advantage
  • it is feature complete, that is supports at least all useful features from competitive implementations
  • it is not a special case for a small user group
  • it does not increase code complexity significantly
  • it does not affect KWin's license (GPLv2+)

All new added features are under probation, that is if any of the non-functional requirements as listed above do not hold true in the next two feature releases, the added feature will be removed again.

The same non functional requirements hold true for any kind of plugins (effects, scripts, etc.). It is suggested to use scripted plugins and distribute them separately.