2b196bfa29
Summary: To use eglCreateImageKhr for an X11 pixmap we need an EGLDisplay created for the same XDisplay as the X11 pixmap. This means if we created an EGLDisplay for a GBM device, we are not allowed to load a texture from the X11 pixmap and can result in a crash in the driver. Similar in the nested X11 setup the EGLDisplay is created for the rendering window, but the X11 pixmaps are from the Xwayland server KWin started. They don't belong to the same windowing system. This change addresses this problem by moving the loading of X11 pixmaps from AbstractEglTexture to EglTexture of the EglOnX11Backend. Thus for any usage on a non X11 platform we cannot hit the code path any more. In addition the nested X11 platform can indicate that it doesn't support it and thus also doesn't go through the code path. Test Plan: Tested standalone and nested X11 platform Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D1857
119 lines
3.4 KiB
C++
119 lines
3.4 KiB
C++
/********************************************************************
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
Copyright (C) 2015 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*********************************************************************/
|
|
#include "egl_x11_backend.h"
|
|
// kwin
|
|
#include "screens.h"
|
|
#include "x11windowed_backend.h"
|
|
// kwin libs
|
|
#include <kwinglplatform.h>
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
EglX11Backend::EglX11Backend(X11WindowedBackend *backend)
|
|
: EglOnXBackend(backend->connection(), backend->display(), backend->rootWindow(), backend->screenNumer(), XCB_WINDOW_NONE)
|
|
, m_backend(backend)
|
|
{
|
|
setX11TextureFromPixmapSupported(false);
|
|
}
|
|
|
|
EglX11Backend::~EglX11Backend() = default;
|
|
|
|
void EglX11Backend::cleanupSurfaces()
|
|
{
|
|
for (auto it = m_surfaces.begin(); it != m_surfaces.end(); ++it) {
|
|
eglDestroySurface(eglDisplay(), *it);
|
|
}
|
|
}
|
|
|
|
bool EglX11Backend::createSurfaces()
|
|
{
|
|
for (int i = 0; i < screens()->count(); ++i) {
|
|
EGLSurface s = createSurface(m_backend->windowForScreen(i));
|
|
if (s == EGL_NO_SURFACE) {
|
|
return false;
|
|
}
|
|
m_surfaces << s;
|
|
}
|
|
if (m_surfaces.isEmpty()) {
|
|
return false;
|
|
}
|
|
setSurface(m_surfaces.first());
|
|
return true;
|
|
}
|
|
|
|
void EglX11Backend::present()
|
|
{
|
|
for (int i = 0; i < screens()->count(); ++i) {
|
|
EGLSurface s = m_surfaces.at(i);
|
|
makeContextCurrent(s);
|
|
setupViewport(i);
|
|
presentSurface(s, screens()->geometry(i), screens()->geometry(i));
|
|
}
|
|
eglWaitGL();
|
|
xcb_flush(m_backend->connection());
|
|
}
|
|
|
|
QRegion EglX11Backend::prepareRenderingFrame()
|
|
{
|
|
startRenderTimer();
|
|
return QRegion();
|
|
}
|
|
|
|
void EglX11Backend::endRenderingFrame(const QRegion &renderedRegion, const QRegion &damagedRegion)
|
|
{
|
|
Q_UNUSED(renderedRegion)
|
|
Q_UNUSED(damagedRegion)
|
|
}
|
|
|
|
bool EglX11Backend::usesOverlayWindow() const
|
|
{
|
|
return false;
|
|
}
|
|
|
|
bool EglX11Backend::perScreenRendering() const
|
|
{
|
|
return true;
|
|
}
|
|
|
|
QRegion EglX11Backend::prepareRenderingForScreen(int screenId)
|
|
{
|
|
makeContextCurrent(m_surfaces.at(screenId));
|
|
setupViewport(screenId);
|
|
return screens()->geometry(screenId);
|
|
}
|
|
|
|
void EglX11Backend::setupViewport(int screenId)
|
|
{
|
|
// TODO: ensure the viewport is set correctly each time
|
|
const QSize &overall = screens()->size();
|
|
const QRect &v = screens()->geometry(screenId);
|
|
// TODO: are the values correct?
|
|
glViewport(-v.x(), v.height() - overall.height() - v.y(), overall.width(), overall.height());
|
|
}
|
|
|
|
void EglX11Backend::endRenderingFrameForScreen(int screenId, const QRegion &renderedRegion, const QRegion &damagedRegion)
|
|
{
|
|
Q_UNUSED(damagedRegion)
|
|
const QRect &outputGeometry = screens()->geometry(screenId);
|
|
presentSurface(m_surfaces.at(screenId), renderedRegion, outputGeometry);
|
|
}
|
|
|
|
} // namespace
|