kwin/libinput/events.h
Vlad Zagorodniy 8af2fa73dc Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.

The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.

Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.

A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!

The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.

The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.

Test Plan: Compiles.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: davidedmundson, apol, romangg, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 20:03:22 +03:00

203 lines
4.6 KiB
C++

/********************************************************************
KWin - the KDE window manager
This file is part of the KDE project.
Copyright (C) 2014 Martin Gräßlin <mgraesslin@kde.org>
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*********************************************************************/
#ifndef KWIN_LIBINPUT_EVENTS_H
#define KWIN_LIBINPUT_EVENTS_H
#include "../input.h"
#include <libinput.h>
namespace KWin
{
namespace LibInput
{
class Device;
class Event
{
public:
virtual ~Event();
libinput_event_type type() const;
Device *device() const;
libinput_device *nativeDevice() const;
operator libinput_event*() {
return m_event;
}
operator libinput_event*() const {
return m_event;
}
static Event *create(libinput_event *event);
protected:
Event(libinput_event *event, libinput_event_type type);
private:
libinput_event *m_event;
libinput_event_type m_type;
mutable Device *m_device;
};
class KeyEvent : public Event
{
public:
KeyEvent(libinput_event *event);
~KeyEvent() override;
uint32_t key() const;
InputRedirection::KeyboardKeyState state() const;
uint32_t time() const;
operator libinput_event_keyboard*() {
return m_keyboardEvent;
}
operator libinput_event_keyboard*() const {
return m_keyboardEvent;
}
private:
libinput_event_keyboard *m_keyboardEvent;
};
class PointerEvent : public Event
{
public:
PointerEvent(libinput_event* event, libinput_event_type type);
~PointerEvent() override;
QPointF absolutePos() const;
QPointF absolutePos(const QSize &size) const;
QSizeF delta() const;
QSizeF deltaUnaccelerated() const;
uint32_t button() const;
InputRedirection::PointerButtonState buttonState() const;
uint32_t time() const;
quint64 timeMicroseconds() const;
QVector<InputRedirection::PointerAxis> axis() const;
qreal axisValue(InputRedirection::PointerAxis a) const;
qint32 discreteAxisValue(InputRedirection::PointerAxis axis) const;
InputRedirection::PointerAxisSource axisSource() const;
operator libinput_event_pointer*() {
return m_pointerEvent;
}
operator libinput_event_pointer*() const {
return m_pointerEvent;
}
private:
libinput_event_pointer *m_pointerEvent;
};
class TouchEvent : public Event
{
public:
TouchEvent(libinput_event *event, libinput_event_type type);
~TouchEvent() override;
quint32 time() const;
QPointF absolutePos() const;
QPointF absolutePos(const QSize &size) const;
qint32 id() const;
operator libinput_event_touch*() {
return m_touchEvent;
}
operator libinput_event_touch*() const {
return m_touchEvent;
}
private:
libinput_event_touch *m_touchEvent;
};
class GestureEvent : public Event
{
public:
~GestureEvent() override;
quint32 time() const;
int fingerCount() const;
QSizeF delta() const;
bool isCancelled() const;
operator libinput_event_gesture*() {
return m_gestureEvent;
}
operator libinput_event_gesture*() const {
return m_gestureEvent;
}
protected:
GestureEvent(libinput_event *event, libinput_event_type type);
libinput_event_gesture *m_gestureEvent;
};
class PinchGestureEvent : public GestureEvent
{
public:
PinchGestureEvent(libinput_event *event, libinput_event_type type);
~PinchGestureEvent() override;
qreal scale() const;
qreal angleDelta() const;
};
class SwipeGestureEvent : public GestureEvent
{
public:
SwipeGestureEvent(libinput_event *event, libinput_event_type type);
~SwipeGestureEvent() override;
};
class SwitchEvent : public Event
{
public:
SwitchEvent(libinput_event *event, libinput_event_type type);
~SwitchEvent() override;
enum class State {
Off,
On
};
State state() const;
quint32 time() const;
quint64 timeMicroseconds() const;
private:
libinput_event_switch *m_switchEvent;
};
inline
libinput_event_type Event::type() const
{
return m_type;
}
}
}
#endif