e107910b30
With 4933f08ae49328e36e2654434d28917310882ee5 the KDecorationBridge interface became public to allow Compiz to easily implement the class. From a KWin perspective this change did not make much sense. The Bridge is meant to be the interface towards KWin. It is an internal interface and exporting it doesn't change the fact that it is internal. The change got introduced in a time when it was still common to use Compiz in the kde-workspaces. This has changed. None of the top ten distributions on distrowatch are shipping the integration parts of Compiz in an up to date version. Most distros are still on Compiz 0.8, which requires manual patching to keep up with changes in the decoration API. Distros on Compiz 0.9 are not shipping the KDE integration - this includes Ubuntu. Given this development it is no longer justified to have additional work on KWin side and because of that the API which should be internal is marked as internal again. In case Compiz is still interested in providing the kde-window-decorator the header file can easily be pulled from our repository. In addition this patch includes a method int decoration_bridge_version() which returns the current bridge API version. Kde-window-decorator can resolve this method and verify that the version is not higher than what is supported. The version number is provided in kdecoration.h by the define KWIN_DECORATION_BRIDGE_API_VERSION. We will increate the version number once per release in case the bridge changed. 4.11 will have the version number 1. This change in behavior has been discussed and agreed in [1]. The change also unexports KDecorationBridgeUnstable. This class should have never been exported, it was incorrect and the parent class had not been exported anyway. This is just a note to indicate that it is not an ABI break and there is no reason to increase the so number. [1] http://lists.kde.org/?l=kwin&m=136335502805911&w=2 CCMAIL: compiz@lists.freedesktop.org CCMAIL: dev@lists.compiz.org REVIEW: 109536 |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| kcommondecoration.cpp | ||
| kcommondecoration.h | ||
| kcommondecoration_p.cpp | ||
| kcommondecoration_p.h | ||
| kdecoration.cpp | ||
| kdecoration.h | ||
| kdecoration_p.cpp | ||
| kdecoration_p.h | ||
| kdecoration_plugins_p.cpp | ||
| kdecoration_plugins_p.h | ||
| kdecorationbridge.h | ||
| kdecorationfactory.cpp | ||
| kdecorationfactory.h | ||
| Mainpage.dox | ||
| Messages.sh | ||