9a7ab8a62e
Window management features were written with synchronous geometry updates in mind. Currently, this poses a big problem on Wayland because geometry updates are done in asynchronous fashion there. At the moment, geometry is updated in a so called pseudo-asynchronous fashion, meaning that the frame geometry will be reset to the old value once geometry updates are unblocked. The main drawback of this approach is that it is too error prone, the data flow is hard to comprehend, etc. It is worth noting that there is already a machinery to perform async geometry which is used during interactive move/resize operations. This change extends the move/resize geometry usage beyond interactive move/resize to make asynchronous geometry updates less error prone and easier to comprehend. With the proposed solution, all geometry updates must be done on the move/resize geometry first. After that, the new geometry is passed on to the Client-specific implementation of moveResizeInternal(). To be more specific, the frameGeometry() returns the current frame geometry, it is primarily useful only to the scene. If you want to move or resize a window, you need to use moveResizeGeometry() because it corresponds to the last requested frame geometry. It is worth noting that the moveResizeGeometry() returns the desired bounding geometry. The client may commit the xdg_toplevel surface with a slightly smaller window geometry, for example to enforce a specific aspect ratio. The client is not allowed to resize beyond the size as indicated in moveResizeGeometry(). The data flow is very simple: moveResize() updates the move/resize geometry and calls the client-specific implementation of the moveResizeInternal() method. Based on whether a configure event is needed, moveResizeInternal() will update the frameGeometry() either immediately or after the client commits a new buffer. Unfortunately, both the compositor and xdg-shell clients try to update the window geometry. It means that it's possible to have conflicts between the two. With this change, the compositor's move resize geometry will be synced only if there are no pending configure events, meaning that the user doesn't try to resize the window.
106 lines
1.7 KiB
C++
106 lines
1.7 KiB
C++
/*
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
SPDX-FileCopyrightText: 2014 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
SPDX-License-Identifier: GPL-2.0-or-later
|
|
*/
|
|
#include "mock_abstract_client.h"
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
AbstractClient::AbstractClient(QObject *parent)
|
|
: QObject(parent)
|
|
, m_active(false)
|
|
, m_screen(0)
|
|
, m_fullscreen(false)
|
|
, m_hiddenInternal(false)
|
|
, m_keepBelow(false)
|
|
, m_frameGeometry()
|
|
, m_resize(false)
|
|
{
|
|
}
|
|
|
|
AbstractClient::~AbstractClient() = default;
|
|
|
|
bool AbstractClient::isActive() const
|
|
{
|
|
return m_active;
|
|
}
|
|
|
|
void AbstractClient::setActive(bool active)
|
|
{
|
|
m_active = active;
|
|
}
|
|
|
|
void AbstractClient::setScreen(int screen)
|
|
{
|
|
m_screen = screen;
|
|
}
|
|
|
|
bool AbstractClient::isOnScreen(int screen) const
|
|
{
|
|
// TODO: mock checking client geometry
|
|
return screen == m_screen;
|
|
}
|
|
|
|
int AbstractClient::screen() const
|
|
{
|
|
return m_screen;
|
|
}
|
|
|
|
void AbstractClient::setFullScreen(bool set)
|
|
{
|
|
m_fullscreen = set;
|
|
}
|
|
|
|
bool AbstractClient::isFullScreen() const
|
|
{
|
|
return m_fullscreen;
|
|
}
|
|
|
|
bool AbstractClient::isHiddenInternal() const
|
|
{
|
|
return m_hiddenInternal;
|
|
}
|
|
|
|
void AbstractClient::setHiddenInternal(bool set)
|
|
{
|
|
m_hiddenInternal = set;
|
|
}
|
|
|
|
void AbstractClient::moveResize(const QRect &rect)
|
|
{
|
|
m_frameGeometry = rect;
|
|
emit geometryChanged();
|
|
}
|
|
|
|
QRect AbstractClient::frameGeometry() const
|
|
{
|
|
return m_frameGeometry;
|
|
}
|
|
|
|
bool AbstractClient::keepBelow() const
|
|
{
|
|
return m_keepBelow;
|
|
}
|
|
|
|
void AbstractClient::setKeepBelow(bool keepBelow)
|
|
{
|
|
m_keepBelow = keepBelow;
|
|
emit keepBelowChanged();
|
|
}
|
|
|
|
bool AbstractClient::isInteractiveResize() const
|
|
{
|
|
return m_resize;
|
|
}
|
|
|
|
void AbstractClient::setInteractiveResize(bool set)
|
|
{
|
|
m_resize = set;
|
|
}
|
|
|
|
}
|