kwin/effects/translucency/translucency.h
Martin Gräßlin 2cf35aa21a Remove animations from Translucency effect
The effect should have had two animations:
* on move resize
* on active/inactive change

But the timeline was adjusted in the prePaintWindow call and the timeline
is effect global and not per window. Which means that for each window the
same time is added. So instead of adding time t each frame t*n with n
being the number of windows got added. So in most cases the animation
ended in the first or second frame which means its not visible.

Through git blame I was able to track down that this incorrect behavior
was introduced in 2008. An animation broken for more than four years
without anybody noticing is probably not required. Because of that it's
dropped from the effect. As this includes quite some code and performance
improvements it goes into the release branch.

A better solution could be implemented, but that should be for 4.10.

BUG: 306263
FIXED-IN: 4.9.2
REVIEW: 106335
2012-09-07 07:39:50 +02:00

116 lines
3.4 KiB
C++

/********************************************************************
KWin - the KDE window manager
This file is part of the KDE project.
Copyright (C) 2006 Lubos Lunak <l.lunak@kde.org>
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*********************************************************************/
#ifndef KWIN_TRANSLUCENCY_H
#define KWIN_TRANSLUCENCY_H
#include <kwineffects.h>
#include <QtCore/QTimeLine>
namespace KWin
{
class TranslucencyEffect
: public Effect
{
Q_OBJECT
Q_PROPERTY(qreal decoration READ configuredDecoration)
Q_PROPERTY(qreal moveResize READ configuredMoveResize)
Q_PROPERTY(qreal dialogs READ configuredDialogs)
Q_PROPERTY(qreal inactive READ configuredInactive)
Q_PROPERTY(qreal comboboxPopups READ configuredComboboxPopups)
Q_PROPERTY(qreal menus READ configuredMenus)
Q_PROPERTY(bool individualMenuConfig READ isIndividualMenuConfig)
Q_PROPERTY(qreal dropDownMenus READ configuredDropDownMenus)
Q_PROPERTY(qreal popupMenus READ configuredPopupMenus)
Q_PROPERTY(qreal tornOffMenus READ configuredTornOffMenus)
public:
TranslucencyEffect();
virtual void reconfigure(ReconfigureFlags);
virtual void prePaintWindow(EffectWindow* w, WindowPrePaintData& data, int time);
virtual void paintWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data);
virtual bool isActive() const;
// for properties
qreal configuredDecoration() const {
return decoration;
}
qreal configuredMoveResize() const {
return moveresize;
}
qreal configuredDialogs() const {
return dialogs;
}
qreal configuredInactive() const {
return inactive;
}
qreal configuredComboboxPopups() const {
return comboboxpopups;
}
qreal configuredMenus() const {
return menus;
}
bool isIndividualMenuConfig() const {
return individualmenuconfig;
}
qreal configuredDropDownMenus() const {
return dropdownmenus;
}
qreal configuredPopupMenus() const {
return popupmenus;
}
qreal configuredTornOffMenus() const {
return tornoffmenus;
}
public Q_SLOTS:
void slotWindowActivated(KWin::EffectWindow* w);
void slotWindowStartStopUserMovedResized(KWin::EffectWindow *w);
private Q_SLOTS:
void checkIsActive();
private:
bool isInactive(const EffectWindow *w) const;
bool individualmenuconfig;
double decoration;
double moveresize;
double dialogs;
double inactive;
double comboboxpopups;
double menus;
double dropdownmenus;
double popupmenus;
double tornoffmenus;
EffectWindow* active;
bool m_activeDecorations;
bool m_activeMoveResize;
bool m_activeDialogs;
bool m_activeInactive;
bool m_activeCombobox;
bool m_activeMenus;
bool m_active;
};
} // namespace
#endif