2b196bfa29
Summary: To use eglCreateImageKhr for an X11 pixmap we need an EGLDisplay created for the same XDisplay as the X11 pixmap. This means if we created an EGLDisplay for a GBM device, we are not allowed to load a texture from the X11 pixmap and can result in a crash in the driver. Similar in the nested X11 setup the EGLDisplay is created for the rendering window, but the X11 pixmaps are from the Xwayland server KWin started. They don't belong to the same windowing system. This change addresses this problem by moving the loading of X11 pixmaps from AbstractEglTexture to EglTexture of the EglOnX11Backend. Thus for any usage on a non X11 platform we cannot hit the code path any more. In addition the nested X11 platform can indicate that it doesn't support it and thus also doesn't go through the code path. Test Plan: Tested standalone and nested X11 platform Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D1857
112 lines
3.2 KiB
C++
112 lines
3.2 KiB
C++
/********************************************************************
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
Copyright (C) 2015 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*********************************************************************/
|
|
#ifndef KWIN_ABSTRACT_EGL_BACKEND_H
|
|
#define KWIN_ABSTRACT_EGL_BACKEND_H
|
|
#include "scene_opengl.h"
|
|
|
|
class QOpenGLFramebufferObject;
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
class KWIN_EXPORT AbstractEglBackend : public OpenGLBackend
|
|
{
|
|
public:
|
|
virtual ~AbstractEglBackend();
|
|
bool makeCurrent() override;
|
|
void doneCurrent() override;
|
|
|
|
EGLDisplay eglDisplay() const {
|
|
return m_display;
|
|
}
|
|
EGLContext context() const {
|
|
return m_context;
|
|
}
|
|
|
|
protected:
|
|
AbstractEglBackend();
|
|
EGLSurface surface() const {
|
|
return m_surface;
|
|
}
|
|
EGLConfig config() const {
|
|
return m_config;
|
|
}
|
|
void setEglDisplay(const EGLDisplay &display) {
|
|
m_display = display;
|
|
}
|
|
void setSurface(const EGLSurface &surface) {
|
|
m_surface = surface;
|
|
}
|
|
void setConfig(const EGLConfig &config) {
|
|
m_config = config;
|
|
}
|
|
void cleanup();
|
|
virtual void cleanupSurfaces();
|
|
bool initEglAPI();
|
|
void initKWinGL();
|
|
void initBufferAge();
|
|
void initClientExtensions();
|
|
void initWayland();
|
|
bool hasClientExtension(const QByteArray &ext) const;
|
|
bool isOpenGLES() const;
|
|
|
|
bool createContext();
|
|
|
|
private:
|
|
EGLDisplay m_display = EGL_NO_DISPLAY;
|
|
EGLSurface m_surface = EGL_NO_SURFACE;
|
|
EGLContext m_context = EGL_NO_CONTEXT;
|
|
EGLConfig m_config = nullptr;
|
|
QList<QByteArray> m_clientExtensions;
|
|
};
|
|
|
|
class KWIN_EXPORT AbstractEglTexture : public SceneOpenGL::TexturePrivate
|
|
{
|
|
public:
|
|
virtual ~AbstractEglTexture();
|
|
bool loadTexture(WindowPixmap *pixmap) override;
|
|
void updateTexture(WindowPixmap *pixmap) override;
|
|
OpenGLBackend *backend() override;
|
|
|
|
protected:
|
|
AbstractEglTexture(SceneOpenGL::Texture *texture, AbstractEglBackend *backend);
|
|
EGLImageKHR image() const {
|
|
return m_image;
|
|
}
|
|
void setImage(const EGLImageKHR &img) {
|
|
m_image = img;
|
|
}
|
|
SceneOpenGL::Texture *texture() const {
|
|
return q;
|
|
}
|
|
|
|
private:
|
|
bool loadShmTexture(const QPointer<KWayland::Server::BufferInterface> &buffer);
|
|
bool loadEglTexture(const QPointer<KWayland::Server::BufferInterface> &buffer);
|
|
EGLImageKHR attach(const QPointer<KWayland::Server::BufferInterface> &buffer);
|
|
bool updateFromFBO(const QSharedPointer<QOpenGLFramebufferObject> &fbo);
|
|
SceneOpenGL::Texture *q;
|
|
AbstractEglBackend *m_backend;
|
|
EGLImageKHR m_image;
|
|
};
|
|
|
|
}
|
|
|
|
#endif
|