47343fb8f7
Summary: The gbm_surface is owned by the EglGbmBackend, but it's not the only one using it. The DrmSurfaceBuffer is also using it and needs it to destroy the gbm_bo. Now this can become a problem in the following situation: * a page flip is still pending * the EglGbmBackend destroys the gbm_surface -> when the page flip happens the DrmSurfaceBuffer will try to destroy the gbm_bo and crash as the gbm_surface is no longer valid. This situation can happen when switching screens or when switching compositing backend (OpenGL 2 -> OpenGL 3). To address this problem a class GbmSurface is added which wrapps the gbm_surface pointer. The EglGbmBackend creates and holds a shared pointer to the GbmSurface and passes that one to the DrmSurfaceBuffer. So when cleaning up the gbm_surface only the shared pointer is reset and in case the DrmSurfaceBuffer still needs it, it can access it without problems. BUG: 385372 FIXED-IN: 5.11.0 Test Plan: Not yet Reviewers: #kwin, #plasma, subdiff Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D8152
68 lines
2 KiB
C++
68 lines
2 KiB
C++
/********************************************************************
|
|
KWin - the KDE window manager
|
|
This file is part of the KDE project.
|
|
|
|
Copyright 2017 Roman Gilg <subdiff@gmail.com>
|
|
Copyright 2015 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*********************************************************************/
|
|
#include "drm_backend.h"
|
|
#include "drm_buffer_gbm.h"
|
|
#include "gbm_surface.h"
|
|
|
|
#include "logging.h"
|
|
|
|
// system
|
|
#include <sys/mman.h>
|
|
#include <errno.h>
|
|
// drm
|
|
#include <xf86drm.h>
|
|
#include <gbm.h>
|
|
|
|
namespace KWin
|
|
{
|
|
|
|
// DrmSurfaceBuffer
|
|
DrmSurfaceBuffer::DrmSurfaceBuffer(DrmBackend *backend, const std::shared_ptr<GbmSurface> &surface)
|
|
: DrmBuffer(backend)
|
|
, m_surface(surface)
|
|
{
|
|
m_bo = m_surface->lockFrontBuffer();
|
|
if (!m_bo) {
|
|
qCWarning(KWIN_DRM) << "Locking front buffer failed";
|
|
return;
|
|
}
|
|
m_size = QSize(gbm_bo_get_width(m_bo), gbm_bo_get_height(m_bo));
|
|
if (drmModeAddFB(m_backend->fd(), m_size.width(), m_size.height(), 24, 32, gbm_bo_get_stride(m_bo), gbm_bo_get_handle(m_bo).u32, &m_bufferId) != 0) {
|
|
qCWarning(KWIN_DRM) << "drmModeAddFB failed";
|
|
}
|
|
gbm_bo_set_user_data(m_bo, this, nullptr);
|
|
}
|
|
|
|
DrmSurfaceBuffer::~DrmSurfaceBuffer()
|
|
{
|
|
if (m_bufferId) {
|
|
drmModeRmFB(m_backend->fd(), m_bufferId);
|
|
}
|
|
releaseGbm();
|
|
}
|
|
|
|
void DrmSurfaceBuffer::releaseGbm()
|
|
{
|
|
m_surface->releaseBuffer(m_bo);
|
|
m_bo = nullptr;
|
|
}
|
|
|
|
}
|