8af2fa73dc
Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371
139 lines
4 KiB
C++
139 lines
4 KiB
C++
/*
|
|
* Copyright 2014 Martin Gräßlin <mgraesslin@kde.org>
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation; either version 2 of
|
|
* the License or (at your option) version 3 or any later version
|
|
* accepted by the membership of KDE e.V. (or its successor approved
|
|
* by the membership of KDE e.V.), which shall act as a proxy
|
|
* defined in Section 14 of version 3 of the license.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
#ifndef KDECOARTIONS_PREVIEW_BRIDGE_H
|
|
#define KDECOARTIONS_PREVIEW_BRIDGE_H
|
|
|
|
#include <KDecoration2/Private/DecorationBridge>
|
|
#include <KDecoration2/DecorationButton>
|
|
|
|
#include <QList>
|
|
#include <QPointer>
|
|
|
|
class KPluginFactory;
|
|
|
|
namespace KDecoration2
|
|
{
|
|
namespace Preview
|
|
{
|
|
|
|
class PreviewClient;
|
|
class PreviewItem;
|
|
class PreviewSettings;
|
|
|
|
class PreviewBridge : public DecorationBridge
|
|
{
|
|
Q_OBJECT
|
|
Q_PROPERTY(QString plugin READ plugin WRITE setPlugin NOTIFY pluginChanged)
|
|
Q_PROPERTY(QString theme READ theme WRITE setTheme NOTIFY themeChanged)
|
|
Q_PROPERTY(bool valid READ isValid NOTIFY validChanged)
|
|
public:
|
|
explicit PreviewBridge(QObject *parent = nullptr);
|
|
~PreviewBridge() override;
|
|
std::unique_ptr<DecoratedClientPrivate> createClient(DecoratedClient *client, Decoration *decoration) override;
|
|
void update(Decoration* decoration, const QRect& geometry) override;
|
|
std::unique_ptr<DecorationSettingsPrivate> settings(DecorationSettings *parent) override;
|
|
|
|
PreviewClient *lastCreatedClient() {
|
|
return m_lastCreatedClient;
|
|
}
|
|
PreviewSettings *lastCreatedSettings() {
|
|
return m_lastCreatedSettings;
|
|
}
|
|
|
|
void registerPreviewItem(PreviewItem *item);
|
|
void unregisterPreviewItem(PreviewItem *item);
|
|
|
|
void setPlugin(const QString &plugin);
|
|
QString plugin() const;
|
|
void setTheme(const QString &theme);
|
|
QString theme() const;
|
|
bool isValid() const;
|
|
|
|
KDecoration2::Decoration *createDecoration(QObject *parent = nullptr);
|
|
KDecoration2::DecorationButton *createButton(KDecoration2::Decoration *decoration, KDecoration2::DecorationButtonType type, QObject *parent = nullptr);
|
|
|
|
public Q_SLOTS:
|
|
void configure();
|
|
|
|
Q_SIGNALS:
|
|
void pluginChanged();
|
|
void themeChanged();
|
|
void validChanged();
|
|
|
|
private:
|
|
void createFactory();
|
|
void setValid(bool valid);
|
|
PreviewClient *m_lastCreatedClient;
|
|
PreviewSettings *m_lastCreatedSettings;
|
|
QList<PreviewItem*> m_previewItems;
|
|
QString m_plugin;
|
|
QString m_theme;
|
|
QPointer<KPluginFactory> m_factory;
|
|
bool m_valid;
|
|
};
|
|
|
|
class BridgeItem : public QObject
|
|
{
|
|
Q_OBJECT
|
|
Q_PROPERTY(QString plugin READ plugin WRITE setPlugin NOTIFY pluginChanged)
|
|
Q_PROPERTY(QString theme READ theme WRITE setTheme NOTIFY themeChanged)
|
|
Q_PROPERTY(bool valid READ isValid NOTIFY validChanged)
|
|
Q_PROPERTY(KDecoration2::Preview::PreviewBridge *bridge READ bridge CONSTANT)
|
|
|
|
public:
|
|
explicit BridgeItem(QObject *parent = nullptr);
|
|
~BridgeItem() override;
|
|
|
|
void setPlugin(const QString &plugin) {
|
|
m_bridge->setPlugin(plugin);
|
|
}
|
|
QString plugin() const {
|
|
return m_bridge->plugin();
|
|
}
|
|
void setTheme(const QString &theme) {
|
|
m_bridge->setTheme(theme);
|
|
}
|
|
QString theme() const {
|
|
return m_bridge->theme();
|
|
}
|
|
bool isValid() const {
|
|
return m_bridge->isValid();
|
|
}
|
|
|
|
PreviewBridge *bridge() const {
|
|
return m_bridge;
|
|
}
|
|
|
|
Q_SIGNALS:
|
|
void pluginChanged();
|
|
void themeChanged();
|
|
void validChanged();
|
|
|
|
private:
|
|
PreviewBridge *m_bridge;
|
|
|
|
};
|
|
|
|
}
|
|
}
|
|
|
|
Q_DECLARE_METATYPE(KDecoration2::Preview::PreviewBridge *)
|
|
|
|
#endif
|